From nobody Fri Oct 06 17:06:03 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S2FF742Ffz4x5wW; Fri, 6 Oct 2023 17:06:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S2FF73L6kz4Wcn; Fri, 6 Oct 2023 17:06:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696611963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JRM3YLLsm/Yd9Yet1biAFpkL9uwJKnKXX1v6+VIU5YA=; b=TbbNh5xlE9us9bodfHo4qsbQ73YsrlNAn2yubr8tyYgO0O3rO8agp9lIrgwJTDRXAF9262 f8Uk0JZmuQurGCmUcQBSFe5CORFSIPFWg6kGbNqC+75Lv6Auli7+gviGlipuD+TQ5x5qQo OReBHygU7jmtGWSc1f2MdaF58GIRulK6+pHX65zqp4sVMDmuyr7+Tf4KZ0rFgvNgFwvHVh TbaQOoJ0snO18KY+78LedyK92cqbxU/3XkIulEkC2thxr+k6Uvje042NUmcbwCZj7S1afe WVA8sTGNyBjwsLc0brv6Fnei9L1vZAxwibGNOj7hoDko0itKiyYN0tFT8xuyDQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696611963; a=rsa-sha256; cv=none; b=n0PTFc+bZKJz5glfHKBPNsW1sHbh6j9gUzvOGOlhcFHWPFLE256E6OC6Vb0Gl1J/6iBMlV 1liNv8Spv4FJt/6ZaQSyiZHZx4cJl8z4xdVLv1PLDK/gzTq+DXBrTFSyj0Z8wnwID1Fh+w 2YaywvExh9qeGJ4ltqYeTeWFmqWVd7DX7UMIWXCLPZQ4IP5EcxSL0couKQIpAyygdFN8G/ 5byBqUhftyQh7SgD3HwkJnQJDoCJHLp272xr/hFwndJgdyB1iAu6Zt2SaQIMV+p6iq9cwQ li+bImbh9U3KdLCLbWRyeQ2fs7Oj5/4qi8eWe5s2jMpMRccDf1HW7xel+vFe1w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696611963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JRM3YLLsm/Yd9Yet1biAFpkL9uwJKnKXX1v6+VIU5YA=; b=JpRIt+ITaDhEFybyfuZNKWKyQtBNWgX0yNvLLCbjjojjI5H9OIIlYfaGEIOpzrRkbIGrO4 x32QFWVG4VvYgHfiJ7BLJSRxgZplQCY2KtIoLBE75nD9+ZKjtbeoi08MoYwjqA4PWsxcGz /QUELd6k1q624qngr1HwjsdxH2IRkf2JBc9OvIz3m3kNDEpEQ+K/9ZjPQEf1Sb2ND6VFyv ODz/ah42ewsaFsgRZylfkLwfo+z9OZyt0c5OPqRDPz2giJtQopgTEn1FgiRzxmlzcdFlTA DnilUGyMRZaTJkPBrtXJTKue2dwXdwOA1OFPW/bCKSsT/VDrUdiMMy1vCGtxIg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S2FF72F8YzwjN; Fri, 6 Oct 2023 17:06:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 396H63ql060811; Fri, 6 Oct 2023 17:06:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 396H63in060807; Fri, 6 Oct 2023 17:06:03 GMT (envelope-from git) Date: Fri, 6 Oct 2023 17:06:03 GMT Message-Id: <202310061706.396H63in060807@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Emmanuel Vadot Subject: git: 38cbdae33b7c - main - dwc: Rewrite barrier part List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 38cbdae33b7c3f772845c06f52b86c0ddeab6a17 Auto-Submitted: auto-generated The branch main has been updated by manu: URL: https://cgit.FreeBSD.org/src/commit/?id=38cbdae33b7c3f772845c06f52b86c0ddeab6a17 commit 38cbdae33b7c3f772845c06f52b86c0ddeab6a17 Author: Emmanuel Vadot AuthorDate: 2023-10-06 16:04:49 +0000 Commit: Emmanuel Vadot CommitDate: 2023-10-06 17:05:45 +0000 dwc: Rewrite barrier part We only need a barrier after writing the OWN bit so everything is coherent for the DMA engine. --- sys/dev/dwc/dwc1000_dma.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/dwc/dwc1000_dma.c b/sys/dev/dwc/dwc1000_dma.c index f6baa0bd3e45..4f8ae088305a 100644 --- a/sys/dev/dwc/dwc1000_dma.c +++ b/sys/dev/dwc/dwc1000_dma.c @@ -216,7 +216,6 @@ txdesc_setup(struct dwc_softc *sc, int idx, bus_addr_t paddr, sc->txdesc_ring[idx].addr1 = (uint32_t)(paddr); sc->txdesc_ring[idx].desc0 = desc0; sc->txdesc_ring[idx].desc1 = desc1; - wmb(); sc->txdesc_ring[idx].desc0 |= TDESC0_OWN; wmb(); } @@ -237,7 +236,6 @@ rxdesc_setup(struct dwc_softc *sc, int idx, bus_addr_t paddr) sc->rxdesc_ring[idx].desc1 = ERDESC1_RCH | MIN(MCLBYTES, ERDESC1_RBS1_MASK); - wmb(); sc->rxdesc_ring[idx].desc0 = RDESC0_OWN; wmb(); return (nidx); @@ -524,7 +522,6 @@ dma1000_rxfinish_locked(struct dwc_softc *sc) m = dwc_rxfinish_one(sc, desc, sc->rxbuf_map + idx); if (m == NULL) { - wmb(); desc->desc0 = RDESC0_OWN; wmb(); } else {