git: 5e78399dda05 - releng/14.0 - makefs/zfs: Remove a nonsensical comment
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 05 Oct 2023 15:10:20 UTC
The branch releng/14.0 has been updated by markj:
URL: https://cgit.FreeBSD.org/src/commit/?id=5e78399dda052dfa8c62b3e8b678d29196ca7a0c
commit 5e78399dda052dfa8c62b3e8b678d29196ca7a0c
Author: Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2023-09-27 22:21:37 +0000
Commit: Mark Johnston <markj@FreeBSD.org>
CommitDate: 2023-10-05 14:01:26 +0000
makefs/zfs: Remove a nonsensical comment
When populating files, makefs needs to copy their contents into
userspace in order to compute a checksum, so copy_file_range(2) is out
of the question. Though, it could possibly be used when building other
types of filesystems.
Approved by: re (gjb)
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
(cherry picked from commit 60c95af88f6a63fb7c2c86c6ff9c18743f6bbf0d)
(cherry picked from commit 0074d0551ded1652155a23c6a8d04043c8ede1fd)
---
usr.sbin/makefs/zfs/fs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/usr.sbin/makefs/zfs/fs.c b/usr.sbin/makefs/zfs/fs.c
index a4968d5f91e8..0d85ea8eb9d8 100644
--- a/usr.sbin/makefs/zfs/fs.c
+++ b/usr.sbin/makefs/zfs/fs.c
@@ -551,8 +551,6 @@ fs_populate_file(fsnode *cur, struct fs_populate_arg *arg)
/*
* Fill up our buffer, handling partial reads.
- *
- * It might be profitable to use copy_file_range(2) here.
*/
sofar = 0;
target = MIN(size - foff, (off_t)bufsz);