From nobody Tue Oct 03 21:19:32 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S0W1105QSz4w0vY; Tue, 3 Oct 2023 21:19:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S0W106fHPz4l5P; Tue, 3 Oct 2023 21:19:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696367972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Pmlsh1WqGgYjC08jqAG7GP2FDp2ZDk+yOCJZG/2ejIc=; b=IxyUUZ8hbzN/WJCOTEIPwisJmmp+5aYh2BTly4b79ybhfiRooEbmiv49uNZIlJ4IbtIRYM dsT+crpxqjBMtUK4FOFKKhbJIzrgaUNs64i4Vd7l22m8/XGAlEA43XPzBeRPpr312FkxPp J/UU+5ZZQU0E/Umy2P2U67LCTg8b6hOtNbopSFIJMXOrWD0rVEEFemG0zW4Fx7Py68VDM3 mWR8RGlaIW3lh8JzhfN0w3cxUrpi5UHfdwNHRblbjUPCPrI12mQ0gFjgQvYFZYoIjPhtl1 3EWuVH8ZotVRux909sHnFd5U0oE9pQx5/0C1dodKtHk1dUFREBXyfKSl5BgpHg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696367972; a=rsa-sha256; cv=none; b=EdI9uwJBEXi2NzWxSGz1dULivAwELXFY3Oi7E6Jbos9oDwS50+EY/KcsuUivgmd8IqYYUk YKjvEUaFHlapHFwumbZtOjX1vAwGN44IjTz+J3QVCEeU73oCcf2Ly7/GYnMI6+fG31z6d3 xIp3KZTjovt3V/lMrRsBQX8Uw5lekeVG6ym5WXlhetIkAfeTpg7ssXmR+XPt7bhyyJ3UFJ HZYYuUyGxWfwC7jUOvfk7afxgDmFiT+1SFkgRbR7/7xRmNi+lZSDzWu4SGS+2UNSyb4fOU 99Mi87RNPsrp2n/s+xn3eKR94vZnh+z1KVvDYOKFWMzK9zMVi+ktAa7MMDutCg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696367972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Pmlsh1WqGgYjC08jqAG7GP2FDp2ZDk+yOCJZG/2ejIc=; b=HZg/sZQ45EYc9VWV/8V15OdFNjcndt5TEelXvekbP03fBk61qVCihp2sxfUgOoezrAan/Z 6ZUl7YHfuYGAAuAMg+26hgorXbeacj5ToN0bPSE733Fw2UEDw9V5SifXAoNqp1oPuWoiFV ONcSUicGgU0YflsdII8irxSVNbKydZUuUROq3rbRXZKGNRVZwXFaFoHaT8t28N+y33Cjbs ml6cFpnrdHNRFZC38MmXTLtVJq6w9Ozbvz0mLuSVOgSkL9/4/RVSEQlZZgo+W+GaG1gorH cYALPLVX2IVLZza0nB8P9GF6k8LNsCAd9OmOH2Ugw3XYNlIjd+HpBZWSh6pX5A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S0W105gKSz198v; Tue, 3 Oct 2023 21:19:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 393LJWBE071513; Tue, 3 Oct 2023 21:19:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 393LJWBa071510; Tue, 3 Oct 2023 21:19:32 GMT (envelope-from git) Date: Tue, 3 Oct 2023 21:19:32 GMT Message-Id: <202310032119.393LJWBa071510@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 6c38c6b1b917 - main - LinuxKPI: 802.11: fix re-creation of VAP List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6c38c6b1b917957d420902213f318bf0153214f2 Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=6c38c6b1b917957d420902213f318bf0153214f2 commit 6c38c6b1b917957d420902213f318bf0153214f2 Author: Bjoern A. Zeeb AuthorDate: 2023-10-03 21:14:55 +0000 Commit: Bjoern A. Zeeb CommitDate: 2023-10-03 21:18:29 +0000 LinuxKPI: 802.11: fix re-creation of VAP After dbf7691999abe (as indicated in that commit message) EEXISTS errors may be seen. From current investigation that is due to the single-VAP support in LinuxKPI 802.11 and the related calls to mo_start() and mo_stop() and them being disabled in ic_parent() currently. Calling mo_stop() in lkpi_ic_vap_delete() seems to fix the problem and new VAPs (wlan interfaces) can be created again after being destroyed. Fixes: dbf7691999abe ("improve lkpi_ic_vap_delete()") Sponsored by: The FreeBSD Foundation MFC after: 3 days --- sys/compat/linuxkpi/common/src/linux_80211.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index 7565f491606b..9f5f5bef7f27 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -2481,6 +2481,9 @@ lkpi_ic_vap_delete(struct ieee80211vap *vap) lkpi_80211_mo_remove_interface(hw, vif); + /* Single VAP, so we can do this here. */ + lkpi_80211_mo_stop(hw); + mtx_destroy(&lvif->mtx); free(lvif, M_80211_VAP); }