From nobody Mon Oct 02 02:53:15 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RzQW23sSNz4w8l9; Mon, 2 Oct 2023 02:53:18 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RzQW21Xwmz3Hyg; Mon, 2 Oct 2023 02:53:18 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTPS id mt8uqaCsmmfesn93dqBm9s; Mon, 02 Oct 2023 02:53:17 +0000 Received: from spqr.komquats.com ([70.66.152.170]) by cmsmtp with ESMTPSA id n93bq5R3eSxZQn93cqPmq7; Mon, 02 Oct 2023 02:53:17 +0000 X-Authority-Analysis: v=2.4 cv=JbqvEGGV c=1 sm=1 tr=0 ts=651a309d a=y8EK/9tc/U6QY+pUhnbtgQ==:117 a=y8EK/9tc/U6QY+pUhnbtgQ==:17 a=kj9zAlcOel0A:10 a=bhdUkHdE2iEA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=mVaAT9imt_-sTEsIGqYA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 53D9B33E2; Sun, 1 Oct 2023 19:53:15 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 41C99A7C; Sun, 1 Oct 2023 19:53:15 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Zhenlei Huang cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: Re: git: a9359dcde241 - stable/14 - ipfilter: Add sysctl flag CTLFLAG_TUN to loader tunable In-reply-to: <202310020050.3920omhH029460@gitrepo.freebsd.org> References: <202310020050.3920omhH029460@gitrepo.freebsd.org> Comments: In-reply-to Zhenlei Huang message dated "Mon, 02 Oct 2023 00:50:48 +0000." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 01 Oct 2023 19:53:15 -0700 Message-Id: <20231002025315.41C99A7C@slippy.cwsent.com> X-CMAE-Envelope: MS4xfPTwxOQxjj/VsUT7vu59nLyivchlWK4LJEJ3OP0rVMtMCk6QTUkD+cTJGfwxkiJmi53rNwuoZp2h1fNGBXns0Gt8xBWnOCZzJMr3LGf6FiWUXulnIDqa 0onaoIchQukLemg2qO59JMfhCFvrQTY18dJ4lQeqvkr3REh+j8FDWUQ4cEOa77KgiMvo3RqodUUBAnMy/kIjhadapBSGN9mGjF+PHiNAS4x3I9qpgEILeP2r spCirwh+T02juqIS12Kw2t1cjowdO50TJE+Nc+iXFu7FdVky7XcSVEJwYJcRcM9XTGMhKfggiVQMy6Ja8Aybcquu+ZvpcuRRpBQs4gsAVlo= X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4RzQW21Xwmz3Hyg In message <202310020050.3920omhH029460@gitrepo.freebsd.org>, Zhenlei Huang wri tes: > The branch stable/14 has been updated by zlei: > > URL: https://cgit.FreeBSD.org/src/commit/?id=a9359dcde241f17421a71bc8c96dee08 > 625db9dd > > commit a9359dcde241f17421a71bc8c96dee08625db9dd > Author: Zhenlei Huang > AuthorDate: 2023-09-29 00:01:43 +0000 > Commit: Zhenlei Huang > CommitDate: 2023-10-02 00:49:38 +0000 > > ipfilter: Add sysctl flag CTLFLAG_TUN to loader tunable > > The sysctl variable `net.inet.ipf.large_nat` is actually a loader > tunable. Add sysctl flag CTLFLAG_TUN to it so that `sysctl -T` will > report it correctly. > > No functional change intended. > > Reviewed by: cy (for #network) > Fixes: a805ffbcbce8 ipfilter: Make LARGE_NAT a tunable > MFC after: 3 days > Differential Revision: https://reviews.freebsd.org/D42005 > > (cherry picked from commit ba883e7a5ac43b27a373f2b1b0044fd2eb769d4e) > --- > sys/netpfil/ipfilter/netinet/mlfk_ipl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/netpfil/ipfilter/netinet/mlfk_ipl.c b/sys/netpfil/ipfilter/n > etinet/mlfk_ipl.c > index 35daad4715bf..69be4abb2485 100644 > --- a/sys/netpfil/ipfilter/netinet/mlfk_ipl.c > +++ b/sys/netpfil/ipfilter/netinet/mlfk_ipl.c > @@ -134,7 +134,7 @@ SYSCTL_IPF(_net_inet_ipf, OID_AUTO, fr_running, CTLFLAG_R > D, > &VNET_NAME(ipfmain.ipf_running), 0, "IPF is running"); > SYSCTL_IPF(_net_inet_ipf, OID_AUTO, fr_chksrc, CTLFLAG_RW, &VNET_NAME(ipfmai > n.ipf_chksrc), 0, ""); > SYSCTL_IPF(_net_inet_ipf, OID_AUTO, fr_minttl, CTLFLAG_RW, &VNET_NAME(ipfmai > n.ipf_minttl), 0, ""); > -SYSCTL_IPF(_net_inet_ipf, OID_AUTO, large_nat, CTLFLAG_RD, &VNET_NAME(ipfmai > n.ipf_large_nat), 0, "large_nat"); > +SYSCTL_IPF(_net_inet_ipf, OID_AUTO, large_nat, CTLFLAG_RDTUN | CTLFLAG_NOFET > CH, &VNET_NAME(ipfmain.ipf_large_nat), 0, "large_nat"); > > #define CDEV_MAJOR 79 > #include > Can you also please MFC to stable/13 and 12? -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0 X-B