From nobody Thu Nov 30 15:30:02 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sh0Vy6GB1z52CQw; Thu, 30 Nov 2023 15:30:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sh0Vy5jdwz4NbF; Thu, 30 Nov 2023 15:30:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701358202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UVYVsGluNaxGq2AtWkWtRm0HXXedDI5S1N4JGG/6iRE=; b=Jh+joEbbg3vG2zRCTztm8FMMkV7WBSAjXl/FZrqMjx9aAIJj5rYNstowNeexmz3Zacxq0a UPb54qlDO7m2AJ1Iui4pFPfsKIsrHkkq6+LSlZ9F2aKuqM4ZM+ymRwGP6ais3RD3U509UA PbdJHqM0QeY4/gQV/mVJ/V+BnBBRaTd/uASoR+vHhIsk9BPl2PGLzXA6udhEjs305PKaBV CqedWOtUQBtQJvvJ82SePn9H58AQSvIQ4QC+44UASRd+f6QXl2KdAdTS7GZi6hfHWgk7sZ 1HEAZYzK9D2LJ9a7lqiGc2q2QkqHTtS2+XQUEgiFjxnmgNqOJo7TByEiP5uapw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701358202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UVYVsGluNaxGq2AtWkWtRm0HXXedDI5S1N4JGG/6iRE=; b=wVypg1DdguDaZNciezPTzf9HPm85K3/2NVoDMFi5lrngtpbI6Bsw8XsmPVUI0QpHjz8JHg nmKOiawfNS4Y8gMDfZDV6kFnhsUGUxWtUCXLBavo5cbXbLyDCsXStLYIsocXTlij5m2Vbo Oamk33IKY2uwEVzUzNuaM7pSzuSt0adZv/ciqpvJ6CxyObjYfHtaoX5dynMTfAfsfZpwfj 8PlO9xr5H03eTtYhmikmJZxWhaZ2MCTWBPdfXNaavtj0h9duaswe/w5ICP0HA+CM+KuCO5 Peyue8qMTcBSYV35IDYQK+ScXiq6+9GUxGdg+p0b4j5LtUglBI4nh9eKGxrang== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701358202; a=rsa-sha256; cv=none; b=wp8na+W7OeZ//IBYSEcl3KhZQ33sANBnwWfyNl37RPuX1iMut7e+5OTBeXNzWOgNNCusSz 4/2+QueF9vOdFSqcXHAGxnUP5854PyRDAfC8YuA4DKD9ToRp8WyUEJo3yP1bplIrTqkRa0 /V8l252fUHfIzGOh80m2v2DK8fePmbwXhW7QycTrqKMwrOMG/A7p7Pal1k2xp3pUPx9q2N nnmY7KbtHXmwxlLmgcj6PRzGuTpS8bwn7bJkTcKavd+YBUIxadmN9p2nb6EoVxyFoPekE8 vm7wrku1RzP1fkSCd3DGNbFNaSSQU2aY3Hnehyl2ePC2OLayYyOFbehpO0iGjA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Sh0Vy4m4RzvfH; Thu, 30 Nov 2023 15:30:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3AUFU2ij041642; Thu, 30 Nov 2023 15:30:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3AUFU25c041637; Thu, 30 Nov 2023 15:30:02 GMT (envelope-from git) Date: Thu, 30 Nov 2023 15:30:02 GMT Message-Id: <202311301530.3AUFU25c041637@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Richard Scheffenegger Subject: git: 34c45bc6a394 - main - tcp: enable LRD by default List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rscheff X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 34c45bc6a3940ccfddb60207cb103f73bf87c4a6 Auto-Submitted: auto-generated The branch main has been updated by rscheff: URL: https://cgit.FreeBSD.org/src/commit/?id=34c45bc6a3940ccfddb60207cb103f73bf87c4a6 commit 34c45bc6a3940ccfddb60207cb103f73bf87c4a6 Author: Richard Scheffenegger AuthorDate: 2023-11-30 04:33:50 +0000 Commit: Richard Scheffenegger CommitDate: 2023-11-30 04:38:16 +0000 tcp: enable LRD by default Lost Retransmission Detection was added as a feature in May 2021, but disabled by default. Enabling the feature by default to reduce the flow completion time by avoiding RTOs when retransmissions get lost too. Reviewed By: tuexen, #transport, zlei MFC after: 10 weeks Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D42845 --- share/man/man4/tcp.4 | 4 ++-- sys/netinet/tcp_input.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/share/man/man4/tcp.4 b/share/man/man4/tcp.4 index 3f54d904abc8..317ee818f3a4 100644 --- a/share/man/man4/tcp.4 +++ b/share/man/man4/tcp.4 @@ -31,7 +31,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd November 17, 2023 +.Dd November 30, 2023 .Dt TCP 4 .Os .Sh NAME @@ -465,7 +465,7 @@ Maximum amount of time, in milliseconds, before a delayed ACK is sent. .It Va delayed_ack Delay ACK to try and piggyback it onto a data packet or another ACK. .It Va do_lrd -Enable Lost Retransmission Detection for SACK-enabled sessions, disabled by +Enable Lost Retransmission Detection for SACK-enabled sessions, enabled by default. Under severe congestion, a retransmission can be lost which then leads to a mandatory Retransmission Timeout (RTO), followed by slow-start. diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c index e20c09f981cd..a75dbd1547b0 100644 --- a/sys/netinet/tcp_input.c +++ b/sys/netinet/tcp_input.c @@ -162,7 +162,7 @@ SYSCTL_INT(_net_inet_tcp, OID_AUTO, do_prr, CTLFLAG_VNET | CTLFLAG_RW, &VNET_NAME(tcp_do_prr), 1, "Enable Proportional Rate Reduction per RFC 6937"); -VNET_DEFINE(int, tcp_do_lrd) = 0; +VNET_DEFINE(int, tcp_do_lrd) = 1; SYSCTL_INT(_net_inet_tcp, OID_AUTO, do_lrd, CTLFLAG_VNET | CTLFLAG_RW, &VNET_NAME(tcp_do_lrd), 1, "Perform Lost Retransmission Detection");