git: 3cd4af3825b5 - stable/13 - iwlwifi: re-enable "Invalid TXQ id" logging
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 29 Nov 2023 16:38:49 UTC
The branch stable/13 has been updated by bz:
URL: https://cgit.FreeBSD.org/src/commit/?id=3cd4af3825b564a6bf249b0f8d2e5dd1368ca49a
commit 3cd4af3825b564a6bf249b0f8d2e5dd1368ca49a
Author: Bjoern A. Zeeb <bz@FreeBSD.org>
AuthorDate: 2023-10-09 19:47:39 +0000
Commit: Bjoern A. Zeeb <bz@FreeBSD.org>
CommitDate: 2023-11-29 16:36:11 +0000
iwlwifi: re-enable "Invalid TXQ id" logging
Various reports recently hit the "Invalid TXQ id" in iwlwifi again.
Unconditionally enable logging and add a note to report to a specific
PR in the log message for now.
Along with 018d93ece16b this will hopefully help us to understand what
is going on.
Sponsored by: The FreeBSD Foundation
PR: 274382
(cherry picked from commit ad134f8ab768e3b1d2db203f1cc963bdf0eea857)
---
sys/contrib/dev/iwlwifi/mvm/tx.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/sys/contrib/dev/iwlwifi/mvm/tx.c b/sys/contrib/dev/iwlwifi/mvm/tx.c
index 2407d0ee832e..da33c1a5cc46 100644
--- a/sys/contrib/dev/iwlwifi/mvm/tx.c
+++ b/sys/contrib/dev/iwlwifi/mvm/tx.c
@@ -1199,9 +1199,10 @@ static int iwl_mvm_tx_mpdu(struct iwl_mvm *mvm, struct sk_buff *skb,
if (WARN_ONCE(txq_id == IWL_MVM_INVALID_QUEUE, "Invalid TXQ id")) {
#if defined(__FreeBSD__)
- IWL_DEBUG_TX(mvm, "fc %#06x tid %u txq_id %u mvm %p "
- "skb %p { len %u } info %p sta %p\n", fc,
- tid, txq_id, mvm, skb, skb->len, info, sta);
+ printf("%s:%d: fc %#06x tid %u txq_id %u mvm %p "
+ "skb %p { len %u } info %p sta %p (if you see this please "
+ "report to PR 274382)\n", __func__, __LINE__,
+ fc, tid, txq_id, mvm, skb, skb->len, info, sta);
#endif
iwl_trans_free_tx_cmd(mvm->trans, dev_cmd);
spin_unlock(&mvmsta->lock);