git: 9d882de2da20 - main - Remove sysctl 'kern.smp.forward_signal_enabled'
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 21 Nov 2023 18:35:49 UTC
The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=9d882de2da2099f534776ba4a6278e8c0bc87660 commit 9d882de2da2099f534776ba4a6278e8c0bc87660 Author: Olivier Certner <olce.freebsd@certner.fr> AuthorDate: 2023-10-20 13:43:29 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2023-11-21 18:25:34 +0000 Remove sysctl 'kern.smp.forward_signal_enabled' It seems this was an "emergency" knob to revert a newly introduced behavior. Overall, we want better system-wide signal receive latency, and it doesn't seem that some contrary policy was ever needed (and if that comes up, it should rather be implemented, e.g., per-process). Suggested by: kib Reviewed by: kib, jhb Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D42315 --- sys/kern/subr_smp.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/sys/kern/subr_smp.c b/sys/kern/subr_smp.c index 7cbf83928786..399665b47751 100644 --- a/sys/kern/subr_smp.c +++ b/sys/kern/subr_smp.c @@ -113,12 +113,6 @@ SYSCTL_INT(_kern_smp, OID_AUTO, topology, CTLFLAG_RDTUN, &smp_topology, 0, "Topology override setting; 0 is default provided by hardware."); #ifdef SMP -/* Enable forwarding of a signal to a process running on a different CPU */ -static int forward_signal_enabled = 1; -SYSCTL_INT(_kern_smp, OID_AUTO, forward_signal_enabled, CTLFLAG_RW, - &forward_signal_enabled, 0, - "Forwarding of a signal to a process on a different CPU"); - /* Variables needed for SMP rendezvous. */ static volatile int smp_rv_ncpus; static void (*volatile smp_rv_setup_func)(void *arg); @@ -205,8 +199,6 @@ forward_signal(struct thread *td) if (!smp_started || cold || KERNEL_PANICKED()) return; - if (!forward_signal_enabled) - return; /* No need to IPI ourself. */ if (td == curthread)