Re: git: 0527c9bdc718 - main - ino64: Remove 'forward compat' code for this

In message <202310312127.39VLReES081354@gitrepo.freebsd.org>, Warner Losh 
write
s:
> The branch main has been updated by imp:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=0527c9bdc7187a0b92511f021dcdbbac
> 84f1c579
>
> commit 0527c9bdc7187a0b92511f021dcdbbac84f1c579
> Author:     Warner Losh <imp@FreeBSD.org>
> AuthorDate: 2023-10-31 20:55:58 +0000
> Commit:     Warner Losh <imp@FreeBSD.org>
> CommitDate: 2023-10-31 21:26:44 +0000
>
>     ino64: Remove 'forward compat' code for this
>     
>     Forward compatibility code was added for running newer ino64 binaries on
>     older kernels as a transition aide. Now that ino64 has been in the tree
>     6 years, this code is no longer useful and should have been removed long
>     ago.  Remove it now. Should be no user-visible changes at this point as
>     all the 'upgrade' scenarios it was intended for are long since past.
>     
>     Also need to remove this stuff from rtld since the _foo versions
>     no longer exist.
>     
>     Sponsored by:           Netflix
>     Reviewed by:            kib
>     Differential Revision:  https://reviews.freebsd.org/D42382
> ---
>  UPDATING                                |  12 ++++
>  lib/libc/sys/Makefile.inc               |   8 ---
>  lib/libc/sys/compat-ino64.h             |  99 ---------------------------
>  lib/libc/sys/fstat.c                    |  51 --------------
>  lib/libc/sys/fstatat.c                  |  47 -------------
>  lib/libc/sys/fstatfs.c                  |  51 --------------
>  lib/libc/sys/getdents.c                 |   7 +-
>  lib/libc/sys/getdirentries.c            | 114 ------------------------------
> --
>  lib/libc/sys/getfsstat.c                |  62 -----------------
>  lib/libc/sys/lstat.c                    |  13 +---
>  lib/libc/sys/stat.c                     |  13 +---
>  lib/libc/sys/statfs.c                   |  47 -------------
>  libexec/rtld-elf/rtld-libc/Makefile.inc |   4 +-
>  13 files changed, 21 insertions(+), 507 deletions(-)
>
> diff --git a/UPDATING b/UPDATING
> index 722d7d66acbe..1ee0731742b3 100644
> --- a/UPDATING
> +++ b/UPDATING
> @@ -27,6 +27,10 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 15.x IS SLOW:
>  	world, or to merely disable the most expensive debugging functionality
>  	at runtime, run "ln -s 'abort:false,junk:false' /etc/malloc.conf".)
>  
> +20231027:
> +	Forward compatibility (running the new code on old kernels) for the
> +	"ino64" project have been removed. The need for it has passed long ago.
> +
>  20231018:
>  	Commit 57ce37f9dcd0 changed the internal KAPI between the
>  	nfscommon and nfscl modules.  Both must be rebuilt from sources.
> @@ -1573,6 +1577,14 @@ https://lists.freebsd.org/archives/freebsd-current/202
> 1-June/000153.html
>  	Switch back to the BSDL dtc (Device Tree Compiler). Set WITH_GPL_DTC
>  	if you require the GPL compiler.
>  
> +20170619:
> +	Forward compatibility for the "ino64" project have been committed. This
> +	will allow most new binaries to run on older kernels in a limited
> +	fashion.  This prevents many of the common foot-shooting actions in the
> +	upgrade as well as the limited ability to roll back the kernel across
> +	the ino64 upgrade. Complicated use cases may not work properly, though
> +	enough simpler ones work to allow recovery in most situations.
> +
>  20170618:
>  	The internal ABI used for communication between the NFS kernel modules
>  	was changed by r320085, so __FreeBSD_version was bumped to

Given the notes above, should we also have a __FreeBSD_version bump?


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

			e^(i*pi)+1=0