From nobody Wed May 31 15:54:36 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QWYjm72kRz4YthM; Wed, 31 May 2023 15:54:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QWYjm6Zy9z4RQ3; Wed, 31 May 2023 15:54:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685548476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9y9jvF6GKFNIo4rNLfx/aHSEx9Qm5taywsboHHwOnQM=; b=ojzKLaYhaZXi8BXKCvBpjAPzJM+TLsiAUW9yBpIdvMVX2+OvHdyiEBrHHx+bi3Pk34+LZA fuBn55HfcJCc9C4F1xZEtfAFwVhtaqy4UHl66yBtQyFKH3v7WEnoT6S0rRIwIC4majJ5aY Qv/z3G9PrqhcQGqvrZh4rugWjW0XC1O0Sqr7wLK5w5x/FSCX7bERZZqEBW1+PyHbT2lAY6 bls6rDSvdPDJuzeJz8aWszk0n6XHg4IQ0bfGSPTX7HLOKqiN1DDAeum0l49KXWGt8VJeH3 DcsvMKEHYCTJxNBvZuSFoClBchj045IyQ4pbwzNM9x+h50ZLgpAEdNUKTGs/gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685548476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9y9jvF6GKFNIo4rNLfx/aHSEx9Qm5taywsboHHwOnQM=; b=kVdEZwwSH0fukNWgiFdhffREfcTJ+g1r+/Az8nf6H3F0pj6STJes8beh0iJpxgunqD2dqA Wrq/f2MnWJuvoPyxRrJrK6gimcozFA1q3RnEes6ml5HTi4eK4zTf0EIgRNzhzWzHvTXW08 nBiJLTvoxIjvy6KsdqkkM9qdSh3HuWIDKReRFBzFHa7KKJpiN2Ock8aHTNog6sKDuN2IN4 Q7ZdujTcZp8KODjcyQQRSsuBr2ddNCYvS01ljo/k+Tsm30v5Qe+4T3UbwxhnLPWa3SYN5d 7PQsAJXII2WfbHXhEZfuUja3IjxIS00xklL8KP9wwZbcJTmXDfQ6zQiZMs+7Uw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685548476; a=rsa-sha256; cv=none; b=d4whp692wqDcgshtXtz8pWG6B654MsZeHQRkvCBNzH64MSYYmsY4mFP1vlaUp1KoqxpbIj Quth2sWI+KzM/IS8ATTzmtudcJvIX6Yy35DYfhRFoOLBuBAd1cVWEWyws42DzB1V4Kpmlk F8kUI9vhYKKsbPxlOlCD51K1ERmcHstbnQXIJTmpMs+Z9z6mwSZHDwOQHad9JPl6AMLzAH 2nAY5kOeIscDZZsE0i/Hc9nNnN/lrGsiQPxz87wHXpPfehPuAi15fCuUgvUHTSKDTsq5UF Q1Y6MXWjkbcY/KZu6OsjrI1hZoZBBv9eTUG8dlPS/FCx/BGMjYpS4rbBnqMzMw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QWYjm5f1Tzh4W; Wed, 31 May 2023 15:54:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 34VFsaX4074686; Wed, 31 May 2023 15:54:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 34VFsaMp074685; Wed, 31 May 2023 15:54:36 GMT (envelope-from git) Date: Wed, 31 May 2023 15:54:36 GMT Message-Id: <202305311554.34VFsaMp074685@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 0ec220df526d - main - tap(4): allow full-duplex and non-zero speed List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0ec220df526d38c73650301c1300a6fe3124698a Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=0ec220df526d38c73650301c1300a6fe3124698a commit 0ec220df526d38c73650301c1300a6fe3124698a Author: Alexandre Snarskii AuthorDate: 2023-05-31 15:50:00 +0000 Commit: Warner Losh CommitDate: 2023-05-31 15:53:48 +0000 tap(4): allow full-duplex and non-zero speed tap(4) devices advertise themselves as just 'ethernet autoselect', without duplex or speed capabilities. This advertisement makes them unable to be aggregated into lacp-based lagg(4): - lacp code requires underlying interfaces to be full-duplex, else interface will not participate in lacp at all - lacp code requires underlying interface to have non-zero speed, else this interface can not be selected as active aggregator PR: 217374 Reported-by: Alexandre Snarskii Co-authored-by: Mina Galić Reviewed-by: imp,karles Pull-request: https://github.com/freebsd/freebsd-src/pull/745 --- sys/net/if_tuntap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/net/if_tuntap.c b/sys/net/if_tuntap.c index 86921675c58f..28d5e97935cb 100644 --- a/sys/net/if_tuntap.c +++ b/sys/net/if_tuntap.c @@ -1341,7 +1341,7 @@ tunifioctl(struct ifnet *ifp, u_long cmd, caddr_t data) dummy = ifmr->ifm_count; ifmr->ifm_count = 1; ifmr->ifm_status = IFM_AVALID; - ifmr->ifm_active = IFM_ETHER; + ifmr->ifm_active = IFM_ETHER | IFM_FDX | IFM_1000_T; if (tp->tun_flags & TUN_OPEN) ifmr->ifm_status |= IFM_ACTIVE; ifmr->ifm_current = ifmr->ifm_active;