From nobody Tue May 30 18:11:20 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QW0p94Tczz4Xvhs; Tue, 30 May 2023 18:11:29 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Received: from heemeyer.club (heemeyer.club [195.93.173.158]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4QW0p90vmNz3rZ3; Tue, 30 May 2023 18:11:28 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Authentication-Results: mx1.freebsd.org; none Received: from heemeyer.club (localhost [127.0.0.1]) by heemeyer.club (8.17.1/8.16.1) with ESMTP id 34UIBKpS000878; Tue, 30 May 2023 21:11:20 +0300 (MSK) (envelope-from dchagin@heemeyer.club) Received: (from dchagin@localhost) by heemeyer.club (8.17.1/8.16.1/Submit) id 34UIBK9a000877; Tue, 30 May 2023 21:11:20 +0300 (MSK) (envelope-from dchagin) Date: Tue, 30 May 2023 21:11:20 +0300 From: Dmitry Chagin To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4f2c2a122c6f - main - avx_sig: Adapt avx_sig test for Aarch64 Message-ID: References: <202305300819.34U8JrK1039933@gitrepo.freebsd.org> <0764bffa-f3e4-3619-fb57-856db2fcb4cd@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0764bffa-f3e4-3619-fb57-856db2fcb4cd@FreeBSD.org> X-Rspamd-Queue-Id: 4QW0p90vmNz3rZ3 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:61400, ipnet:195.93.173.0/24, country:RU] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Tue, May 30, 2023 at 10:20:33AM -0700, John Baldwin wrote: > On 5/30/23 1:19 AM, Dmitry Chagin wrote: > > The branch main has been updated by dchagin: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=4f2c2a122c6fc1e129f93767234ae8107fcf5d0d > > > > commit 4f2c2a122c6fc1e129f93767234ae8107fcf5d0d > > Author: Dmitry Chagin > > AuthorDate: 2023-05-30 08:19:40 +0000 > > Commit: Dmitry Chagin > > CommitDate: 2023-05-30 08:19:40 +0000 > > > > avx_sig: Adapt avx_sig test for Aarch64 > > Reviewed by: kib > > Differential Revision: https://reviews.freebsd.org/D40309 > > The comment at the top of avx_sig.c still references AVX and %xmm FWIW and > needs updating. (The fact that it is also only testing xmm makes it an SSE > test on x86 and not an AVX test anyway) > > Can we also rename this tool now as avx_sig isn't a very intuitive name for > an aarch64 test? Maybe call it simd_sig given your earlier changes? > yes, it's not finished, I want to add avx and then rename/correct everything > I'm also not quite sure what the 'c2x2c' part of the filename means for the > MD files? The functions it defines are 'cpu_to_simd' and 'simd_to_cpu', so > maybe just 'simd_.S' makes more sense? (And you could also perhaps > use MACHINE_CPUARCH in SRCS to require fewer .if's in the Makefile) > indeed, thanks > -- > John Baldwin