Re: git: 01aee8c92d93 - main - libfetch: do not call deprecated OpenSSL functions

On Thu, 25 May 2023 at 12:49, John Baldwin <jhb@freebsd.org> wrote:
>
> > +#if OPENSSL_VERSION_NUMBER < 0x10100000L
> >       /* Init the SSL library and context */
> >       if (!SSL_library_init()){
> >               fprintf(stderr, "SSL library init failed\n");
> > @@ -1211,6 +1212,7 @@ fetch_ssl(conn_t *conn, const struct url *URL, int verbose)
> >       }
> >
> >       SSL_load_error_strings();
> > +#endif
>
> Should we just remove this code outright?  I don't think there's any value in
> supporting pre-1.1 OpenSSL versions?

Indeed that should be our end goal, but my initial desire is for
minimal changes. I also think there's some value in having these
functions as placeholders for now, in case anything with OpenSSL's
automatic init doesn't work as expected.