From nobody Thu May 25 13:42:22 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QRq3y6wKkz4V1VW; Thu, 25 May 2023 13:42:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QRq3y6MFrz4Cx0; Thu, 25 May 2023 13:42:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685022142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rywri9aHyR2Oqrr+SC3hAHg3PCshnL926i81z4XnZnk=; b=F1U164q2VVDUP7YgPpmHwuaKeQ+L4dnRPFPFsKbdwM34kyvf5u9a4Isuk8pawBXeBCDGUt mLrnFEf/074SEv43JCTGhEJSD7Dnudki8rmTvcNjTYUXaHjdobMTJ5mtWpezKAJvcjU1WO /GSUxkCwCRwyOBRokPCK1ZhYl2oY72cLNAdRG4CKkqAi5cfHW9X34lvsXm3CjJBt4edtRN +RnsUPsRpWxM1TfPGnDYQNGwC5Tl0WKhc7/tDYbbTxQtjPrErOrd/Tb8foSZJf2J5xpXE8 eC3l65hGe9AbAkRlp4Y+PbbRYVLP39Iz6Luh20NhFnrxSGEYz8oUmBIIHAdWkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685022142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rywri9aHyR2Oqrr+SC3hAHg3PCshnL926i81z4XnZnk=; b=XYeLOaBBk9EaVpOH501QW3KBEbw1XpeAJ7pUE3YrIj7o/lN7PHpfrU3xThXo9ot9qP0mWI vqgY032RN2M4ytvyxa9jkLLx56KyLAwH0YU6TXfI+PXZxeJSigproK6YLwrH0/lMjlO52i eX9pIVcXUvWlJU9T+8dS8uvoFs88nW3yr7srFPkhNzcH/V9ZtEk02HwdGGQuih3Blb6zwS JEXu3jT8rFwkwd+GSurg1ta4RgTHaSjquT1IRyjPrHC0fJ8aJCHs8WM4eLhqej552Q4Jy4 nTwfz6PoHsb82rWkDyhqWW8ZXBVzmPOWVS3GqWuiXzA//kmrgBCmgtIjAHiYGQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685022142; a=rsa-sha256; cv=none; b=es1X7cpLRxAW/j9k7eq6kWmT2A9TrGqon42ndb/to1QhPOIuIYYO0UWs/EMG86PcfQFCLB 2U6sysaHSUZhjkOO+8zt90XVQXbAYnX50psheuS9cFSKMNoNYAAji7NCJjztlH1pGEOKzl X+Z5t/eKKE6t+JqLu4w3kH5OnHJgLLcUs+UpVlzcKZYeE3oTqqjmDLnHTvMr+jLGgjpID8 2araSKvetay8sSjiRM/MU12EMAtOOjFL/tqqg8Q/l/8+s4nj8h2wz4ZoJ4CR6BavHZm5fY epuU9v3IBERMkNcolVPswccAzHG77ZW8DdI9Xkko7bynzkOAOn/Hn6WQdQ+Q+Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QRq3y5Q6XzRL9; Thu, 25 May 2023 13:42:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 34PDgMEA096212; Thu, 25 May 2023 13:42:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 34PDgMgT096211; Thu, 25 May 2023 13:42:22 GMT (envelope-from git) Date: Thu, 25 May 2023 13:42:22 GMT Message-Id: <202305251342.34PDgMgT096211@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: fd96685a4a57 - main - Revert "When stopping powerd, set the CPU frequency back to its maximum value" List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fd96685a4a579fc84031e8e66d8f8b1ce8cdf1e5 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=fd96685a4a579fc84031e8e66d8f8b1ce8cdf1e5 commit fd96685a4a579fc84031e8e66d8f8b1ce8cdf1e5 Author: Andrew Gallatin AuthorDate: 2023-05-22 00:47:28 +0000 Commit: Andrew Gallatin CommitDate: 2023-05-25 13:40:26 +0000 Revert "When stopping powerd, set the CPU frequency back to its maximum value" This reverts commit 1dcb6ad173e57b489a859ea59ed6eaa733bdb5bc. As of "8cb16fdbea6b Restore original frequency on exit.", powerd restores the original frequency itself. Further, if the original frequency is not the same as the first frequency found in the frequency list, then the restoration done by the powerd_poststop will restore the wrong frequency. This can happen on Intel machines where Turbo is not enabled, but the turbo frequency is first in the list of frequencies. In this case, turbo will be enabled when the user did not want it to be. Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D40197 Reviewed by: imp, mav --- libexec/rc/rc.d/powerd | 7 ------- 1 file changed, 7 deletions(-) diff --git a/libexec/rc/rc.d/powerd b/libexec/rc/rc.d/powerd index 2fc783a627e9..6f63bb96ff42 100755 --- a/libexec/rc/rc.d/powerd +++ b/libexec/rc/rc.d/powerd @@ -14,13 +14,6 @@ name="powerd" desc="Modify the power profile based on AC line state" rcvar="powerd_enable" command="/usr/sbin/${name}" -stop_postcmd=powerd_poststop - -powerd_poststop() -{ - sysctl dev.cpu.0.freq=`sysctl -n dev.cpu.0.freq_levels | - sed -e 's:/.*::'` > /dev/null -} load_rc_config $name run_rc_command "$1"