From nobody Wed May 24 23:36:40 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QRSJ82TWCz4V89f; Wed, 24 May 2023 23:36:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QRSJ81vfvz3Qy6; Wed, 24 May 2023 23:36:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684971400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=q35WGXk+HXZ7B44M/TiUw6dR7WtU5yj1A2d73OVo8Yo=; b=GELJqT+jh+nTQHqD5R2vMXrt5Y6LHBMjeXa+ALB8JxDCc5UuU+FpZ68uEkiTz7dDBGbDXE XF7MkvBGEf1E4dT7iw727D6Tb3UilYXlBTlGGeExh5Y7Ou3Pj6q200HF9xMx+cp03ULHt7 khp+ylqeXb1RvIQFvw3yG5TuKbU6BIJIxJIDf/WuyZcrAtPEzX0LRv8loqY/eY6JfLupXv WrnsVhcEe2zSzipPf5KXySglNYRFMxapjB+UbtgsZFhlP0dpqPIIxRIMK0r3v121sSDR+D SJIYD0CAbHDYIZ+e9H6c2g4xeYav9hXqVcB2FxoCfLDZGCFJkz8ndX2S7sxrzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684971400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=q35WGXk+HXZ7B44M/TiUw6dR7WtU5yj1A2d73OVo8Yo=; b=s8boL9DyYyyKxFlzi3JwvNZSsPNlS+SaUJNi2SbONHy3I0bjTM41G8W9pYb0twkXk6flXN YfrkZ1Y675cn5VpI/mQ2YfeITA2Z9QDEKTBjAYYMpDRFWqhZa7as5Io4AinPtNO4p4gfUJ MnLynKX+FLiZxJdSypgKtMjoBZaX3xh8U69CR+WotkYjMW5AbNDOxl6a7RZEIchDekETiu W77Ec0zS8SmVYv9gkrSVZ/Yojv+gqIM906tHdx4nTzhX99cUbgxHClxouF6zslanvQZg3n 3crsuxZMVwQAKZjn2FMMRmBLTodZ8IXLnTFwYTddzobq1u6ErMK2Lv9Rgdi0yA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684971400; a=rsa-sha256; cv=none; b=mIC1SwUK6N8wenD5wBJ7DgsNONm2HgppJpQaV3bRRY8IYlYP4edwqyvuyygQtP49YTNl0s b8fuPXaICnzpPPVVJY3As9phLHwlFlV5pTAz9nEcg+TxN8aYwLCBltfORQsz7sgnOPBlGi F59EWPOBNjZnxjfDp7aG7szbjP9xkNYyab+Z2/3lmWI5BSxCb5tl6JAGVUucFBR8YVh7xi sktjK/dVfEGhUjXpP7ktOwDhA/mhMPtw2M973ofpjT4FsGgwXwbx0O6YC5yTtpySANBW8u u+j3PNPexJuoGtQHqQQznfN2HXCPYKkfzj/jXMdilC3rErWhd9+FHisCSz8DFA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QRSJ80z2jz12Nk; Wed, 24 May 2023 23:36:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 34ONaeS2094637; Wed, 24 May 2023 23:36:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 34ONaeUF094636; Wed, 24 May 2023 23:36:40 GMT (envelope-from git) Date: Wed, 24 May 2023 23:36:40 GMT Message-Id: <202305242336.34ONaeUF094636@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Eric Joyner Subject: git: 156424fce98a - main - ixgbe: Change if condition for RSS and rxcsum List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: erj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 156424fce98a0240c702da0a918b027d1979bfdb Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by erj: URL: https://cgit.FreeBSD.org/src/commit/?id=156424fce98a0240c702da0a918b027d1979bfdb commit 156424fce98a0240c702da0a918b027d1979bfdb Author: Przemyslaw Lewandowski AuthorDate: 2023-05-24 23:24:54 +0000 Commit: Eric Joyner CommitDate: 2023-05-24 23:29:40 +0000 ixgbe: Change if condition for RSS and rxcsum This patch fixes TCP connection hangs for 1 rxq and 1 txq without rxcsum enabled. Documentation for 10G cards and other drivers suggest enabling rxcsum for RSS and disabling otherwise. When PCSD bit is not set then fragment checksum and IP identification are reported in the rx descriptor. When PCSD bit is set then RSS hash value is reported in the rx descriptor. RSS and RX IPP checksum are mutually exclusive. Signed-off-by: Eric Joyner PR: 268910 Reviewed by: erj@ Tested by: jeffrey.e.pieper@intel.com MFC after: 1 week Sponsored by: Intel Corporation Differential Revision: https://reviews.freebsd.org/D38621 --- sys/dev/ixgbe/if_ix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 8df0e59a8346..0179c6456de8 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -754,7 +754,7 @@ ixgbe_initialize_receive_units(if_ctx_t ctx) ixgbe_initialize_rss_mapping(sc); - if (sc->num_rx_queues > 1) { + if (sc->feat_en & IXGBE_FEATURE_RSS) { /* RSS and RX IPP Checksum are mutually exclusive */ rxcsum |= IXGBE_RXCSUM_PCSD; }