From nobody Wed May 24 16:20:21 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QRGcj3P5rz4TFG8; Wed, 24 May 2023 16:20:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QRGcj2hPcz444p; Wed, 24 May 2023 16:20:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684945221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ljB46mUc+21cK1h6lnOCZzUoeJwTNzINVtWVyjZ8AAU=; b=VzmgbJmuhy8/VDkdX1H+3ZUtL/YGlxprjpcpZzGhs7+FgoPDchrghMLXQ5AMGkquTWIpdU G4yy/Ljxj6SJqE6S+FHfFVnMhPbAb1LKdSaOzeQPeZ1XSgwvGQB7ty/bsTP3yVDoraguBF nuRClQYgo/cKsLhfXWGg/6OHqsHS0U/5bZP1ZqZX1YNr01FjDq6Qe9hzr5ksdGw73VH4XV 2pcmZK+bd26m7nsgMQuDMZHuTgGk/KvYuOAj+smIMMfa5+akKQ4cV9yZPMBqKTPRujS+t/ eyoEpOvAIsaBqbPlCsmY9FXVgiHYD/Goej83GTyFTWN9mi2/XddVhQL76O013g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684945221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ljB46mUc+21cK1h6lnOCZzUoeJwTNzINVtWVyjZ8AAU=; b=NRhgDtgwh31xFvV5lusTCv2R4vgiZnyaKFfU+XE3ZEnO44qJB6Dq7nwyWIktpOhBgOxNdf fV5/D6E4MX9Bo/B0Hsrq1sx4/LIRd2FwyZPtj8PnEpBMn3nivQO0JR0SmPfcWJaB0M+2De 6xpg3uaj2vHpr9iLlEQPYMzW8F3x3W6hHhJCVfbml55PJouMo1j4+LFZol+tviKNRI6kcs 6SOp7rR6ErAUbgg+l+aplGEJw0wVTzl6DlWTMa6NqwmN+Tu+qCKRCASsXSRA8VWOJ7RDOC KILdOruQlt2uuG6x3Ex59Qs5E9z+LUJEOL3PdLqALI2N+rpzFP9USsz+7M10Cw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684945221; a=rsa-sha256; cv=none; b=D7tXPEHiYi6LjzmYZ9T31+sTdpawwsF/wlc+iUIxhIbz+op57eJ8je/EdkUWMmRwyvIuHE M7jNAMEfRjq4a5GIASwbdZMhhE83+kd8i6qFA672RUMZzSxwYSueoM+P64onbB05y5wBX8 /f6qz5CBaIBjfSmhqqf5DU5KHMN4s6jCEExJniS0Ps+y5YfDfFKGAePUNSx8A+pM8ujd0t RnMFKIIxXED5hXbhiTctjgtJvf8sGAx5EbUjbjb0mVry3zTW/LEGJK4hPC/rptUbp3Mult aVdGG/7QNo1lTW9Is8JEsel3mTg3xa7ykTqehGCPG4wdjdXFCYimPQUU7rLZBA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QRGcj1nxTzpfc; Wed, 24 May 2023 16:20:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 34OGKLKX078857; Wed, 24 May 2023 16:20:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 34OGKLH9078856; Wed, 24 May 2023 16:20:21 GMT (envelope-from git) Date: Wed, 24 May 2023 16:20:21 GMT Message-Id: <202305241620.34OGKLH9078856@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Turner Subject: git: fa512fcd8fe7 - main - arm64: Print the spinlock count on panic List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fa512fcd8fe74d72b7f29a324c8cd3ca20ff25c8 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=fa512fcd8fe74d72b7f29a324c8cd3ca20ff25c8 commit fa512fcd8fe74d72b7f29a324c8cd3ca20ff25c8 Author: Andrew Turner AuthorDate: 2023-05-24 14:40:30 +0000 Commit: Andrew Turner CommitDate: 2023-05-24 16:20:06 +0000 arm64: Print the spinlock count on panic When the spinlock count is non-zero while taking a data abort we panic. Print this count to help debugging. Sponsored by: Arm Ltd --- sys/arm64/arm64/trap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/arm64/arm64/trap.c b/sys/arm64/arm64/trap.c index 17bda56d806e..9b1b73aeb55d 100644 --- a/sys/arm64/arm64/trap.c +++ b/sys/arm64/arm64/trap.c @@ -329,7 +329,8 @@ data_abort(struct thread *td, struct trapframe *frame, uint64_t esr, print_registers(frame); print_gp_register("far", far); printf(" esr: %.16lx\n", esr); - panic("data abort with spinlock held"); + panic("data abort with spinlock held (spinlock count %d != 0)", + td->td_md.md_spinlock_count); } #endif if (td->td_critnest != 0 || WITNESS_CHECK(WARN_SLEEPOK |