From nobody Wed May 24 08:13:57 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QR3qW3Xrkz4CPMr; Wed, 24 May 2023 08:13:59 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QR3qW2Jpsz41X1; Wed, 24 May 2023 08:13:59 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684916039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xcrtw402S8TlbFaVPVw9XqzcOIrdahH99bPGIpsF07c=; b=N4L7xejILFIrjBHPNfj+e4qD9QgUpvOqwDxiDFda0krnCBEJ8/So+z3NPo/z0+NkEgXjE9 aMTAfjgjc0shk0rnNjKr6pR4Jv/sG7+9eIl3CWKVIOepTTLWp5WaGwkU2mzg05eSipfBbt KVg5S9bpVvWX34EYMGG/JlDRXB/GEIS7kxDOsjGUAuRdqGBMf16k6os0qC4MMm86bzcFXP LFTLG/56EUkWVMFCmWZswGdfJ5YQtG3PnU6Z6Vh8hUWppoS5NWSXs0dMnze0sPe/KIk1A9 apRZS5o8owZ/UMqrXFOJW7Ov505o1A4x+0LqqaMnfAghZwlwe5rkQhccbBA8JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684916039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xcrtw402S8TlbFaVPVw9XqzcOIrdahH99bPGIpsF07c=; b=EsaS1adnKTJJ4xr2jG7RwIeDwiMxJnRmM6pXMysRXOcw1B05yITh/xh9Y6qqsjvagHo8aV SWExGpoV/VKyhljpd0ZmWjiU9pKKDod4jcqCTHrX85nU7d17y20v09i/HlDyy/aNNgVwCf o+1zvDEBwVlzA8xZtP2ZJcQwqPUja88cyy3Im7rv0wBx4VmcgijtBGVrIyMiIFikGWNWG0 fwxHmdLz3vsKMlF+JoTWiJwV+RK2UuRHTekC/LtaaFAy3iWzlrKcwHBQSxA16wdMZSoflZ EV9iPtainSip3cI+b6zLPJVeK5dUu1uFd75YUvbOWa+CE318yAPGKwWWFCI1hA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684916039; a=rsa-sha256; cv=none; b=sELHGdM6K/4xNHFVz/kkVCUyfb9HKCRnStsN33wWwZjDy6HULqj6YPTOtLcWx3369cx0LW sZSFv4c8baLZwq3qX0n7San8SR14jcY7kEjuxWXAMbT5b6TZ47Tgy9pPGD8NS6H7Bp6c0L 5RNdaUJJVn1Jsmc8Mpft8r/IaoW1PJ1f/lEPg5VZr72WlxT6EFzb2yGWZDCsPSJ2TAeZpW 733zW0YkvvGs8eI+hPp/hI8+GpETxlJ5PI39BFXIf4ZFyp/l3c7p/aEVkoN6hhpqZyiZH8 a6Y0ZR3M1hSQYQFZ3tcdySjnO+OxVVHdLk+5FhHh19MuYq2+RTSJo06BypssWg== Received: from [IPV6:2a01:e11:2002:4280::13:1] (unknown [IPv6:2a01:e11:2002:4280::13:1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QR3qV40PtzwvS; Wed, 24 May 2023 08:13:58 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: Date: Wed, 24 May 2023 10:13:57 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: git: e17eca327633 - main - vmm: Avoid embedding cpuset_t ioctl ABIs To: Mark Johnston , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202305240117.34O1Hqbf086999@gitrepo.freebsd.org> Content-Language: en-US From: Guido Falsi In-Reply-To: <202305240117.34O1Hqbf086999@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 24/05/23 03:17, Mark Johnston wrote: > The branch main has been updated by markj: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e17eca327633efc511450310afb5e4a662724e3d > > commit e17eca327633efc511450310afb5e4a662724e3d > Author: Mark Johnston > AuthorDate: 2023-05-24 01:13:33 +0000 > Commit: Mark Johnston > CommitDate: 2023-05-24 01:15:59 +0000 > > vmm: Avoid embedding cpuset_t ioctl ABIs > > Commit 0bda8d3e9f7a ("vmm: permit some IPIs to be handled by userspace") > embedded cpuset_t into the vmm(4) ioctl ABI. This was a mistake since > we otherwise have some leeway to change the cpuset_t for the whole > system, but we want to keep the vmm ioctl ABI stable. > > Rework IPI reporting to avoid this problem. Along the way, make VM_RUN > a bit more efficient: > - Split vmexit metadata out of the main VM_RUN structure. This data is > only written by the kernel. > - Have userspace pass a cpuset_t pointer and cpusetsize in the VM_RUN > structure, as is done for cpuset syscalls. > - Have the destination CPU mask for VM_EXITCODE_IPIs live outside the > vmexit info structure, and make VM_RUN copy it out separately. Zero > out any extra bytes in the CPU mask, like cpuset syscalls do. > - Modify the vmexit handler prototype to take a full VM_RUN structure. > > PR: 271330 > Reviewed by: corvink, jhb (previous versions) > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D40113 Looks like this is breaking world build: /poudriere/jails/14amd64/usr/src/usr.sbin/bhyvectl/bhyvectl.c:2389:24: error: incompatible pointer types passing 'struct vm_exit *' to paramet er of type 'struct vm_run *' [-Werror,-Wincompatible-pointer-types] error = vm_run(vcpu, &vmexit); ^~~~~~~ /usr/obj/poudriere/jails/14amd64/usr/src/amd64.amd64/tmp/usr/include/vmmapi.h:158:46: note: passing argument to parameter 'vmrun' here int vm_run(struct vcpu *vcpu, struct vm_run *vmrun); ^ 1 error generated. *** [bhyvectl.o] Error code 1 make[4]: stopped in /poudriere/jails/14amd64/usr/src/usr.sbin/bhyvectl Looks like required adaptations to bhyvectl.c where left out. -- Guido Falsi