From nobody Tue May 23 10:23:35 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QQVln5CBjz4CJQK for ; Tue, 23 May 2023 10:23:49 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-vs1-xe36.google.com (mail-vs1-xe36.google.com [IPv6:2607:f8b0:4864:20::e36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QQVlm2Kk8z3Gqj for ; Tue, 23 May 2023 10:23:48 +0000 (UTC) (envelope-from rrs@netflix.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=netflix.com header.s=google header.b=NbKUXVLo; spf=pass (mx1.freebsd.org: domain of rrs@netflix.com designates 2607:f8b0:4864:20::e36 as permitted sender) smtp.mailfrom=rrs@netflix.com; dmarc=pass (policy=reject) header.from=netflix.com Received: by mail-vs1-xe36.google.com with SMTP id ada2fe7eead31-43278f6d551so2264084137.1 for ; Tue, 23 May 2023 03:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; t=1684837426; x=1687429426; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VKd4mbZB95JVeKTC9AZrPuRykvAxT+a5FGJ77eUJ0QY=; b=NbKUXVLoJHPj4dxpInpKvPSGCXQWsD2iIawVM2CaxZ4LlWlvpD4wc0HQtZsY6SESPW y7P/mCwUXLlSim5Grb0nANc29uFc4mTDKKBguCxvM0VaLf5fhMd8al+pPMV20CLXHP7e 7YpJ0WyT2qX4Nj6Xgbi2MQ/y+pZ8X49kmPVmU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684837426; x=1687429426; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VKd4mbZB95JVeKTC9AZrPuRykvAxT+a5FGJ77eUJ0QY=; b=AbM+h7LFsaG09Gry3X40/OP/Gha7cV2UMd5ye07Bkfb/RB0GuW2qvlvmIjLx3wzPsb lilhpIkKtBJsyhcBrvExQllE1BfnflUDv61BAVYj8nbzCxvHkSbxBfTxlNC9fUFOyR75 AXMo4gIQDBJ81sIMEeC0iqBZbdyz50kaLq02cC9tBJ20qgT1P6OHXEF7VY1Y/7hQM8tN y6vS+ZC53ElwdPa1f1RXnQJJPOPxPExVlekElJaFaXPipXu4/synyvlir2tSpcFNMtUV G2p9GuJ+uBy17e58zTNg0nXu+Pas2XA4RzXM3Ct8iWRz5tPAvqHQCkndpfLx4dqTY/fy 924g== X-Gm-Message-State: AC+VfDwPl6avPecUfWjVAh+ud6zTc9bgmCi/LKmib9Fc+A8Dbm6QDpWv 3vyAorVrp01r5ny5cesLuzUMIKcF1eH/rQUhsZZaKA== X-Google-Smtp-Source: ACHHUZ5o7qh8aDVPy2KBXw4cN7BYLih8fBxnsJnYlkL8utLpKPHXNO3PmEsBsXnPHWCKDogtjdqMFH3DRLKLBJqKpo0= X-Received: by 2002:a67:d00b:0:b0:437:cd45:ba5f with SMTP id r11-20020a67d00b000000b00437cd45ba5fmr3730916vsi.24.1684837426055; Tue, 23 May 2023 03:23:46 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202304041231.334CVktq013660@gitrepo.freebsd.org> In-Reply-To: From: Randall Stewart Date: Tue, 23 May 2023 06:23:35 -0400 Message-ID: Subject: Re: git: 73ee5756dee6 - main - Fixes in the tcp infrastructure with respect to stack changes as well as other infrastructure updates for incoming rack features. To: antoine@freebsd.org Cc: Randall Stewart , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, src-committers@freebsd.org Content-Type: multipart/alternative; boundary="00000000000048f88a05fc59c8a1" X-Spamd-Result: default: False [-14.00 / 15.00]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::e36:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[rrs]; DKIM_TRACE(0.00)[netflix.com:+]; TO_DN_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; ARC_NA(0.00)[] X-Rspamd-Queue-Id: 4QQVlm2Kk8z3Gqj X-Spamd-Bar: ------------- X-ThisMailContainsUnwantedMimeParts: N --00000000000048f88a05fc59c8a1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable It is an interface so hidden it would be useless. Though Michael=E2=80=99s suggestion should work ie tcp_xxx R On Sun, May 21, 2023 at 3:01 PM Antoine Brodin wrote: > On Tue, Apr 4, 2023 at 12:31=E2=80=AFPM Randall Stewart = wrote: > > > > The branch main has been updated by rrs: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D73ee5756dee6b2110eb6fb2b2ef3cde= 39a1fcb4f > > > > commit 73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f > > Author: Randall Stewart > > AuthorDate: 2023-04-01 05:46:38 +0000 > > Commit: Randall Stewart > > CommitDate: 2023-04-01 05:46:38 +0000 > > > > Fixes in the tcp infrastructure with respect to stack changes as > well as other infrastructure updates for incoming rack features. > > > > So stack switching as always been a bit of a issue. We currently us= e > a break before make setup which means that > > if something goes wrong you have to try to get back to a stack. Thi= s > patch among a lot of other things changes that so > > that it is a make before break. We also expand some of the function > blocks in prep for new features in rack that will allow > > more controlled pacing. We also add other abilities such as the > pathway for a stack to query a previous stack to acquire from > > it critical state information so things in flight don't get dropped > or mis-handled when switching stacks. We also add the > > concept of a timer granularity. This allows an alternate stack to > change from the old ticks granularity to microseconds and > > of course this even gives us a pathway to go to nanosecond > timekeeping if we need to (something for the data center to consider > > for sure). > > > > Once all this lands I will then update rack to begin using all thes= e > new features. > > > > Reviewed by: tuexen > > Sponsored by: Netflix Inc > > Differential Revision: https://reviews.freebsd.org/D39210 > > Hi, > > Could you hide some stuff in netinet/tcp.h? > struct http_req breaks curl 8.1.0. > > Antoine > --=20 --- Randall Stewart rrs@netflix.com --00000000000048f88a05fc59c8a1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
It is an interface so hidden it would be useless. Though = Michael=E2=80=99s suggestion should work ie tcp_xxx
=
R

On Sun, May 21, 2023 at 3:01 PM Antoine B= rodin <antoine@freebsd.org>= ; wrote:
On Tue, Apr 4, 2023 at 12:= 31=E2=80=AFPM Randall Stewart <rrs@freebsd.org> wrote:
>
> The branch main has been updated by rrs:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3D73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f<= /a>
>
> commit 73ee5756dee6b2110eb6fb2b2ef3cde39a1fcb4f
> Author:=C2=A0 =C2=A0 =C2=A0Randall Stewart <rrs@FreeBSD.org>
> AuthorDate: 2023-04-01 05:46:38 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Randall Stewart <rrs@FreeBSD.org>
> CommitDate: 2023-04-01 05:46:38 +0000
>
>=C2=A0 =C2=A0 =C2=A0Fixes in the tcp infrastructure with respect to sta= ck changes as well as other infrastructure updates for incoming rack featur= es.
>
>=C2=A0 =C2=A0 =C2=A0So stack switching as always been a bit of a issue.= We currently use a break before make setup which means that
>=C2=A0 =C2=A0 =C2=A0if something goes wrong you have to try to get back= to a stack. This patch among a lot of other things changes that so
>=C2=A0 =C2=A0 =C2=A0that it is a make before break. We also expand some= of the function blocks in prep for new features in rack that will allow >=C2=A0 =C2=A0 =C2=A0more controlled pacing. We also add other abilities= such as the pathway for a stack to query a previous stack to acquire from<= br> >=C2=A0 =C2=A0 =C2=A0it critical state information so things in flight d= on't get dropped or mis-handled when switching stacks. We also add the<= br> >=C2=A0 =C2=A0 =C2=A0concept of a timer granularity. This allows an alte= rnate stack to change from the old ticks granularity to microseconds and >=C2=A0 =C2=A0 =C2=A0of course this even gives us a pathway to go to nan= osecond timekeeping if we need to (something for the data center to conside= r
>=C2=A0 =C2=A0 =C2=A0for sure).
>
>=C2=A0 =C2=A0 =C2=A0Once all this lands I will then update rack to begi= n using all these new features.
>
>=C2=A0 =C2=A0 =C2=A0Reviewed by: tuexen
>=C2=A0 =C2=A0 =C2=A0Sponsored by: Netflix Inc
>=C2=A0 =C2=A0 =C2=A0Differential Revision: https://reviews.fre= ebsd.org/D39210

Hi,

Could you hide some stuff in netinet/tcp.h?
struct http_req breaks curl 8.1.0.

Antoine
-- <= br>
---
Randall Stewart
--00000000000048f88a05fc59c8a1--