From nobody Mon May 22 10:42:39 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QPvD20bKJz4TLlh; Mon, 22 May 2023 10:42:42 +0000 (UTC) (envelope-from hselasky@freebsd.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4QPvD1707Cz4LSx; Mon, 22 May 2023 10:42:41 +0000 (UTC) (envelope-from hselasky@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from [10.36.2.145] (unknown [46.212.121.255]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id E2A7F260483; Mon, 22 May 2023 12:42:40 +0200 (CEST) Message-ID: Date: Mon, 22 May 2023 12:42:39 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body. Content-Language: en-US To: Warner Losh Cc: Jessica Clarke , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202305211621.34LGLsup059861@gitrepo.freebsd.org> <54EF67D8-2A79-4EAB-8EFB-232F14FFE792@freebsd.org> <21c9532e-4ca7-a7fe-1ff6-07a94cbad6ab@freebsd.org> <3066464F-E4C6-4B84-ADFF-E578AFAFE622@freebsd.org> <26465813-3B51-4E52-9E9D-F93A0F2AF6BD@freebsd.org> <2BF2F7CF-82E6-4D98-800D-C35D7C29E948@freebsd.org> <19a57dbf-81f0-8f57-554f-1791c5303088@freebsd.org> From: Hans Petter Selasky In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4QPvD1707Cz4LSx X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 5/22/23 01:01, Warner Losh wrote: > On Sun, May 21, 2023, 4:32 PM Hans Petter Selasky > wrote: > >> On 5/21/23 23:58, Jessica Clarke wrote: >>> What I disputed was your commit message, which at best is extremely >> misleading and at worst makes no sense, and the necessity of the change. >> >> Hi Jess, >> >> Your request for revert has been noted, but I see no urgency in such a >> revert. The code is perfectly fine either way. >> > > > Now is not the time for stubbornness. This change is easy to bring back in > if it proves to be what we want. Project custom dictates requests for back > out be given strong consideration unless there's a really compelling reason > why that's a bad idea. (And I don't see anything like that here). > > Just my suggestion... Hi Jess and Warner, Since the "stable/14" branch has not been made as it should, the 12th of May 2023, I'll revert this change, so it doesn't flow into there. Still, when commit messages are not clear, the FreeBSD way to handle that is by follow-up e-mails. Not so often I see people re-applying commits, because the commit message is wrong. As long as the code changes made er OK, the commit message is secondary. Honestly speaking, I see no code technical reason for immediate action on this issue. But I'll respect Jess's wish as a member of the FreeBSD team, even I don't agree about this decision. --HPS