Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

On Sun, May 21, 2023, 4:32 PM Hans Petter Selasky <hselasky@freebsd.org>
wrote:

> On 5/21/23 23:58, Jessica Clarke wrote:
> > What I disputed was your commit message, which at best is extremely
> misleading and at worst makes no sense, and the necessity of the change.
>
> Hi Jess,
>
> Your request for revert has been noted, but I see no urgency in such a
> revert. The code is perfectly fine either way.
>


Now is not the time for stubbornness. This change is easy to bring back in
if it proves to be what we want. Project custom dictates requests for back
out be given strong consideration unless there's a really compelling reason
why that's a bad idea. (And I don't see anything like that here).

Just my suggestion...

Also, I think time away from the keyboard would help de-escalate things.
This change isn't worth getting so worked up over.

Warner

>