From nobody Sun May 21 16:33:35 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QPR3c4Vsvz4CBX2 for ; Sun, 21 May 2023 16:33:48 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QPR3c2fzYz3gxf for ; Sun, 21 May 2023 16:33:48 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3078d1c8828so4859055f8f.3 for ; Sun, 21 May 2023 09:33:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684686826; x=1687278826; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OX4L48deeMkEquM53iR2ElYtR8+SHxiY9p3zFpviAm0=; b=dcbAYQPxpildTK822jdNKBPUSO+QAkdewcspF1qOGuq9WIzEHy0XbUelCiCT8deM1M E6CnqJ6wJzFxJ9sn+2sRvURZx7Z3fx0ZpxWV98ZRDNz3xnDpZDxsaRyhR0DwpUMJD2jU 298rQKYOOYy88Cn6oRF6MvNH/HGJ40LRPquLc8wVRonSN/Thm7vNtB+sOofC7lgUfYjZ 8s1qM+AFqVzy2LkoNGZA8lt4v1hOOBFfnrCUzm8dEpjesQxm/bN37XbadXu/0QzxMHV3 DYhs1tVoXzA9Tmka7WUa/zA8+N5lEH7vJIp27XZyFSi/1ipurwd9U0s/TxckBEvy9Lqx gxEQ== X-Gm-Message-State: AC+VfDwnHWXujjdqtQXgQI5nfn5lEyZbzr/KXXwsDvCL6PT6cMWOJs0o Om4MhmVQ3K0zpE4VIfmw6Va1WA== X-Google-Smtp-Source: ACHHUZ6HOLBq9JyCctn0p3+7Uijfq/q8U4nTRW3JPlEPYyDG0OxcapO6Q9E/f0qfXoMq/ycH38AEug== X-Received: by 2002:adf:f007:0:b0:2ef:b052:1296 with SMTP id j7-20020adff007000000b002efb0521296mr5880843wro.22.1684686826601; Sun, 21 May 2023 09:33:46 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id j17-20020a5d6191000000b0030639a86f9dsm5062037wru.51.2023.05.21.09.33.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 May 2023 09:33:46 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Subject: Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body. From: Jessica Clarke In-Reply-To: <202305211621.34LGLsup059861@gitrepo.freebsd.org> Date: Sun, 21 May 2023 17:33:35 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <54EF67D8-2A79-4EAB-8EFB-232F14FFE792@freebsd.org> References: <202305211621.34LGLsup059861@gitrepo.freebsd.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.3731.500.231) X-Rspamd-Queue-Id: 4QPR3c2fzYz3gxf X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 21 May 2023, at 17:21, Hans Petter Selasky = wrote: >=20 > The branch main has been updated by hselasky: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D805d759338a2be939fffc8bf3f25cfaa= b981a9be >=20 > commit 805d759338a2be939fffc8bf3f25cfaab981a9be > Author: Hans Petter Selasky > AuthorDate: 2023-05-21 11:25:28 +0000 > Commit: Hans Petter Selasky > CommitDate: 2023-05-21 16:20:16 +0000 >=20 > mlx4: Move DEFINE_MUTEX() outside function body. >=20 > Move static mutex declaration outside function body, to avoid = global > variables being declared on the stack, when using SYSINITs. What? This is nonsense. It=E2=80=99s not on the stack either way round. Please revert this. Jess > MFC after: 1 week > Sponsored by: NVIDIA Networking > --- > sys/dev/mlx4/mlx4_core/mlx4_main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/sys/dev/mlx4/mlx4_core/mlx4_main.c = b/sys/dev/mlx4/mlx4_core/mlx4_main.c > index ca63d1d12ba6..a37b900a2ed0 100644 > --- a/sys/dev/mlx4/mlx4_core/mlx4_main.c > +++ b/sys/dev/mlx4/mlx4_core/mlx4_main.c > @@ -1164,6 +1164,8 @@ err_sup: > return err; > } >=20 > +static DEFINE_MUTEX(set_port_type_mutex); > + > static ssize_t set_port_type(struct device *dev, > struct device_attribute *attr, > const char *buf, size_t count) > @@ -1172,7 +1174,6 @@ static ssize_t set_port_type(struct device *dev, > port_attr); > struct mlx4_dev *mdev =3D info->dev; > enum mlx4_port_type port_type; > - static DEFINE_MUTEX(set_port_type_mutex); > int err; >=20 > mutex_lock(&set_port_type_mutex);