From nobody Fri May 19 13:49:51 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QN7WM2nx3z4ByKJ; Fri, 19 May 2023 13:49:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QN7WM21Fdz3kwZ; Fri, 19 May 2023 13:49:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684504191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dRW+Gv/tiu1ox3KoDYziJ5D/T9hFyUImqUTOeQOK1XI=; b=b6RzXs8WvN3AnS/wCG07Oqv73GTJmaUySjmvz+hLggRZ2TgI1t36tMT1xyqZvulQCkJmzG pfj5fsnir1c01xg768aUNj2kuEt7m0JQiHeJTVNHe4fJtXCdSCpPrSYRuDq0IGRCMHMXKI XoTr7GgSbAkJWf+mDedtH9suWLisGybRhvWdrZDRhKRR+/3uM3BKxmG0ou4lqohVV2/A2/ GKJBmCtEfBTfLU1CbcVpB2Ss0aoiRIMNjD/DZtWLZrVMo+0fBpYrB9wHa3usEQ2Dck5dYH DGfCXva4dxOkIg7nW5eYJ8lLvt1IZCPtRNYjflISBBdu2LkKIc+ops8OtD0CCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684504191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dRW+Gv/tiu1ox3KoDYziJ5D/T9hFyUImqUTOeQOK1XI=; b=V+BkdE0f5bKaD+JbrAC/TgkyffSo1JKFk2Ke/LIxzd5/xkwZCDcjedteI5ibw49GkzNJ0v nS8fMKkwaxAsb1A9iBdhLq/T/0X/Zh1wGgfbPRyHPKYh3aMMNG/Tb4VQZTVXApSomsJVwW u4I0Z6tuA6m+aC88jYedzmcPpTSPP3Bs9BI+qfdI6YJ4tMGZ6kEjrXt4PkEfZBa6w6CpQK kmLV0SklnnJ/IOiU98ZxqQS5DB31N6LZoWX2oTVPyv2CuUiZf6h0CpQNtk9EyhnCQgR1CH bMh/UxcyOLLc5S2Vj7S+kp7MQi+ys+eVJXCamudApHHwc7jR4fWnDQPNqZMImg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684504191; a=rsa-sha256; cv=none; b=l25PSBsr+Hl0FU2UfxndGG/SGeFdzsKbrvJ953q2G4SpT8bPk8+tSlPBYO3C+GWypGHneR P5+eV3qupb5+gFJ1oM3/ZX5txWVeFnn7pj5rbHWjB9dGj34u1saT6QITwKFTreCqqsh8WA d9Vnq8Pie+VWTpnXLUEdHEafdepeo9zu1xSJcf6OgK1dhzVf0sf9WC5vz4L9GhuOxIup9Z m+QSgJXuFkgcJ1ANiHLMVxw9HbtjFibHMHIZ9Oo0gnYMfAbeiFPMacZ7CtsXBBVqqTrpwx 8xqjYDnzEOo+UWfvP0/5KPI5Pyxxy4ObWceoyz8F1JWeuEPZlKSJRGB6nToaxw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QN7WM13PSzW11; Fri, 19 May 2023 13:49:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 34JDnpTv060771; Fri, 19 May 2023 13:49:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 34JDnp8J060770; Fri, 19 May 2023 13:49:51 GMT (envelope-from git) Date: Fri, 19 May 2023 13:49:51 GMT Message-Id: <202305191349.34JDnp8J060770@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Colin Percival Subject: git: 40b287054521 - main - mi_startup: Instrument the bubblesort with TSLOG List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 40b287054521f0a92e5ae9a26e6a87d17ee85eea Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=40b287054521f0a92e5ae9a26e6a87d17ee85eea commit 40b287054521f0a92e5ae9a26e6a87d17ee85eea Author: Colin Percival AuthorDate: 2023-05-19 13:46:42 +0000 Commit: Colin Percival CommitDate: 2023-05-19 13:46:42 +0000 mi_startup: Instrument the bubblesort with TSLOG The bubblesort of SYSINITs is currently responsible for 7% of the kernel boot time when booting a 1 CPU / 128 MB VM under Firecracker. It needs to be replaced with a faster sort, but until that happens at least instrumenting it with TSLOG makes it show up in flamecharts. --- sys/kern/init_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/kern/init_main.c b/sys/kern/init_main.c index 1974c4e68ce4..e4cb501bc57b 100644 --- a/sys/kern/init_main.c +++ b/sys/kern/init_main.c @@ -255,6 +255,7 @@ restart: * Perform a bubble sort of the system initialization objects by * their subsystem (primary key) and order (secondary key). */ + TSENTER2("bubblesort"); for (sipp = sysinit; sipp < sysinit_end; sipp++) { for (xipp = sipp + 1; xipp < sysinit_end; xipp++) { if ((*sipp)->subsystem < (*xipp)->subsystem || @@ -266,6 +267,7 @@ restart: *xipp = save; } } + TSEXIT2("bubblesort"); last = SI_SUB_COPYRIGHT; #if defined(VERBOSE_SYSINIT)