From nobody Thu May 18 15:21:11 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QMYbD3xRkz4Bgc9; Thu, 18 May 2023 15:21:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QMYbC5wZ4z4L4l; Thu, 18 May 2023 15:21:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684423271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=48OSou+g3/29/5aUdJtT2s4LDy08wM6jIVb2f55xuVA=; b=mshSCxGMRwkAM9uPhy4MeHUZvR9fsAJDtipBdwvXCEV6aTw+tNZ4ZxCE/P3w7fh7TZWpkW X+0Te2+qGEhrER13e8Pr4usTGuZ1jmywYoCQ9s/+IyRcv0L+RaoolN0uDe1z8urOR/kmtF jTaS3+Hi4ALZ1kwcAud0I4PyoBzsMTVZVGP1kigdXydvT5XIm+kRqwtwNBuHzciVi6aX0d Nwhhy+s8Q4wqvreKr3JwNqJjYe21nNPYGc0TMYtUttMLISGwxrHEdYKqmH+ikg7MVZtpit chIEldplrV/UGTHerElNwboT81WzFtKdpU9ZfFL5QUN7PVuxRufX0bJhwwRBCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684423271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=48OSou+g3/29/5aUdJtT2s4LDy08wM6jIVb2f55xuVA=; b=QPqfTzbVtH+MdVdk5j41LTzN0eVMcFzwYXcTab49x7I3XHvMwYZtbamwllHXk73bl8VmMs NMIZOZ6OqL0vp4HwOEJr+EJ1EMt196U/gxKNIDc8e89KYnv5mdkI6InAgB7CvAHQPixl+U 70EfNRzKl5Vb6/COx3sBVrUSRv9s4g4z8MAJwylQrnNX73/vvuyKlBZyAR7b/gt18D9Ews IU8mQY/tjtviBhbB289cvchSwx6C/RXO2XPpMZkjHKPvI1rZE6SNFyvgTjCcnJKM+91u6z jQO4aNbAVCQ8W9Wpvcwel4fnSN+p+mHQrcWQMJSl1KnHK7BqeavQkBfP8or5NA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684423271; a=rsa-sha256; cv=none; b=eCN6NxQrFWg7lG4kOilxJqRQnj7/72BfSAkOLLTlTftZ+NW8X8B89fPWOHb8YvbSWKkjgx bIY6uPOo0eo1ENwOgEnb3Y8C/pZUHSHfOgvRmLxhkGGnTzt743GI04pkc0SYjMqkHb+Eyw B5ICjrd9dN046kNjGjvWRm1cq0BSSj+vzLB+YXzKrrRcXP8FrPMYm14m6N27ly7f0Oo5Qv nPwMF5KeQkqQP4jx7EpTAHNXdw357EPISTrp6Lu9TxbBnX6q1MlZjcILjZMtOH11a8U4vd b0oBYSK4kEA/lhGNeJzPEsxJ06EtgonCmmu1I35qxXs7M1rHDChYq1AgDeu1Ow== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QMYbC508fzr25; Thu, 18 May 2023 15:21:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 34IFLBBj048672; Thu, 18 May 2023 15:21:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 34IFLBhX048670; Thu, 18 May 2023 15:21:11 GMT (envelope-from git) Date: Thu, 18 May 2023 15:21:11 GMT Message-Id: <202305181521.34IFLBhX048670@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Colin Percival Subject: git: dc5361ea16bf - main - rc.d/netif: Don't DAD if lo0 is the only IPv6 IF List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: dc5361ea16bf5bffab43823eb128f4081f0a5097 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=dc5361ea16bf5bffab43823eb128f4081f0a5097 commit dc5361ea16bf5bffab43823eb128f4081f0a5097 Author: Colin Percival AuthorDate: 2023-05-18 03:17:24 +0000 Commit: Colin Percival CommitDate: 2023-05-18 15:20:15 +0000 rc.d/netif: Don't DAD if lo0 is the only IPv6 IF The code in rc.d/netif waiting for IPv6 Duplicate Address Detection if any network interfaces support IPv6. Unfortunately, since lo0 *always* has IPv6 enabled, this means unconditionally sleeping, even on systems which have no external IPv6 interfaces. Since we presume that there is little risk of a duplicate address being assigned on lo0, amend the test to wait only if there is an interface *other than lo0* which supports IPv6. Reviewed by: bz Differential Revision: https://reviews.freebsd.org/D40141 --- libexec/rc/rc.d/netif | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libexec/rc/rc.d/netif b/libexec/rc/rc.d/netif index 1a2fe0b73589..ba6b43917378 100755 --- a/libexec/rc/rc.d/netif +++ b/libexec/rc/rc.d/netif @@ -215,7 +215,7 @@ netif_common() esac if ${_func} ${ifn} $2; then _ok="${_ok} ${ifn}" - if ipv6if ${ifn}; then + if ipv6if ${ifn} && [ "${ifn}" != "lo0" ]; then _dadwait=1 fi else