From nobody Tue May 16 06:48:42 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QL6Jp3d66z4BfcN; Tue, 16 May 2023 06:48:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QL6Jp37qhz4Bp5; Tue, 16 May 2023 06:48:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684219722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WsmvHqPviD27uLfH6PTuB29b9n+3adWHvfq8DhywOIo=; b=IltMr48KxB5vEEn5zwcAT01P7xyrHTZtKkxr/7GVFiPTh/UegAFVrIBidCot7xi39XcPAP E8OeFz5OpYJvi7c9NMD+OscG3UWzYywPxAluCr+RIIqUhZoBCy5opomYZFx9C7neWWziP5 DC8hY9EsLDBIUxcnOgkIuZ10k75qWIVU8lqCNIefCegV85Lh75vjUjIgbHz031lbkFig29 TGfltWlbEjdvMADFVbUi6xXJhZEuLIpAWS6aC/WbyX04ZpWzjM3Eui+5nfN4N1MWm/xU8A Rpy+LjW7mJet+LT5NWuLJtEPXzFO7X8N32X/j3FaacrrzxSw+t0y5mQUo1dU0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684219722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WsmvHqPviD27uLfH6PTuB29b9n+3adWHvfq8DhywOIo=; b=pw1xjdHOCyZHHV1GIsb70mIOM4sJAah+nLrCAePJsSUqKFOPCw5FVqVudCcBGHTUANhpLT OQFF6JWDIkKeLWNRXsqYYpxVhy2K3xjxA1PXYH6/XgDmb+ZkdJASK+FfsISZie99W1zb7W FS8Gb3cYAiur8kfKitWyhsIlM2p5IViv+epMrhvD6aRYmjWw2oYOHLBD15ZxWoTwWjhw5w l9y4iwb4LDey4R0bB0YU1rvm1HSprSITkdv6A/qe5blTQwAu9f/wBkQtGWMOQsdJim+6vR +f9JYnYnz8iE+5eSENaWs9ShqmZQWMBQcYvZ4y92DSWJzozXrkatYJ/lq9/s0A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684219722; a=rsa-sha256; cv=none; b=iEGbh3/6qPkmcJtx5SVkVf5NjGYCopZuvdChaE4l5uKf3fDiSDVcc/ihYgRHbO/tA1oXVn OuTSbIOumHVlH+gc3xVHOD9YMmMMtW9CrWMPKmYvEEBs3lTUON3CQYQ3dMK7cWgN/4ls2E HWjDduVDjJaU46WY2fwlf1u5OGDUKSJIQ+tCk91RK0VVCk69/j67kN4N9OtDjWtN1fhG/o AKrHjtsCp1rlFCzK82CRb+eXqYsBdTSQBQard2J+N4CLL7rbZjhezsTzvRselG7LS+GUQu 2y8WQzvkl/fsdeK8Sq3NS8aD36+omBB4Ag5qGOSndMpUNsg6pJ4e2F87xhZ7eQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QL6Jp2BdZz1CF5; Tue, 16 May 2023 06:48:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 34G6mg7H055609; Tue, 16 May 2023 06:48:42 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 34G6mgDI055608; Tue, 16 May 2023 06:48:42 GMT (envelope-from git) Date: Tue, 16 May 2023 06:48:42 GMT Message-Id: <202305160648.34G6mgDI055608@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Baptiste Daroussin Subject: git: e0155c698904 - main - pw: The pw_checkname function has added ';' checking. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bapt X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e0155c6989049da43c5499f7129002aa17d1ca79 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by bapt: URL: https://cgit.FreeBSD.org/src/commit/?id=e0155c6989049da43c5499f7129002aa17d1ca79 commit e0155c6989049da43c5499f7129002aa17d1ca79 Author: pbuff AuthorDate: 2023-05-16 03:05:30 +0000 Commit: Baptiste Daroussin CommitDate: 2023-05-16 06:48:08 +0000 pw: The pw_checkname function has added ';' checking. The pw_checkname function forgot to include a ';' when checking usernames, causing shell commands to be executed when a username with a ';' is deleted. PR: 271427 MFC After: 3 days --- usr.sbin/pw/pw_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/pw/pw_user.c b/usr.sbin/pw/pw_user.c index c0002f985bfb..c8e8de1fc46a 100644 --- a/usr.sbin/pw/pw_user.c +++ b/usr.sbin/pw/pw_user.c @@ -636,7 +636,7 @@ pw_checkname(char *name, int gecos) showtype = "gecos field"; } else { /* See if the name is valid as a userid or group. */ - badchars = " ,\t:+&#%$^()!@~*?<>=|\\/\""; + badchars = " ,\t:+&#%$^()!@~*?<>=|\\/\";"; showtype = "userid/group name"; /* Userids and groups can not have a leading '-'. */ if (*ch == '-')