From nobody Tue May 16 00:39:45 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QKy7F70VFz4BJWj; Tue, 16 May 2023 00:39:53 +0000 (UTC) (envelope-from mack@macktronics.com) Received: from mail.macktronics.com (coco.macktronics.com [209.181.253.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4QKy7F4zXRz3PWm; Tue, 16 May 2023 00:39:53 +0000 (UTC) (envelope-from mack@macktronics.com) Authentication-Results: mx1.freebsd.org; none Received: from olive.macktronics.com (unknown [209.181.253.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.macktronics.com (Postfix) with ESMTPS id BFE00E406; Mon, 15 May 2023 19:39:45 -0500 (CDT) Date: Mon, 15 May 2023 19:39:45 -0500 (CDT) From: Dan Mack To: Jessica Clarke cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 28f66935d400 - main - tests: Disable sys/compat32 and sys/compat32/aarch64 tests In-Reply-To: <202305152219.34FMJwwI016645@gitrepo.freebsd.org> Message-ID: References: <202305152219.34FMJwwI016645@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 4QKy7F4zXRz3PWm X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:209, ipnet:209.181.252.0/23, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Mon, 15 May 2023, Jessica Clarke wrote: > The branch main has been updated by jrtc27: > > URL: https://cgit.FreeBSD.org/src/commit/?id=28f66935d400eb3fb52f4e64931c0cb3c9d24be4 > > commit 28f66935d400eb3fb52f4e64931c0cb3c9d24be4 > Author: Jessica Clarke > AuthorDate: 2023-05-15 22:16:40 +0000 > Commit: Jessica Clarke > CommitDate: 2023-05-15 22:16:40 +0000 > > tests: Disable sys/compat32 and sys/compat32/aarch64 tests > > The former has build system issues, with missing Kyuafiles, presumably > due to not using TESTS_SUBDIRS and bsd.test.mk (and possibly some issues > on top of that around TESTSDIR and related variables). The latter has > issues with GCC and cut-down LLVM builds. > > Requested by: kevans > Fixes: ccb59683b983 ("arm64: add tests for swp/swpb emulation") > --- > tests/sys/compat32/Makefile | 4 +++- > tests/sys/compat32/aarch64/Makefile | 3 +++ > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/tests/sys/compat32/Makefile b/tests/sys/compat32/Makefile > index 31834de16246..3dd5ca218d00 100644 > --- a/tests/sys/compat32/Makefile > +++ b/tests/sys/compat32/Makefile > @@ -1,6 +1,8 @@ > - > +# XXX: Currently broken in CI > +.if 0 > .if exists(${.CURDIR}/${MACHINE_ARCH}) > SUBDIR+= ${MACHINE_ARCH} > .endif > > .include > +.endif > diff --git a/tests/sys/compat32/aarch64/Makefile b/tests/sys/compat32/aarch64/Makefile > index 716182b15d9c..f5961b06cc8b 100644 > --- a/tests/sys/compat32/aarch64/Makefile > +++ b/tests/sys/compat32/aarch64/Makefile > @@ -1,3 +1,5 @@ > +# XXX: Doesn't work with GCC and requires an LLVM with the ARM backend > +.if 0 > PACKAGE= tests > FILESGROUPS+= asmprogs > > @@ -22,3 +24,4 @@ ${aprog}: ${aprog}.S > .endfor > > .include > +.endif > My build just failed on: root@fbsd14:/usr/src # git rev-parse --short HEAD 28f66935d400 ... ===> tests/sys/compat32 (cleandir) make[5]: don't know how to make cleandir. Stop make[5]: stopped in /usr/src/tests/sys/compat32 *** Error code 2 Stop. make[4]: stopped in /usr/src/tests/sys *** Error code 1 Stop. make[3]: stopped in /usr/src/tests *** Error code 1 Stop. make[2]: stopped in /usr/src 57.80 real 41.64 user 0.00 sys *** Error code 1 Stop. make[1]: stopped in /usr/src *** Error code 1