From nobody Sun May 14 12:52:51 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QK2Tv4ft2z4BgN2; Sun, 14 May 2023 12:52:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QK2Tv46Rkz43h3; Sun, 14 May 2023 12:52:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684068771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vOZ/s61He1WCuJhouL9P60pVmrBLJGOtUIioY33DKwQ=; b=LECoLwXN5rF0gRtIDSbTxNTDwBrSz737s4EdXXcngUWlRfMC46Vrgob8Msml9rwxloSQEu EM58d69xmh0YW9V9JIY1VqeF0TtdoCrxRIKyjy7IEBk0g/PyVVuDOzTzTYNZjgUf4SNXEr HkyZ9LLMXKScrRmHjEq50RsVrLaJwXKdz7zKcc+KNZuikEYtsQ1gRjkeqfAWLGqI53C6zU ak8j6DidtPlFpYtHoOvYHAg89YydTICqevZ80MToEM0LiIyFbwdFjlihftYD8Ffnv3+jU9 MiwKR2qK1HqcSNeOaP1JVGSiyOFas1QIs4AzRl0ODaJGCciFs0czCoSSqwCOhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684068771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vOZ/s61He1WCuJhouL9P60pVmrBLJGOtUIioY33DKwQ=; b=k6NBteI5nBFzwapQYg9L4uRswbV+cGrDq+ad8HpVY3vWxNts0cqGE+f8Ly5YGBbZG5MfOv rJnCLvgY+9Se6dTnl5gTUMzfCwlUtuSDgZ5OsBnXDsM3m1dIzxM5d0IlIrd4z/6kHdY20g s5Ty5ll2ZK3ILKnFVNho8qrNAmvvv1lu4xmjyYoqTwfhwT5V5e5HyQIYubzcfyGVl+34MA a94+6ZJ8Aod86wcjR5AjRItO12US9n7Kbh3rJgOiXC5sSYs+1/T+yxl9/GOvZX4K1LU0Vs alKfbPm3jID3UReiVEWwNlEeTlX9hteBrKLB8jBTc8VGpXU2fYKo4BnaM4l9Kw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684068771; a=rsa-sha256; cv=none; b=t9ZSt1HAIAoGftijtixlOMAoXpEMgcQi2K7ocqBLbNVvNA2uHtm9fXsvlLb2pYXxRJGQUp 7IjlH47RWIXYjr3Z7ZffhTAMn0RuW0QTTpjyycMLP91KF9I82Y8OAchaKBYVtGUJxZvz5f y1gfr+AOtWJKvCl4KnG8GHMkJ0m0hog1l4cg0siIF2tHGbV5+yzpyYG5F84+Xe633R+gqt g5o7tiz+YhbcvPMz1zg/QxaUS4f0dRUwS+NQHjcs8bD6HWJJwN4RSpvgtk85coRdQNaShY YV3tj4l5jiOCk5bil+H6PhzaLjfmMhWKskQ9SBD80/9iSKD9KeyU1/exmOt8vg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QK2Tv37XFz10F7; Sun, 14 May 2023 12:52:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 34ECqpLn023085; Sun, 14 May 2023 12:52:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 34ECqpb3023084; Sun, 14 May 2023 12:52:51 GMT (envelope-from git) Date: Sun, 14 May 2023 12:52:51 GMT Message-Id: <202305141252.34ECqpb3023084@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 3aa0cc47eeb0 - main - CONTRIBUTING.md: minor changes List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3aa0cc47eeb05a8d0e8bc2a29211e3ee6ad2324c Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=3aa0cc47eeb05a8d0e8bc2a29211e3ee6ad2324c commit 3aa0cc47eeb05a8d0e8bc2a29211e3ee6ad2324c Author: Graham Perrin AuthorDate: 2023-05-14 12:49:00 +0000 Commit: Warner Losh CommitDate: 2023-05-14 12:51:56 +0000 CONTRIBUTING.md: minor changes Fix a singular/plural mistake, spelling error, a markup error, and a handful of other minor changes. Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/742 --- CONTRIBUTING.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cc86e096dd18..fab8262070ce 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -23,9 +23,9 @@ changes where the contributor already has a GitHub account. Presently, GitHub 'freebsd-src' repository is one of the publish-only services for the FreeBSD 'src' repository the project uses to promote collaboration and contribution. Pull requests that need little developer time, are generally -small, and have limited scope should be submitted. Do not submit pull request -that are a problem reports, works in progress, changes that are controversial -and need discussion, changes require specialize review, or are security related. +small, and have limited scope should be submitted. Do not submit pull requests +that are security-related, problem reports, works in progress, changes that are controversial +and need discussion, or changes that require specialized review. A pull request will be considered if: @@ -34,15 +34,15 @@ A pull request will be considered if: * You can respond to feedback quickly. * It touches fewer than about 10 files and the changes are less than about 200 lines. Changes larger than this may be OK, or you may be asked to submit multiple pull requests of a more manageable size. * Each logical change is a separate commit within the pull request. Commit messages for each change should follow the [commit log message guide](https://docs.freebsd.org/en/articles/committers-guide/#commit-log-message). -* All commits have your name and valid email address as you would like to see them in the FreeBSD repository as the author. Fake github.com addresses cannot be used. +* All commits have, as the author, your name and valid email address as you would like to see them in the FreeBSD repository. Fake github.com addresses cannot be used. * The scope of the pull request should not change during review. If the review suggests changes that expand the scope, please create an independent pull request. * Fixup commits should be squashed with the commit they are fixing. Each commit in your branch should be suitable for FreeBSD's repository. * Commits should include one or more `Signed-off-by:` lines with full name and email address certifying [Developer Certificate of Origin](https://developercertificate.org/). * The commits follow FreeBSD's style guide. See [Style](#Style). -* Run tools/build/checkstyle9.pl on your git branch and eliminate all errors -* The commits should not introduce trailing white space. -* If the commmit fixes a bug, please add 'PR: ' to the comment message. -* If there's a code review in phabricator, please include a link as a 'Differential Revision: ' line. +* Run tools/build/checkstyle9.pl on your Git branch and eliminate all errors +* The commits do not introduce trailing white space. +* If the commmit fixes a bug, please add 'PR: \\' to the commit message. +* If there's a code review in Phabricator, please include a link as a 'Differential Revision: ' line. When updating your pull request, please rebase with a forced push rather than a merge commit.