From nobody Wed May 10 09:26:48 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QGV602g7Nz49cfs; Wed, 10 May 2023 09:26:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QGV602Bd9z4T59; Wed, 10 May 2023 09:26:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683710808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kOz36Ei3fnKfTLOOhsh9pjAwSooJceTL2a26CwFoxdw=; b=s57h6wFucTYTudOOcPsNghTi/0qegDY3H7npfMzBHdkM11rHgF52bClu/0ECeK0aG01L0e HWkr3DxjQkgPu9ddOXC7SakuY5iYvrolcJdsEHXVtqqvIWyMQgKdDS8NfCdKclKWukMMBO arSUrnaU7Vy8iORHVyyqCoKGkm+mh0+U8woR5YHhWF4WuiBpaj7JVU7qsshqYwt4Lah9QR lA+urgWbQRQ9kBKYqr1MWLo7Fkp3NYWhPD2x6Zvxeoej2NSGcxz4hsDk7kB9fBvwzRVE4B H5zJ9RxBmRURcyD80uWKWQ0hcr5c4GLJQnwAN/spnq7EjR015th6Kob3rMdIrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683710808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kOz36Ei3fnKfTLOOhsh9pjAwSooJceTL2a26CwFoxdw=; b=RpMrhd0bpjzXob8hHzdI8rRSnuNN9HtNiu0GF4Cw2VlwMYv+5Wy4JxMA0nzhrvcjySMcJr N9Nr1TqCRUE+wKUp/fIjkbqgNTL2VQEWDyPlx4V7Xg9vXOmf/esmzATI7IZ/UpwvZH7OyF tffOOa8iZ7CJubXYn/0e7va3dp0OoSCHwJmchXM1206g/dDk6xVocPwIvyGC1O2tbpZ/1j vjfBYUy7OU3eGMdH3KhZQizIGofAPGPCgVTtQZ6xpMedD93TepJ0aZel383J6SV8seM+eB da4dsqaO3xhc2q2f5BDyBTS6p9JanFhiZvQ4ylg6gZNCfcEkVaaduIf6t0RwvA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683710808; a=rsa-sha256; cv=none; b=n+giIyFpWvbnTqKhlL0rkK0WoP60ReFqiyd2+0s9ERsPQNYLJDJPeU++kmN7W9kLxLjPWF zr4OX58NeJpmoA+d8DjCXI2c58aw37wkBKnPVjonKdIdg8t0btyjS8IRhjP15vdgUaVQu4 o1uZHuXM3IC417Q/EQoECNtgRn24zF/xr9QYIrFUYhC7FnoR1tsAwYM7+9DzBqpuJemGAS 8cuARFcBnpZn51QFEB6ej3kobjrSpynXhE7ZOdtHl105QfhLz76BrHCqPS8AY9LQngX5Ys VweNqo4zidCPvLDCTZuWXrIzjyvUg3/K47K6ivj21slEig9yQfKI41JDRBuDWw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QGV601Gxdz14Ss; Wed, 10 May 2023 09:26:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 34A9QmZm092847; Wed, 10 May 2023 09:26:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 34A9Qm1B092846; Wed, 10 May 2023 09:26:48 GMT (envelope-from git) Date: Wed, 10 May 2023 09:26:48 GMT Message-Id: <202305100926.34A9Qm1B092846@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: =?utf-8?Q?Dag-Erling=20Sm=C3=B8rgrav?= Subject: git: facc213643f8 - main - md5: Don't increment a bool. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: facc213643f80bbdb0ebd76f5b26de84d95b9e1a Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=facc213643f80bbdb0ebd76f5b26de84d95b9e1a commit facc213643f80bbdb0ebd76f5b26de84d95b9e1a Author: Dag-Erling Smørgrav AuthorDate: 2023-05-09 17:59:27 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2023-05-10 09:25:21 +0000 md5: Don't increment a bool. Fixes: 4849767cb16a MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D40020 --- sbin/md5/md5.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sbin/md5/md5.c b/sbin/md5/md5.c index b11fc6971735..202cc830d4ed 100644 --- a/sbin/md5/md5.c +++ b/sbin/md5/md5.c @@ -662,7 +662,7 @@ main(int argc, char *argv[]) } if (failed) return (1); - if (checksFailed != 0) + if (checksFailed > 0) return (2); return (0); @@ -759,7 +759,7 @@ MDOutput(const Algorithm_t *alg, char *p, const char *name) if (p == NULL) { warn("%s", name); - failed++; + failed = true; } else if (cflag && mode != mode_bsd) { checkfailed = strcasecmp(checkAgainst, p) != 0; if (!sflag && (!qflag || checkfailed)) @@ -1001,7 +1001,7 @@ MDTestSuite(const Algorithm_t *alg) printf(" - verified correct\n"); } else { printf(" - INCORRECT RESULT!\n"); - failed++; + failed = true; } } }