From nobody Tue May 09 13:56:38 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QG07w6Kwmz4BDDc; Tue, 9 May 2023 13:56:44 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QG07w5mRDz3Ldw; Tue, 9 May 2023 13:56:44 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683640604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kb/tIDqFnIXrGBHAtaGBRGQXDT/4uNnbC3V2DKMZRWw=; b=N7HhxKkw904In8EiCipyiFQKxlCdhPwtJjxPjThdTkzh5PKBo8EXlWSKYCOAqPHufxV7Gb Zzo6hctiXpTSuODjy53gjXeA0CCc3HvyDgrj30+6SZd78r9yvjO8deUjje4WJp8lqzzGrw ZIVOlObRbgTg1IoCIt2hmRZM57GfBF9DGQKO7sAGEMRfFAhkM8x5N9iStr93VHtiCLqRiD PibSQLL+CUrYgm9GI4TuQfdPZeozECpqgmR2CtGLjXsC7qcVM/dH8jLApYUDsdAMKvseXx EgF1u6P3YFu2JjzGsOOseuVepkKmWHPxssMsKrbETh+1YFcr17EaJWmrfogOxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683640604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kb/tIDqFnIXrGBHAtaGBRGQXDT/4uNnbC3V2DKMZRWw=; b=BZxmDxCevkU1mpsr+aVVs0mcWyKHnIBxcWgSwCwEYaHyvudvEntJ4i295rqoUXEF7cBvS1 HSwQSKbFoVtcIEKLz9B0qRRT8MSkN4c3KvHISdSVZzjcMPJPw7/TtvfZgt75Ho5/CZstRg 0Im8cTE+5IB3jl+rcnoDUMH2AprEqvOaa9xu128EYjZzk5rhJI8hNp4krNLM+HZds4guPF osK2pbxGJj70bLYolS2Ey1hHPfYDu4X0SeURSET3zmC+CLrkA884BW8oz6/h1q5IE1JEOh 6HBgiIVdUCrZKsB4Pgsi1HqgfAhh4NLeqABdShKnA18S5HFDou8oJb0iGKAJNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683640604; a=rsa-sha256; cv=none; b=qFeSOY71Y0TlgJ1EHLfh4fyzg+47NqbL8a8sXXUPdK+19b7MKgnnZ4eE05VitMqjbNQZsB k+rVSYIkUlQ3wpBZ63L+fjiBWfBzFvF99IMYlr3UjTsTmbG8WlOHlpLs7K5PGRQgCNOh/e 3ZrZyNotU8vZXVoxHLkJs1vew0YYaRP3mJ8Tyj/o2RClyCIlhH7sJ2bSGSNCU4LaUKkFNG 1BGJgSzo8Ech3t9KGhgl+MXjesZ7lM4yUEurIDpJgAUukDh+ymgiu+iwCQRKhUA8FeHm/t ALw1MTDNhk9FkjTO5g2N6Z2lLxEFvBTCcmag1C/OuQZPtcaYGHv3AyBs8Y4opA== Received: from mx1.sbone.de (cross.sbone.de [195.201.62.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE Root Certificate Authority" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QG07w46MMzMJw; Tue, 9 May 2023 13:56:44 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 4C4318D4A156; Tue, 9 May 2023 13:56:42 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id A903B5C3A831; Tue, 9 May 2023 13:56:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id RflykyYN-AUI; Tue, 9 May 2023 13:56:39 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:b66b:fcff:fef3:e3d2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id AF2CB5C3A82F; Tue, 9 May 2023 13:56:39 +0000 (UTC) Date: Tue, 9 May 2023 13:56:38 +0000 (UTC) From: "Bjoern A. Zeeb" To: Emmanuel Vadot cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: d198b8774d2c - main - fwget: Introduce new utility In-Reply-To: <202305010633.3416XRFq013077@gitrepo.freebsd.org> Message-ID: References: <202305010633.3416XRFq013077@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-ThisMailContainsUnwantedMimeParts: N On Mon, 1 May 2023, Emmanuel Vadot wrote: > The branch main has been updated by manu: > > URL: https://cgit.FreeBSD.org/src/commit/?id=d198b8774d2cfb6f140893e1c6236af9e97d1497 > > commit d198b8774d2cfb6f140893e1c6236af9e97d1497 > Author: Emmanuel Vadot > AuthorDate: 2023-04-26 05:46:20 +0000 > Commit: Emmanuel Vadot > CommitDate: 2023-05-01 06:32:59 +0000 > > fwget: Introduce new utility > > This script's goal is to check the system for peripherals that needs > firmware and install the needed packages for them. > For now it only support pci subsystem and only video classes for AMD > and Intel GPUs. > > Reviewed by: bapt > Sponsored by: Beckhoff Automation GmbH & Co. KG > Differential Revision: https://reviews.freebsd.org/D39825 ... > diff --git a/usr.sbin/fwget/pci/pci_video_intel b/usr.sbin/fwget/pci/pci_video_intel > new file mode 100644 > index 000000000000..9a20abcdb17a > --- /dev/null > +++ b/usr.sbin/fwget/pci/pci_video_intel ... > +pci_video_intel() > +{ > + case "$1" in Based on % pkg search gpu-firmware-intel gpu-firmware-intel-kmod-alderlake-20230210_1 Firmware modules for alderlake Intel GPUs gpu-firmware-intel-kmod-broxton-20230210_1 Firmware modules for broxton Intel GPUs gpu-firmware-intel-kmod-cannonlake-20230210_1 Firmware modules for cannonlake Intel GPUs gpu-firmware-intel-kmod-dg1-20230210_1 Firmware modules for dg1 Intel GPUs gpu-firmware-intel-kmod-elkhartlake-20230210_1 Firmware modules for elkhartlake Intel GPUs gpu-firmware-intel-kmod-geminilake-20230210_1 Firmware modules for geminilake Intel GPUs gpu-firmware-intel-kmod-icelake-20230210_1 Firmware modules for icelake Intel GPUs gpu-firmware-intel-kmod-kabylake-20230210_1 Firmware modules for kabylake Intel GPUs gpu-firmware-intel-kmod-rocketlake-20230210_1 Firmware modules for rocketlake Intel GPUs gpu-firmware-intel-kmod-skylake-20230210_1 Firmware modules for skylake Intel GPUs gpu-firmware-intel-kmod-tigerlake-20230210_1 Firmware modules for tigerlake Intel GPUs I think a few of them are missing the "-kmod" miiddle bit: diff --git a/usr.sbin/fwget/pci/pci_video_intel b/usr.sbin/fwget/pci/pci_video_intel index 9a20abcdb17a..3d37a430c3d2 100644 --- a/usr.sbin/fwget/pci/pci_video_intel +++ b/usr.sbin/fwget/pci/pci_video_intel @@ -45,31 +45,31 @@ pci_video_intel() ;; # Cannonlake 0x5a*) - echo "gpu-firmware-intel-cannonlake" + echo "gpu-firmware-intel-kmod-cannonlake" ;; # Icelake 0x8a*) - echo "gpu-firmware-intel-icelake" + echo "gpu-firmware-intel-kmod-icelake" ;; # Elkhartlake/Jasperlake 0x45*|0x4e*) - echo "gpu-firmware-intel-elkhartlake" + echo "gpu-firmware-intel-kmod-elkhartlake" ;; # Tigerlake 0x9a*) - echo "gpu-firmware-intel-tigerlake" + echo "gpu-firmware-intel-kmod-tigerlake" ;; # Rocketlake (Uses tigerlake GuC/HuC firmware) 0x4c*) - echo "gpu-firmware-intel-rocketlake gpu-firmware-intel-tigerlake" + echo "gpu-firmware-intel-kmod-rocketlake gpu-firmware-intel-kmod-tigerlake" ;; # DG1 0x49*) - echo "gpu-firmware-intel-dg1" + echo "gpu-firmware-intel-kmod-dg1" ;; # Alderlake (Uses tigerlake GuC/HuC firmware) 0x46*) - echo "gpu-firmware-intel-alderlake gpu-firmware-intel-tigerlake" + echo "gpu-firmware-intel-kmod-alderlake gpu-firmware-intel-kmod-tigerlake" ;; *) log "No package found for device $1" -- Bjoern A. Zeeb r15:7