From nobody Sat May 06 17:56:40 2023
X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QDFcT2j9xz49tHY;
	Sat,  6 May 2023 17:56:57 +0000 (UTC)
	(envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id 4QDFcS6nWnz3Mjl;
	Sat,  6 May 2023 17:56:56 +0000 (UTC)
	(envelope-from kostikbel@gmail.com)
Authentication-Results: mx1.freebsd.org;
	none
Received: from tom.home (kib@localhost [127.0.0.1])
	by kib.kiev.ua (8.17.1/8.17.1) with ESMTPS id 346Huepf092455
	(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
	Sat, 6 May 2023 20:56:44 +0300 (EEST)
	(envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 346Huepf092455
Received: (from kostik@localhost)
	by tom.home (8.17.1/8.17.1/Submit) id 346HueJv092454;
	Sat, 6 May 2023 20:56:40 +0300 (EEST)
	(envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f
Date: Sat, 6 May 2023 20:56:40 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Dag-Erling =?utf-8?B?U23DuHJncmF2?= <des@des.no>
Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org,
        dev-commits-src-main@freebsd.org
Subject: Re: git: 5807f35c541c - main - dd: Fix SIGINT handling.
Message-ID: <ZFaU2F0NRdRlXsYz@kib.kiev.ua>
References: <202305051245.345CjNLE048275@gitrepo.freebsd.org>
 <ZFVJMIKu4v4OnPZL@kib.kiev.ua>
 <86a5yhy5oe.fsf@ltc.des.no>
List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all
List-Help: <mailto:dev-commits-src-all+help@freebsd.org>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-all+unsubscribe@freebsd.org>
Sender: owner-dev-commits-src-all@freebsd.org
X-BeenThere: dev-commits-src-all@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <86a5yhy5oe.fsf@ltc.des.no>
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
	DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM,
	NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.0
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on tom.home
X-Rspamd-Queue-Id: 4QDFcS6nWnz3Mjl
X-Spamd-Bar: ----
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-ThisMailContainsUnwantedMimeParts: N

On Sat, May 06, 2023 at 03:01:53PM +0200, Dag-Erling Smørgrav wrote:
> Konstantin Belousov <kostikbel@gmail.com> writes:
> > This does not fix SIGINT handler, it only (significantly) reduces the window
> > where the issue could occur.
> 
> Yes, it does.  I think you fundamentally misunderstand the intent of the
> patch.  I know there is a tiny race but it's still a vast improvement on
> the original.
> 
> > See my latest comment on the review.
> 
> See my reply.
I do not see a reply to my last comment in the review.