git: 81f964e2ffb7 - main - authpf: do not sprintf to a null pointer

From: Ed Maste <emaste_at_FreeBSD.org>
Date: Wed, 03 May 2023 14:03:44 UTC
The branch main has been updated by emaste:

URL: https://cgit.FreeBSD.org/src/commit/?id=81f964e2ffb7cd5d30df0a5c3877900cca4fdd07

commit 81f964e2ffb7cd5d30df0a5c3877900cca4fdd07
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2023-05-03 13:26:42 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2023-05-03 14:03:27 +0000

    authpf: do not sprintf to a null pointer
    
    The fgetln loop will terminate with buf = NULL at EOF.
    
    Reported by:    GCC
    Reviewed by:    kp
    MFC after:      3 days
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D39947
---
 contrib/pf/authpf/authpf.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/contrib/pf/authpf/authpf.c b/contrib/pf/authpf/authpf.c
index 4032efb27895..5ffa5b9cfe43 100644
--- a/contrib/pf/authpf/authpf.c
+++ b/contrib/pf/authpf/authpf.c
@@ -566,9 +566,8 @@ allowed_luser(struct passwd *pw)
 		syslog(LOG_INFO, "denied access to %s: not listed in %s",
 		    pw->pw_name, PATH_ALLOWFILE);
 
-		/* reuse buf */
-		sprintf(buf, "%s", "\n\nSorry, you are not allowed to use this facility!\n");
-		fputs(buf, stdout);
+		fputs("\n\nSorry, you are not allowed to use this facility!\n",
+		    stdout);
 	}
 	fflush(stdout);
 	return (0);