From nobody Fri Mar 31 17:27:54 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pp6gt4R7Xz432KC; Fri, 31 Mar 2023 17:28:10 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pp6gt2hnhz4SVS; Fri, 31 Mar 2023 17:28:10 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-f50.google.com with SMTP id g19so16743983lfr.9; Fri, 31 Mar 2023 10:28:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680283688; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M4qMo8N3etndLGBuwEuOuvJccmcRQK6f8yK/yI3kXwI=; b=bmG9MvFpP9m5O/bzGNjrSVygN1jaN8dpUocf0XYZaf1kAQ/OdxtuBHQGn8tVrPoZ8e lBwlBu6EI7joCzvEJ2juhK313q5tHsVkQ7OZWZ6Z13//JEBhpc4Tksx8Av144wNTk5jX gZZBV9qvh2BqoFm3TyVHZ2isduV6cREVMU20JCu920QL+ksB+BPcg/+yZ94KHlhFqthV zNRLe+b4rkB+neeLgcmxc3pMxKC433haXtuc/9IjO0oxzqdj4UBIz9AJuYukqKz4XxVP 6aLNU+N1ztt7HMyVBdvTq/laV/qjxmyv9pZY9NfJU9VN3UNZyw2VZorlRwb01UAlHhl0 z/hA== X-Gm-Message-State: AAQBX9eNmrwgoH62q2Y0gpmAVU4Na6iTKsRQSo4m8tVtxdXqpvAGfYn1 XX9ktlF8d/L465CG7L7GWdtfqvKmxKm3mlEUf1fdKZGRpv8= X-Google-Smtp-Source: AKy350bol5zOO/f/n+0FujtCvHVpJ/AAbHgxMdVNs9xyArVJALcn4uISQdGLS1vQVxEJIEEmUZhA5uSfyjkmsmE0jWI= X-Received: by 2002:ac2:4844:0:b0:4db:1ae1:318b with SMTP id 4-20020ac24844000000b004db1ae1318bmr8255015lfy.5.1680283687606; Fri, 31 Mar 2023 10:28:07 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202303272339.32RNdWPD063667@gitrepo.freebsd.org> In-Reply-To: From: Ed Maste Date: Fri, 31 Mar 2023 13:27:54 -0400 Message-ID: Subject: Re: git: 61194e9852e6 - main - Add kqueue1() syscall To: Charlie Li Cc: Konstantin Belousov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, "freebsd-x11@freebsd.org" , FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4Pp6gt2hnhz4SVS X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Fri, 31 Mar 2023 at 12:38, Charlie Li wrote: > > Konstantin Belousov wrote: > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=61194e9852e641d1533cd04a5679d6042ff975d3 > > > > commit 61194e9852e641d1533cd04a5679d6042ff975d3 > > Author: Konstantin Belousov > > AuthorDate: 2023-03-25 23:39:02 +0000 > > Commit: Konstantin Belousov > > CommitDate: 2023-03-27 23:39:26 +0000 > > > > Add kqueue1() syscall > > > > It takes the flags argument. Immediate use is to provide the KQUEUE_CLOEXEC > > flag for kqueue(2). > > > This commit series causes x11/libinput to hit an assert (which also > silently crashes X on launch): > > Assertion failed: (libinput->refcount > 0), function libinput_unref, file ../src/libinput.c, line 1957. > > devel/libepoll-shim, x11/libinput's prime dependency, has its own > kqueue1() implementation, which is used when the system does not already > have one. Reverting this series and rebuilding devel/libepoll-shim to > use its included implementation allows x11/libinput to work again. Ah, NetBSD added kqueue1 some time ago, and it uses the already existing flags (O_CLOEXEC etc.) If it's easy to test, can you try changing libepoll-shim to call kqueue1(KQUEUE_CLOEXEC)?