From nobody Tue Mar 28 07:16:03 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pm1FC2RXRz41VmF for ; Tue, 28 Mar 2023 07:16:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pm1FC1yPtz3pFF for ; Tue, 28 Mar 2023 07:16:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x531.google.com with SMTP id w9so45688419edc.3 for ; Tue, 28 Mar 2023 00:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; t=1679987774; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zfbf6bx039j7CdNFzyrQI8eFD7T7tChLukK++MS4t2A=; b=LuyB8gBdiNjNoljq0nFj7Blu7e0tgyuAWgIMG3W73yFFaTNGRDseucmoRjOalMDIwN teMCwnLc57YpSJzMeLTIA4c0z/pLdTBsgSNWwqUI/Cs7Tew2QnmjUIkYo32kvJT3SnUW 9lxncBJM01CrXBD1AtHOFMESaG8KlG2jVcWnUCXS0rtJGWl2xhcfHZTcnEg2RPFVq2mu aNrWIISWtvEHhlYBk46icL4QQki4JyzAIZF4Al+qiuEPgoSH1q5ElvZ2cTmG5Wxc9Nav FP+fnUy3xzar1dgpU7IsYKifUowQqwImdLRf6rzCIOfSe59gh86qGH4JjWcltMgLaro2 a+dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679987774; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zfbf6bx039j7CdNFzyrQI8eFD7T7tChLukK++MS4t2A=; b=wnrgbz2n7TLu9aiVMBTKup0gVewnCsmSP4rj6K0ElIacyHoV7vWQZbjhwjTb3sJox6 IuAV8xoctfWvX4yppMTeaUw9hM+dAYbaIYhmkALvoF7jtJwv7T1dqoPFYDXJeQSrgWfR XxGNYFvlE1HwPZW/HBC331MFUGPHPOnngMLNm7xjIBSQAFnFsR+fZuwmTA2X4T+a4MVT KNfMVTOc3dOmDL/hN7ECpgtfci/b066MWcaQ0zcSuOm8ZFTcGLW0iXp1wSRpaB5UkjHA 4dwexAI5rsDRWv1vYc9r02Wb3FLj2RpzRpHmpLtSTMMQWEnEM1VHHcaWqPjKhGZbQZWI N2Ow== X-Gm-Message-State: AAQBX9cagTzCS1/9TWVRDFbfhFKd3lcKtJcRICaGvARJhL1tUTssj2ei PRp3LRfWUMFTl+8xjTslH0CkK8SlDm8rjzrJKiNdFg== X-Google-Smtp-Source: AKy350Yg41YJK9eBWCQSSSdBn81rurUlD6m6M5v22lSuDqEaDp0tBye8xOLohi5Kcyc3+efo8JQ04YQlZkRRIeVgLk8= X-Received: by 2002:a50:d68c:0:b0:4fb:80cf:898b with SMTP id r12-20020a50d68c000000b004fb80cf898bmr6720627edi.7.1679987773914; Tue, 28 Mar 2023 00:16:13 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202303272339.32RNdWPD063667@gitrepo.freebsd.org> <930C69C9-64E3-4399-BE35-ABB137F06EC2@freebsd.org> In-Reply-To: From: Warner Losh Date: Tue, 28 Mar 2023 09:16:03 +0200 Message-ID: Subject: Re: git: 61194e9852e6 - main - Add kqueue1() syscall To: Alexey Dokuchaev Cc: Jessica Clarke , Alan Somers , Konstantin Belousov , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000007ddd3905f7f0a251" X-Rspamd-Queue-Id: 4Pm1FC1yPtz3pFF X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --0000000000007ddd3905f7f0a251 Content-Type: text/plain; charset="UTF-8" On Tue, Mar 28, 2023, 8:53 AM Alexey Dokuchaev wrote: > On Tue, Mar 28, 2023 at 01:07:41AM +0100, Jessica Clarke wrote: > > On 28 Mar 2023, at 00:45, Alan Somers wrote: > > > On Mon, Mar 27, 2023 at 4:39???PM Konstantin Belousov wrote: > > >> commit 61194e9852e641d1533cd04a5679d6042ff975d3 > > >> > > >> Add kqueue1() syscall > > >> > > >> It takes the flags argument. Immediate use is to provide the > > >> KQUEUE_CLOEXEC flag for kqueue(2). > > >> > > >> Differential revision: https://reviews.freebsd.org/D39271 > > > > > > We already have abort2(2), dup2(2), pipe2(2), and thr_kill2(2) that > > > are similar to other syscalls but with a flags argument. > > > Additionally, Linux has a renameat(2). But I'm not aware of any > > > syscalls named xxx1. Should we call this new one kqueue2 to follow > > > the existing convention? > > > > This was discussed on the linked review. > > I'm with Alan here, all needed knownledge (results of discussions) > should be part of the commit log, making commit itself sufficiently > understandable and judgeable. > But this is the existing convention.. and has been for decades since like wait4 or earlier. At best it is borderline information... Warner > --0000000000007ddd3905f7f0a251 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Mar 28, 2023, 8:53 AM Alexey Dokuchaev <danfe@freebsd.org> wrote:
On Tue, Mar 28, 2023 at 01:07:41AM +0100, J= essica Clarke wrote:
> On 28 Mar 2023, at 00:45, Alan Somers wrote:
> > On Mon, Mar 27, 2023 at 4:39???PM Konstantin Belousov wrote:
> >> commit 61194e9852e641d1533cd04a5679d6042ff975d3
> >>
> >>=C2=A0 Add kqueue1() syscall
> >>
> >>=C2=A0 It takes the flags argument.=C2=A0 Immediate use is to = provide the
> >>=C2=A0 KQUEUE_CLOEXEC flag for kqueue(2).
> >>
> >>=C2=A0 Differential revision:=C2=A0 https:= //reviews.freebsd.org/D39271
> >
> > We already have abort2(2), dup2(2), pipe2(2), and thr_kill2(2) th= at
> > are similar to other syscalls but with a flags argument.
> > Additionally, Linux has a renameat(2).=C2=A0 But I'm not awar= e of any
> > syscalls named xxx1.=C2=A0 Should we call this new one kqueue2 to= follow
> > the existing convention?
>
> This was discussed on the linked review.

I'm with Alan here, all needed knownledge (results of discussions)
should be part of the commit log, making commit itself sufficiently
understandable and judgeable.

But this is the existing convention..=C2=A0 an= d has been for decades since like wait4 or earlier.=C2=A0 At best it is bor= derline information...

W= arner
--0000000000007ddd3905f7f0a251--