From nobody Tue Mar 14 07:46:03 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PbQZL2J6Fz3xsvx for ; Tue, 14 Mar 2023 07:46:18 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PbQZK2lzGz4Qj7; Tue, 14 Mar 2023 07:46:17 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1678779969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8AhJl0NQXwETiC0eBd/hBNCdfmqbKOiHnE3HyaoI6Rs=; b=ixn2N1ewfqc33m8+UljM+G/7tZ4Z8fCVZWQD1UUsLvWmfiUjdwApW0BRcEgy9bQ5a4TU0i t5VpKtDK2NLzXWSz1t+YPZmpkkP1A0lemLoyZDZZWgSHU3BWrJgTNgieP0HfbUnievouxS mAzQeTPsyvzAzkxmaUZ6JeckF0IRZoo= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 59800dea (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 14 Mar 2023 07:46:08 +0000 (UTC) Date: Tue, 14 Mar 2023 08:46:03 +0100 From: Emmanuel Vadot To: Jessica Clarke Cc: Wei Hu , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" Subject: Re: git: 15e7fa83ef3c - main - arm64: Hyper-V: Add vPCI and Mellanox driver modules into build Message-Id: <20230314084603.de49c42bc92ad1b20d38b372@bidouilliste.com> In-Reply-To: References: <202303130300.32D30Q0K068420@gitrepo.freebsd.org> <4F72E2FD-6E84-40F1-981D-A18C8DE22FDD@freebsd.org> <3D6476D5-807E-4D9A-87BC-F5916FBEBE5B@freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4PbQZK2lzGz4Qj7 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Tue, 14 Mar 2023 06:59:00 +0000 Jessica Clarke wrote: > On 14 Mar 2023, at 06:56, Wei Hu wrote: > >=20 > >>>>>> + > >>>>>> +options COMPAT_LINUXKPI > >>>>>> +device xz > >>>>>> + > >>>>>> +device mlx5 > >>>>>> +device mlxfw > >>>>>> +device mlx5en > >>>>>> +options RATELIMIT > >>=20 > >> As pointed out on IRC, no other kernel config, aside from LINT ones, e= nables > >> this. Therefore this seems pretty dubious to add; why does > >> arm64 need it whilst amd64, which does include Mellanox drivers in its > >> GENERIC, doesn't need it? > >>=20 > >=20 > > How about moving these to std.nvidia? Does it look better to you? >=20 > They?re not part of an Nvidia SoC. >=20 > Anyway, I already moved them to a new std.azure. >=20 > Jess >=20 Why do we need them in GENERIC anyway ? We have modules already built, we have devmatch, if mlx driver don't autoload we should just fix that. --=20 Emmanuel Vadot