Re: git: 56f3f2d2491e - main - libsecureboot: avoid set but not used errors
- In reply to: Rob Wing : "Re: git: 56f3f2d2491e - main - libsecureboot: avoid set but not used errors"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 30 Jun 2023 22:40:42 UTC
Rob Wing <rob.fx907@gmail.com> wrote:
> + if (!cn.status) {
> buf = NULL;
> + if (err == 0) /* keep compiler happy */
> + buf = NULL;
> + }
> return (buf);
> }
>
> And considering the comment at contrib/bearssl/inc/bearssl_x509.h
> is it intended for buf to be returned as-is (i.e., not set to NULL)
> when the decoding status indicates an error condition?
Good question, probably not, will fix.
Thanks for spotting.