Re: git: 9d5a47e13c17 - main - ossl: Provide a fallback definition of __uint128_t when needed

Hi

I see some duplication here; in sys/dev/random/uint128.h I solved the same problem, except I needed some very basic functionality as well. Maybe we combine these two somehow?

M
--
Mark R V Murray



> On 4 Jun 2023, at 17:39, Mark Johnston <markj@FreeBSD.org> wrote:
> 
> The branch main has been updated by markj:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=9d5a47e13c175adf7486956847c3d060fe059f2c
> 
> commit 9d5a47e13c175adf7486956847c3d060fe059f2c
> Author:     Mark Johnston <markj@FreeBSD.org>
> AuthorDate: 2023-06-02 22:18:05 +0000
> Commit:     Mark Johnston <markj@FreeBSD.org>
> CommitDate: 2023-06-04 16:39:44 +0000
> 
>    ossl: Provide a fallback definition of __uint128_t when needed
> 
>    This is required on i386.  The patch has no functional change, since
>    AES-GCM isn't implemented for that platform.
> 
>    Fixes:  9a3444d91c70 ("ossl: Add a VAES-based AES-GCM implementation for amd64")
>    Reported by:    Jenkins
> ---
> sys/crypto/openssl/ossl_aes_gcm.h | 4 ++++
> 1 file changed, 4 insertions(+)
> 
> diff --git a/sys/crypto/openssl/ossl_aes_gcm.h b/sys/crypto/openssl/ossl_aes_gcm.h
> index 9ce8ee193483..cd0c1e324354 100644
> --- a/sys/crypto/openssl/ossl_aes_gcm.h
> +++ b/sys/crypto/openssl/ossl_aes_gcm.h
> @@ -49,6 +49,10 @@ struct ossl_aes_gcm_ops {
> 	    size_t len);
> };
> 
> +#ifndef __SIZEOF_INT128__
> +typedef	struct { uint64_t v[2]; } __uint128_t;
> +#endif
> +
> struct ossl_gcm_context {
> 	struct {
> 		union {
> 



--
Mark R V Murray