From nobody Fri Jan 27 20:03:40 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P3T6f1StNz3bxCf for ; Fri, 27 Jan 2023 20:03:54 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P3T6d6KZzz4FQl for ; Fri, 27 Jan 2023 20:03:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x636.google.com with SMTP id ss4so16579633ejb.11 for ; Fri, 27 Jan 2023 12:03:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0Z9L5qIvfNts7TmtSAzcKj/xBpqDWafRMYTbVu/BpDE=; b=rc3zs0Y/LvVxYuEywipFLqwHveEBbL6Z90oSgdEhkLOMCTkwGYcfQ52W69QbQNUKOX 64ssngzHOFlYwDdZUCnQKuIyuV9burbdsGM8dPaD5/+rra1TXqL+K847tzRPen1yjY+z yw3E0faRtJvcL+WLIdWRDh+x7QoZKcErXP7GhJHAH0s7+0ipg0AOmMaG6+Ixp0yWtuQ7 6V8+NYSPq3cMi7pyAE8mMeto+k6R5IcOihSkNgnyu7Ifal4DWXZkMFavy9Ukd8UYM6+2 lL4QUwURg//MzJezVeO0ZZh18u+Hzc1j7azSOOwqORc4sTp5rCaIBk2MXfTS/soXLroc huaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0Z9L5qIvfNts7TmtSAzcKj/xBpqDWafRMYTbVu/BpDE=; b=oATahcJnbicMCR2hboLQbxXurNVnlk7byL2aJO2OyiFSddEX4Il6PbW6uyXVz6r6GF QHDEFwjtB5VQuHfLehwostp8lRkW4vTKunEC8SovM8/q3UClf7gu9lKYe+Tmxhm+JLBr lCOJuk5pdM6Hj9QDx/zwl54RYYgNt7cVqHpWlF7g18JqObpwRah6yysBI8/sSzh3urVB VmaYNoxTH7DcFGBLss6oBH6Rx9YploxNfBzrGOlucdQsLLiBBfv7uFM4cBZvTi+uaBDN SvrbMqJN78D7Y+SGu6FbEU7+jCwVz5MJD18HGqDgFfl9i7+5czWSK5tBW+Ipj2j3gJ/B oz8w== X-Gm-Message-State: AO0yUKX7NBD+lCkhQIpzlm3chNLbK139dD2gLPygQ0lDG/zXbXv/3QbO 6Te7zXRj0gPodcyViuE0qSV7m+4uuugW1XvB5d3dSOTlHmWJLQ== X-Google-Smtp-Source: AMrXdXslfGfgDW0O9WDNhoQ2vhs6yGO1msnws8ZCbaOrQBO6QAIm+GqsJqVtCtT5zfR5zV1dqw5XbqTQFF5sM7hUqeI= X-Received: by 2002:a17:906:3042:b0:877:ec5e:87ce with SMTP id d2-20020a170906304200b00877ec5e87cemr3506320ejd.262.1674849831915; Fri, 27 Jan 2023 12:03:51 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202301232027.30NKRckV060051@gitrepo.freebsd.org> <1o40rq5-n1pr-ss27-q14-qo845q26398@mnoonqbm.arg> In-Reply-To: From: Warner Losh Date: Fri, 27 Jan 2023 13:03:40 -0700 Message-ID: Subject: Re: git: 247e03ed8b83 - main - Add git-blame ignore file To: Ed Maste Cc: "Bjoern A. Zeeb" , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000048a3e805f3445d5e" X-Rspamd-Queue-Id: 4P3T6d6KZzz4FQl X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --00000000000048a3e805f3445d5e Content-Type: text/plain; charset="UTF-8" On Fri, Jan 27, 2023, 12:59 PM Ed Maste wrote: > On Fri, 27 Jan 2023 at 10:24, Bjoern A. Zeeb wrote: > > > > On Mon, 23 Jan 2023, Ed Maste wrote: > > > > > The branch main has been updated by emaste: > > > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=247e03ed8b8341cf25dc3d9ecb846612d984f424 > > > > > > commit 247e03ed8b8341cf25dc3d9ecb846612d984f424 > > > Author: Ed Maste > > > AuthorDate: 2023-01-23 20:27:25 +0000 > > > Commit: Ed Maste > > > CommitDate: 2023-01-23 20:27:25 +0000 > > > > > > Add git-blame ignore file > > > > > > .git-blame-ignore-revs lists commit hashes that should be skipped by > > > `git blame` e.g. non-functional whitespace or style cleanup. > > > > > > The file is populated with a few sample entries. > > > > How is this file to be used? > > > > 1. Do a non-functional commit? > > 2. And then do another commit to add the hash? > > Yes, although there's no need to list every non-functional change > here. It's useful mainly for changes that would otherwise obscure the > history/blame - for example, re-indenting libexec/rtld-elf/rtld.c to > use standard indentation would be a good use. > > We could omit the comments, but I don't think it's worth the effort to > try to automate this. > Yea, we need a hash to put in the file which suggests that at most we could do automatically is add a new commit at the end of the push... and that's going to cause extra friction if we do it too much. And if we do it rarely, there's little benefit to automation. And reformatting is very rare.... Warner > --00000000000048a3e805f3445d5e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, Jan 27, 2023, 12:59 PM Ed Maste <emaste@freebsd.org> wrote:
On Fri, 27 Jan 2023 at 10:24, Bjoern A. Zeeb <= ;bz@= freebsd.org> wrote:
>
> On Mon, 23 Jan 2023, Ed Maste wrote:
>
> > The branch main has been updated by emaste:
> >
> > URL: https://cgit.FreeBSD.org/src/commit/?id=3D247e03ed8b8341cf25dc3d9ec= b846612d984f424
> >
> > commit 247e03ed8b8341cf25dc3d9ecb846612d984f424
> > Author:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org> > > AuthorDate: 2023-01-23 20:27:25 +0000
> > Commit:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org> > > CommitDate: 2023-01-23 20:27:25 +0000
> >
> >=C2=A0 =C2=A0 Add git-blame ignore file
> >
> >=C2=A0 =C2=A0 .git-blame-ignore-revs lists commit hashes that shou= ld be skipped by
> >=C2=A0 =C2=A0 `git blame` e.g. non-functional whitespace or style = cleanup.
> >
> >=C2=A0 =C2=A0 The file is populated with a few sample entries.
>
> How is this file to be used?
>
> 1. Do a non-functional commit?
> 2. And then do another commit to add the hash?

Yes, although there's no need to list every non-functional change
here. It's useful mainly for changes that would otherwise obscure the history/blame - for example, re-indenting libexec/rtld-elf/rtld.c to
use standard indentation would be a good use.

We could omit the comments, but I don't think it's worth the effort= to
try to automate this.

Yea, we need a hash to put in the file which suggests = that at most we could do automatically is add a new commit at the end of th= e push... and that's going to cause extra friction if we do it too much= . And if we do it rarely, there's little benefit to automation. And ref= ormatting is very rare....

Warner
--00000000000048a3e805f3445d5e--