From nobody Fri Jan 27 13:49:27 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P3Jpv5SBHz3c0bt; Fri, 27 Jan 2023 13:49:43 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE Root Certificate Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P3Jpt3Djjz4P7F; Fri, 27 Jan 2023 13:49:42 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of bzeeb-lists@lists.zabbadoz.net designates 2a01:4f8:13b:39f::9f:25 as permitted sender) smtp.mailfrom=bzeeb-lists@lists.zabbadoz.net; dmarc=none Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id C20998D4A142; Fri, 27 Jan 2023 13:49:32 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id ED4F65C3A833; Fri, 27 Jan 2023 13:49:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id jHmEtBAK3qxI; Fri, 27 Jan 2023 13:49:29 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:b66b:fcff:fef3:e3d2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id B525A5C3A830; Fri, 27 Jan 2023 13:49:28 +0000 (UTC) Date: Fri, 27 Jan 2023 13:49:27 +0000 (UTC) From: "Bjoern A. Zeeb" To: Kirk McKusick cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 906c312bbf74 - main - Document the mntopts(3) functions. In-Reply-To: <202301151821.30FILnsY011391@gitrepo.freebsd.org> Message-ID: <9126pq56-345-1r1n-4o93-89nq26p6p07n@mnoonqbm.arg> References: <202301151821.30FILnsY011391@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spamd-Result: default: False [-3.11 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.81)[-0.810]; R_SPF_ALLOW(-0.20)[+ip6:2a01:4f8:13b:39f::9f:25:c]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-main@FreeBSD.org]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DMARC_NA(0.00)[zabbadoz.net]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE]; RCVD_COUNT_FIVE(0.00)[5]; RCPT_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; RCVD_TLS_LAST(0.00)[] X-Rspamd-Queue-Id: 4P3Jpt3Djjz4P7F X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N On Sun, 15 Jan 2023, Kirk McKusick wrote: Hi Kirk, > The branch main has been updated by mckusick: > > URL: https://cgit.FreeBSD.org/src/commit/?id=906c312bbf7493ccbcce883936d67e5c66a9c3c2 > > commit 906c312bbf7493ccbcce883936d67e5c66a9c3c2 > Author: Kirk McKusick > AuthorDate: 2023-01-15 18:20:48 +0000 > Commit: Kirk McKusick > CommitDate: 2023-01-15 18:21:31 +0000 > > Document the mntopts(3) functions. > > The mntopts(3) functions support operations associated with a mount > point. The main purpose of this commit is to document the mntopts(3) > functions that now appear in 18 utilities in the base system. See > mntopts(3) for the documentation details. > > The getmntopts() function appeared in 4.4BSD. The build_iovec(), > build_iovec_argf(), free_iovec(), checkpath(), and rmslashes() > functions were added with nmount(8) in FreeBSD 5.0. The getmntpoint() > and chkdoreload() functions are being added in this commit. > > These functions should be in a library but for historic reasons are > in a file in the sources for the mount(8) program. Thus, to access > them the following lines need to be added to the Makefile of the > program wanting to use them: > > SRCS+= getmntopts.c > MOUNT= ${SRCTOP}/sbin/mount > CFLAGS+= -I${MOUNT} > .PATH: ${MOUNT} > > Once these changes have been MFC'ed to 13 they may be made into > a library. > > Reviewed by: kib, gbe > MFC after: 2 weeks > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D37907 Could this change be the cause for (I'll try to back it out and the follow-up to see but it'll be a few hours...) https://lists.freebsd.org/archives/freebsd-fs/2023-January/001789.html > --- > sbin/fsck/Makefile | 4 + > sbin/fsck/fsck.c | 5 +- > sbin/fsck/fsutil.c | 44 ------ > sbin/fsck/fsutil.h | 1 - > sbin/fsck_ffs/main.c | 96 +----------- > sbin/growfs/growfs.c | 110 ++------------ > sbin/mount/Makefile | 11 +- > sbin/mount/getmntopts.3 | 181 ----------------------- > sbin/mount/getmntopts.c | 95 +++++++++++- > sbin/mount/mntopts.3 | 381 ++++++++++++++++++++++++++++++++++++++++++++++++ > sbin/mount/mntopts.h | 2 + > sbin/mount/mount.c | 18 +-- > sbin/tunefs/tunefs.c | 33 +---- > 13 files changed, 513 insertions(+), 468 deletions(-) -- Bjoern A. Zeeb r15:7