git: 1bd78b3302c8 - stable/13 - stand: Stop setting hints for bios loader too

From: Warner Losh <imp_at_FreeBSD.org>
Date: Tue, 24 Jan 2023 22:12:15 UTC
The branch stable/13 has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=1bd78b3302c8a615b793c9c644ff167344ae8d23

commit 1bd78b3302c8a615b793c9c644ff167344ae8d23
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2022-09-01 16:33:09 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2023-01-24 21:49:32 +0000

    stand: Stop setting hints for bios loader too
    
    Catch up to 2753bbe71b5a and remove the old hints.
    
    Sponsored by:           Netflix
    
    (cherry picked from commit b1819983e70f5b8890404b7e07d17888d0cccfb6)
---
 stand/i386/libi386/biosacpi.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/stand/i386/libi386/biosacpi.c b/stand/i386/libi386/biosacpi.c
index 236c3fc45e7b..3bda472f3fc6 100644
--- a/stand/i386/libi386/biosacpi.c
+++ b/stand/i386/libi386/biosacpi.c
@@ -63,36 +63,24 @@ biosacpi_detect(void)
     /*
      * Report the RSDP to the kernel. While this can be found with
      * a BIOS boot, the RSDP may be elsewhere when booted from UEFI.
-     * The old code used the 'hints' method to communite this to
-     * the kernel. However, while convenient, the 'hints' method
-     * is fragile and does not work when static hints are compiled
-     * into the kernel. Instead, move to setting different tunables
-     * that start with acpi. The old 'hints' can be removed before
-     * we branch for FreeBSD 12.
      */
     sprintf(buf, "0x%08x", VTOP(rsdp));
-    setenv("hint.acpi.0.rsdp", buf, 1);
     setenv("acpi.rsdp", buf, 1);
     revision = rsdp->Revision;
     if (revision == 0)
 	revision = 1;
     sprintf(buf, "%d", revision);
-    setenv("hint.acpi.0.revision", buf, 1);
     setenv("acpi.revision", buf, 1);
     strncpy(buf, rsdp->OemId, sizeof(rsdp->OemId));
     buf[sizeof(rsdp->OemId)] = '\0';
-    setenv("hint.acpi.0.oem", buf, 1);
     setenv("acpi.oem", buf, 1);
     sprintf(buf, "0x%08x", rsdp->RsdtPhysicalAddress);
-    setenv("hint.acpi.0.rsdt", buf, 1);
     setenv("acpi.rsdt", buf, 1);
     if (revision >= 2) {
 	/* XXX extended checksum? */
 	sprintf(buf, "0x%016llx", rsdp->XsdtPhysicalAddress);
-	setenv("hint.acpi.0.xsdt", buf, 1);
 	setenv("acpi.xsdt", buf, 1);
 	sprintf(buf, "%d", rsdp->Length);
-	setenv("hint.acpi.0.xsdt_length", buf, 1);
 	setenv("acpi.xsdt_length", buf, 1);
     }
 }