From nobody Wed Feb 08 18:15:19 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PBp7r006Kz3nl3D; Wed, 8 Feb 2023 18:15:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PBp7q5sZBz3qbR; Wed, 8 Feb 2023 18:15:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675880119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RiNy3JLgd00RwV1l2hjY3wvFuYZ0uID0pCLJNunU2EI=; b=JDT9rFP9Hq/CC8kGXUcfYKsVaiSZBe7zSfHXyTjCt6ZuPvJu6i/xIDcx2iI2w7u2hJF1oj 9aJclfPwPChRxavX4rqzMwjbmg9+Fbypusq19TNWpzpD4+mnMGoiyka3ekT7gt5qwwIcS/ 2r/HfyrQONQqOumBeTm+zYOVumV9rOmN/vVwYDafBf+fVvF4zrDDVc/n9N/2lw6SUTnJ39 YCC/El2laEiqx9jOOKyI1PYXOUa6I1B1HctzK/4AhS6cm03sZLLmpZFQErL+63G6EqOUAb 3PK+kOVeftsSRc6BOfbo7n5GYU6SkgQ3V+4x23fBbwuP7mFV7ZB5fzZgT0Wa7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675880119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RiNy3JLgd00RwV1l2hjY3wvFuYZ0uID0pCLJNunU2EI=; b=tWsPybAsf6zsDblzibndd4blAqbrXny3NvgmWFrjzaHOTebwIG4jNbZU9SjUX3oCOqVANf jKydO76mEh+/QeEW6+WjKLm7Rr3LE+Zcf9yNmh10kDVTpvMDm+/W5vwFAJq0kQETiMkl0R Jh1LKdAub5IBjbBtNkkKemRFJFXftc3mxbYtRk1/bQozZ8mSWSmSbQ8zaVCXCOQapfoJee xxYUFrIt1Bh4RBrZiwsy9aoiHB7dufapOocN1ivZaVVU6GRQFRmy0sF2iMuhywSCQMBYot jI0NvkfR5gJHblpxJyABG+0g+yZYpqzewHImfX/TrveGQVmvnIK92Gy0g4+TYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675880119; a=rsa-sha256; cv=none; b=yo/pFDD3OEf45ka8JOgnBm4E63395MBX9WGKk0///NBLkGJrcfaJz6pod2ZkqMzg8F7fWr FX88BL+4gAePgkxeE7A95Re/Hx+G3/B+CZXhA0mLOkpO9CHY3RExdDa9wJEPLyVoM9XIKq W6d5iFkawPKGEUDh0DX5XeXSJUxMLWxY6PzBN8z7q6LMIuBbBlb5jFuLGQJSUq5ITPbav9 czagxb4ZeRaYBy33FcSPzdiKmiqYEAQ/aSWsHyDAPPZplAJbD/yjC9sk0eAsLE573z9yXx B2D3zoFrHdTFO9kzHdHcS5NxlvTjsVyM1xj68nVdNXTz5Jba4XTyNN/+kgFxLw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PBp7q4tTgz1664; Wed, 8 Feb 2023 18:15:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 318IFJNC022340; Wed, 8 Feb 2023 18:15:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 318IFJFL022339; Wed, 8 Feb 2023 18:15:19 GMT (envelope-from git) Date: Wed, 8 Feb 2023 18:15:19 GMT Message-Id: <202302081815.318IFJFL022339@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Gordon Tetlow Subject: git: f3e20eb8d8f0 - releng/13.1 - ixgbe: workaround errata about UDP frames with zero checksum List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gordon X-Git-Repository: src X-Git-Refname: refs/heads/releng/13.1 X-Git-Reftype: branch X-Git-Commit: f3e20eb8d8f0b87ae828741c48e9ebd7913086ac Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch releng/13.1 has been updated by gordon: URL: https://cgit.FreeBSD.org/src/commit/?id=f3e20eb8d8f0b87ae828741c48e9ebd7913086ac commit f3e20eb8d8f0b87ae828741c48e9ebd7913086ac Author: Andrey V. Elsukov AuthorDate: 2022-11-10 09:34:40 +0000 Commit: Gordon Tetlow CommitDate: 2023-02-08 16:30:38 +0000 ixgbe: workaround errata about UDP frames with zero checksum Intel 82599 has errata related to IPv4 UDP frames with zero checksum. It reports such datagrams with L4 integrity errors in IXGBE_XEC register. And after afb1aa4e6df2 commit such errors are reported via IFCOUNTER_IERRORS. This confuses users, since actually all frames are handled correctly by the system. To workaround the problem, let's ignore the XEC register value for 82599 cards for now. PR: 266048 Discussed with: erj Sponsored by: Yandex LLC Approved by: so Security: FreeBSD-EN-23:04.ixgbe (cherry picked from commit 8526120ad41ca47367b43f8f4459e0fa61285571) (cherry picked from commit daf3d88ac1849c9a6c5f05d2a663c7fe57453b37) --- sys/dev/ixgbe/if_ix.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index 3077fc9ac4f8..abfdc1f5ba60 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -1585,8 +1585,12 @@ ixgbe_update_stats_counters(struct ixgbe_softc *sc) * - fragmented packets count, * - oversized packets count, * - jabber count. + * + * Ignore XEC errors for 82599 to workaround errata about + * UDP frames with zero checksum. */ - IXGBE_SET_IERRORS(sc, stats->crcerrs + stats->illerrc + stats->xec + + IXGBE_SET_IERRORS(sc, stats->crcerrs + stats->illerrc + + (hw->mac.type != ixgbe_mac_82599EB ? stats->xec : 0) + stats->mpc[0] + stats->rlec + stats->ruc + stats->rfc + stats->roc + stats->rjc); } /* ixgbe_update_stats_counters */