From nobody Fri Dec 29 10:17:21 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T1hBq26Vtz55nWt; Fri, 29 Dec 2023 10:17:23 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T1hBq0MQ2z3DH3; Fri, 29 Dec 2023 10:17:23 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703845043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d/+yKCgsBhhsOx1DLTHbu9hAwMZ/vkln3z9HHgl1bF4=; b=WkFdcRBKeHB23duafZh8fdRvhwcmQSt7SKL5CF+Fd5ymzll/H5Abjwy/y/sTf0WfxNXfmv eUz8JKPUpRIafxFSzSY5kWnaPAoIcXwyntxI4H88Cam38NIltFCfCOm6deofpy7XsUZ0J8 IP1/sjCNAPPGcTgkIeGMwVkT71c89fZC2GHq1VYdpzoA3GYjcYkPbklp3aro14cnLQxRcx u8rP87NDUTSqcAN129ng71YqG5ufgKe7jNDjPFdE0QLXgOF5Yg6okMsOPuNw5TcTRiJouI 7PuwLOhB6Isvw3EEsvsZH64b80Qha8seYOSTwB0qkYF4oDIglkmLb3ezezaTUQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703845043; a=rsa-sha256; cv=none; b=g25kYIWlFThhUWCTD5ksd67i1/jcR9yl+DnHaz42Sm/2lwIaGNoCOIZwtn79N1LQ/zy71u CntP3Xn7TPnS6BiXd/vHwsMS5cQktB4v8PVMIEJG0c8YLYQZJvmeCIGCewwt9ycyPRkO64 w0yFICz5bT6cSKgCqapIBc8vGverghzbnfv43ir9GQVh7Z4xykA/a/evucNl0jinmZpylN eFyQcwIzToywuw6ReNLWeygbnilFrVDqBEn4nO7eO0RFXs0YsAzRMD54Y9I/foS9780/81 JxcGZ9bro8/mIgVTbV+N1xDl6rg16MDDD0fgDRr+7oupIX473e1UDaLV8HWIow== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703845043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d/+yKCgsBhhsOx1DLTHbu9hAwMZ/vkln3z9HHgl1bF4=; b=GKu4/Mw808rzRbFToMLGVxQbcPif00x2crDrgyYBmOhUgWQtRF4l7z7NKM2QK6MC3pUF6q kxnpqh9r/YUzCIslUe89Fog2Ueki9YU6RVkFnFYZZuViYVpHCNoLtYWfCMwlnWIl/4VU5L lSzT4Yn4QzUu5TpuDkJ/k5SBgCOYcYYwUCNjfIj3LU19aOqbxREvj5cqCciOYP0AYkCiLV 9KvstVELN4oAz1tfTaW14MFn0QH1T1h9Ogoy72NKG0mgBvb08uAshkIKnmptXpBhkT09to b+ekqWAu+1HXinYfa7mW83t30STnX3tknlV+Fh+sVy5nGhxpZ505HDe2BHWAiQ== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4T1hBp5vcbzwBM; Fri, 29 Dec 2023 10:17:22 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id B695C42A35; Fri, 29 Dec 2023 11:17:21 +0100 (CET) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: git: a8b70cf26030 - main - netpfil: Use accessor functions and named constants for all tcphdr flags From: Dimitry Andric In-Reply-To: Date: Fri, 29 Dec 2023 11:17:21 +0100 Cc: Gleb Smirnoff , Richard Scheffenegger , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <24134FF7-8C03-490D-A476-4EFF4EAD8132@FreeBSD.org> References: <202312270143.3BR1hMQf085312@gitrepo.freebsd.org> To: Antoine Brodin X-Mailer: Apple Mail (2.3731.700.6) On 29 Dec 2023, at 08:35, Antoine Brodin wrote: >=20 > On Thu, Dec 28, 2023 at 10:37=E2=80=AFPM Gleb Smirnoff = wrote: >>=20 >> Antoine, >>=20 >> On Thu, Dec 28, 2023 at 08:48:36PM +0000, Antoine Brodin wrote: >> A> > netpfil: Use accessor functions and named constants for all = tcphdr flags >> A> > >> ... >> A> This breaks some ports: >> A> /usr/include/netinet/tcp.h:82:8: error: unknown type name 'inline' >>=20 >> Definitely some ports that use some strange compilers :) >>=20 >> Can you please give at least port names? >=20 > Some examples: >=20 > = https://pkg-status.freebsd.org/gohan04/data/mainamd64PR275986-default-foo/= 2023-12-28_20h35m41s/logs/errors/nspr-4.35.log > = https://pkg-status.freebsd.org/gohan04/data/mainamd64PR275986-default-foo/= 2023-12-28_20h35m41s/logs/errors/opusfile-0.12_1.log The culprit is likely the "-ansi" option. Just get rid of that, it is = not really useful: cc -o prmapopt.o -c -fvisibility=3Dhidden -O2 -pipe = -fstack-protector-strong -fno-strict-aliasing -ansi -Wall -fPIC -UDEBUG = -DPACKAGE_NAME=3D\"\" -DPACKAGE_TARNAME=3D\"\" -DPACKAGE_VERSION=3D\"\" = -DPACKAGE_STRING=3D\"\" -DPACKAGE_BUGREPORT=3D\"\" -DPACKAGE_URL=3D\"\" = -DNDEBUG=3D1 -DHAVE_VISIBILITY_HIDDEN_ATTRIBUTE=3D1 = -DHAVE_VISIBILITY_PRAGMA=3D1 -DXP_UNIX=3D1 -DFREEBSD=3D1 = -DHAVE_BSD_FLOCK=3D1 -DHAVE_SOCKLEN_T=3D1 -DHAVE_POINTER_LOCALTIME_R=3D1 = -DHAVE_DLADDR=3D1 -DHAVE_LCHOWN=3D1 -DHAVE_SETPRIORITY=3D1 = -DHAVE_STRERROR=3D1 -DHAVE_SYSCALL=3D1 -DHAVE_SECURE_GETENV=3D1 = -D_REENTRANT=3D1 -D_THREAD_SAFE=3D1 -DFORCE_PR_LOG -D_PR_PTHREADS = -UHAVE_CVAR_BUILT_ON_SEM -D_NSPR_BUILD_ -I../../../dist/include/nspr = -I../../../pr/include -I../../../pr/include/private prmapopt.c In file included from prmapopt.c:46: In file included from prmapopt.c:46: /usr/include/netinet/tcp.h:82:8: error: unknown type name 'inline' 82 | static inline uint16_t | ^ -Dimitry