From nobody Thu Dec 28 22:36:52 2023
X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T1Nfh530fz54nkD;
	Thu, 28 Dec 2023 22:37:00 +0000 (UTC)
	(envelope-from glebius@freebsd.org)
Received: from glebi.us (glebi.us [162.251.186.162])
	by mx1.freebsd.org (Postfix) with ESMTP id 4T1Nfh2f8Mz3GH8;
	Thu, 28 Dec 2023 22:37:00 +0000 (UTC)
	(envelope-from glebius@freebsd.org)
Authentication-Results: mx1.freebsd.org;
	none
Received: by glebi.us (Postfix, from userid 1000)
	id EFD4C6A157; Thu, 28 Dec 2023 14:36:52 -0800 (PST)
Date: Thu, 28 Dec 2023 14:36:52 -0800
From: Gleb Smirnoff <glebius@freebsd.org>
To: Antoine Brodin <antoine@freebsd.org>
Cc: Richard Scheffenegger <rscheff@freebsd.org>, src-committers@freebsd.org,
	dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject: Re: git: a8b70cf26030 - main - netpfil: Use accessor functions and
 named constants for all tcphdr flags
Message-ID: <ZY34hIExot089sPR@FreeBSD.org>
References: <202312270143.3BR1hMQf085312@gitrepo.freebsd.org>
 <CAALwa8n+Ss397icBLsYEPZM0ynnou=1Kxc5dV5FAa_CofjpT4A@mail.gmail.com>
List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all
List-Help: <mailto:dev-commits-src-all+help@freebsd.org>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-all+unsubscribe@freebsd.org>
Sender: owner-dev-commits-src-all@freebsd.org
X-BeenThere: dev-commits-src-all@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAALwa8n+Ss397icBLsYEPZM0ynnou=1Kxc5dV5FAa_CofjpT4A@mail.gmail.com>
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US]
X-Spamd-Bar: ----
X-Rspamd-Queue-Id: 4T1Nfh2f8Mz3GH8

  Antoine,

On Thu, Dec 28, 2023 at 08:48:36PM +0000, Antoine Brodin wrote:
A> >     netpfil: Use accessor functions and named constants for all tcphdr flags
A> >
...
A> This breaks some ports:
A> /usr/include/netinet/tcp.h:82:8: error: unknown type name 'inline'

Definitely some ports that use some strange compilers :)

Can you please give at least port names?

-- 
Gleb Smirnoff