From nobody Thu Dec 28 20:48:36 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T1LFs2xN0z54bkC; Thu, 28 Dec 2023 20:48:49 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com [209.85.222.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T1LFr4K11z4ZpN; Thu, 28 Dec 2023 20:48:48 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of antoine.brodin.freebsd@gmail.com designates 209.85.222.41 as permitted sender) smtp.mailfrom=antoine.brodin.freebsd@gmail.com; dmarc=none Received: by mail-ua1-f41.google.com with SMTP id a1e0cc1a2514c-7cc662fc2e6so595742241.0; Thu, 28 Dec 2023 12:48:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703796527; x=1704401327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PAXHA/nQIXUgclzPyWJ3ISWnID64LYa4X1m4twLZTMs=; b=vTf0nfV+2D6dvE6fFP9XuXSEAYFMvYWT12G7j3GJc0kxFJYUwvJc0BBu0eMPYPIsRH 3t6oMCj4f1L0qqZezzKXHcmrM9qYLfH/GMDuKloq4ND+tjAFzB0dkH9T5zuk0wAzVQnA beAweIQZtbwfwmGV53R+KAzQpf50im/D8uVB4enVYy6levq0xXG+E+iHF7aNUm4DvRDM yBQ2a76iJ3KFi3uTYTq/YCaFNex5p64Vz2fgJQC1OiLy96zApDDuikr2h1UtuMoxHo/v xSsdXAvuf4kfTak5gzLT2yXmOiyNZsna0bbVBIb4AS/StAjF2w3FC9l5Lag11G3lbcmu 7qxA== X-Gm-Message-State: AOJu0YxC3/bGG7apzDGiDxaj5LhAoY0nuIdRkfdUgB2XgTtwDSunphNj /t1CQBtxXHH/hgU5KYREQLH8B1O9yzS5yuZwKxX9K55mixM= X-Google-Smtp-Source: AGHT+IF0tleX5Ag1FCNFEYgfjrZRqm53LpXb217pBDKbVfVOdIWvAVVT8vPfyvhFyLh/czbmVmX8WjDTb8YkBJ11cHg= X-Received: by 2002:a05:6122:d07:b0:4b6:bf49:ea3b with SMTP id az7-20020a0561220d0700b004b6bf49ea3bmr2430742vkb.26.1703796527019; Thu, 28 Dec 2023 12:48:47 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202312270143.3BR1hMQf085312@gitrepo.freebsd.org> In-Reply-To: <202312270143.3BR1hMQf085312@gitrepo.freebsd.org> From: Antoine Brodin Date: Thu, 28 Dec 2023 20:48:36 +0000 Message-ID: Subject: Re: git: a8b70cf26030 - main - netpfil: Use accessor functions and named constants for all tcphdr flags To: Richard Scheffenegger Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.90 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.90)[-0.903]; FORGED_SENDER(0.30)[antoine@freebsd.org,antoinebrodinfreebsd@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_NONE(0.00)[209.85.222.41:from]; R_DKIM_NA(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.222.41:from]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCVD_COUNT_ONE(0.00)[1]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; TAGGED_FROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; FROM_NEQ_ENVFROM(0.00)[antoine@freebsd.org,antoinebrodinfreebsd@gmail.com] X-Rspamd-Queue-Id: 4T1LFr4K11z4ZpN X-Spamd-Bar: -- On Wed, Dec 27, 2023 at 1:43=E2=80=AFAM Richard Scheffenegger wrote: > > The branch main has been updated by rscheff: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3Da8b70cf26030d68631200619bd= 1b0ad35b34b6b8 > > commit a8b70cf26030d68631200619bd1b0ad35b34b6b8 > Author: Richard Scheffenegger > AuthorDate: 2023-12-25 11:26:25 +0000 > Commit: Richard Scheffenegger > CommitDate: 2023-12-25 12:18:01 +0000 > > netpfil: Use accessor functions and named constants for all tcphdr fl= ags > > Update all remaining references to the struct tcphdr th_x2 field. > This completes the compatibilty of various aspects with AccECN > (TH_AE), after the internal ipfw "re-checksum required" was moved > to use the TH_RES1 flag. > > No functional change. > > Reviewed By: tuexen, #transport, glebius > Sponsored by: NetApp, Inc. > Differential Revision: https://reviews.freebsd.org/D43172 Hello, This breaks some ports: /usr/include/netinet/tcp.h:82:8: error: unknown type name 'inline' Antoine