From nobody Sat Dec 23 19:30:55 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SyDmM0T51z54vJt; Sat, 23 Dec 2023 19:30:59 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SyDmL71MFz4FKQ; Sat, 23 Dec 2023 19:30:58 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703359859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J2FA3Nsxi9+TkKoDLBBjbPzTk0FfHOLFXTIwOf7BRbs=; b=JvSfAsE8qi7s8y9OlX+RqJ/At+RmOFE9AV++fg+MPAf7qaVIHgiS+50w7LCrT9DsybUjos mgq4tB21VXQ/9QPw3EB76BggV+WsFoMwESX0gs82K97BOj8hdBVPQncVfHLg9J0fYAujoR oOsx7A8G3FydB8wtZCFo5Mk5vjlZWGZO91Uc/UX3+YvCOKaatoAXMgW0oUvba/ScBH1CVJ R8s4lqpFmFvylfLrwT63vUNvQ/UZry/Bd22JF4fQDCJO8/eAFaK87z92SPK5scdivcBRxJ 5S0ur/s6jeLkBx/trfLZfqVC3PuFsnuEgW5sYJb199ScxTvesicWkRuxmgh54A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703359859; a=rsa-sha256; cv=none; b=cNeMvUjryRWVk6/a30zWlHckWOat6o9IRa3UGdof6Bpk12syB7hYBgFa1k2PO3eJL842sQ SZZzAvTz03Hh6k8AqgWfVLquUlqmHBOLtnQJPW2Azb/JUigpqyGlkW91Fmwxa9lq1CR54r 6D5SxbRmqnAp73KBRT9NKXpT0qFm5L9tP/+rEVvt1y5viS/z2TH8q7Drm4f0xpMAPjTVb7 RG5wsPoU2l05A/YT6hUbQsmRdSbC7uMj3qvNhIhaKi01o5mFevvHUnL2ylxYi/mhrwOeBW jEjg4GWrAfK007/p9aS8TgdL09cOl9+Xg+EAsD7fXwOAABkvIgo9RZJuZPJ2Iw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703359859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J2FA3Nsxi9+TkKoDLBBjbPzTk0FfHOLFXTIwOf7BRbs=; b=fpqOlOZqiXVq+V5OBBMNs9g966RTqRjnBz/hxgdxWBFWR4x5zXhjZYa+Sci8DN0YHqdN93 kn0wmEwFnDt3PBNWTbDfeSgupEs6KmwQPzPhcg1g86Gc3hIrRy8yb26Sd5Ie/NX5Z6tBvO Q37xS/vwy3Ip8cgLnjEVpOZN1xYYwI3h2vhlU6dj2sudzOk4UFE52Bn6S9RFvLTq55Z/nF N3dpXUTcq6mcd42a8JcG+wk84maFfaDuTMX7T+24yYEDDRfOHCxZvpuFkANfYT8V5P8lx8 bF20Mer2xrMrxpRoKZwCJAlwweZwbxxAA/+4BH3xPUh0tc1lmV/mG5Qd0IUZRg== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SyDmL4kBCz1Cgr; Sat, 23 Dec 2023 19:30:58 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 31D26170E6; Sat, 23 Dec 2023 20:30:56 +0100 (CET) From: Kristof Provost To: Brooks Davis , jrm@FreeBSD.org Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 8ccd0b876e67 - main - libc: expose execvpe for Linux compat Date: Sat, 23 Dec 2023 20:30:55 +0100 X-Mailer: MailMate (1.14r5937) Message-ID: In-Reply-To: <202312111927.3BBJRWon091352@gitrepo.freebsd.org> References: <202312111927.3BBJRWon091352@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_478E9E23-66C9-48D3-A14C-E8D94C1F5B89_=" --=_MailMate_478E9E23-66C9-48D3-A14C-E8D94C1F5B89_= Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Brooks, Joseph, On 11 Dec 2023, at 20:27, Brooks Davis wrote: > The branch main has been updated by brooks: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3D8ccd0b876e67fda6249f294ff4847= 98cc1e1569f > > commit 8ccd0b876e67fda6249f294ff484798cc1e1569f > Author: Brooks Davis > AuthorDate: 2023-12-11 19:24:53 +0000 > Commit: Brooks Davis > CommitDate: 2023-12-11 19:24:53 +0000 > > libc: expose execvpe for Linux compat > > We already implemented execvpe internally with an _ prefix in libc = > so > go ahead and expose it for compatibility with Linux. > > This reverts c605eea952146348e5e1ad5cab6c127d7a1bd164. > > Bump __FreeBSD_version for the addition and add definitions to = > supress > compat shims in libzfs (zfs changes were merged from upstream). > > PR: 275370 (request and exp-run (thanks antoine!)) > Reviewed by: kevans > Differential Revision: https://reviews.freebsd.org/D42846 I don=E2=80=99t understand why, but this breaks devel/bear (=E2=80=9CTool= that = generates a compilation database for clang tooling=E2=80=9D). Rather than generate a list of commands it seems to recursively spawn = endless =E2=80=9Cwrapper=E2=80=9D processes: ``` 82661 0 I+ 0:00.18 | | `-- bear -- ls 82662 0 I+ 0:06.90 | | `-- /usr/local/bin/bear intercept = --library /usr/local/lib/bear/libexec.so --wrapper = /usr/local/lib/bear/wrapper --wrapper-dir /usr/local/lib/bear/wr 82663 0 I+ 0:00.13 | | `-- /usr/local/lib/bear/wrapper = --destination dns:///localhost:30309 --execute /bin/ls -- ls 82664 0 I+ 0:00.09 | | `-- /usr/local/lib/bear/wrapper = --destination dns:///localhost:30309 --execute /bin/ls -- ls 82665 0 I+ 0:00.06 | | `-- = /usr/local/lib/bear/wrapper --destination dns:///localhost:30309 = --execute /bin/ls -- ls 82666 0 I+ 0:00.06 | | `-- = /usr/local/lib/bear/wrapper --destination dns:///localhost:30309 = --execute /bin/ls -- ls ``` It=E2=80=99s trivially reproducible at least. Without this patch `bear --= ls` = returns immediately and generates a compile_commands.json file (empty, = but that=E2=80=99s fine here). With it it=E2=80=99ll spin endlessly. Best regards, Kristof --=_MailMate_478E9E23-66C9-48D3-A14C-E8D94C1F5B89_= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Brooks, Joseph,

On 11 Dec 2023, at 20:27, Brooks Davis wrote:

The branch main has been updated by= brooks:

URL: https://cgit.FreeBSD.org/src/co= mmit/?id=3D8ccd0b876e67fda6249f294ff484798cc1e1569f

commit 8ccd0b876e67fda6249f294ff484798cc1e1569f
Author: Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2023-12-11 19:24:53 +0000
Commit: Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2023-12-11 19:24:53 +0000

libc: expose execvpe for Linux compat

We already implemented execvpe internally with an _ p= refix in libc so
go ahead and expose it for compatibility with Linux.

This reverts c605eea952146348e5e1ad5cab6c127d7a1bd164= =2E

Bump __FreeBSD_version for the addition and add defin= itions to supress
compat shims in libzfs (zfs changes were merged from upstream).

PR: 275370 (request and exp-run (thanks a= ntoine!))
Reviewed by: kevans
Differential Revision: https://reviews.freebsd.org/D42846

I don=E2=80=99t understand why, but this breaks devel/bea= r (=E2=80=9CTool that generates a compilation database for clang tooling=E2= =80=9D).

Rather than generate a list of commands it seems to recur= sively spawn endless =E2=80=9Cwrapper=E2=80=9D processes:

82=
661  0  I+       0:00.18 | |     `-- bear -- ls
82662  0  I+       0:06.90 | |       `-- /usr/local/bin/bear intercept --=
library /usr/local/lib/bear/libexec.so --wrapper /usr/local/lib/bear/wrap=
per --wrapper-dir /usr/local/lib/bear/wr
82663  0  I+       0:00.13 | |         `-- /usr/local/lib/bear/wrapper --=
destination dns:///localhost:30309 --execute /bin/ls -- ls
82664  0  I+       0:00.09 | |           `-- /usr/local/lib/bear/wrapper =
--destination dns:///localhost:30309 --execute /bin/ls -- ls
82665  0  I+       0:00.06 | |             `-- /usr/local/lib/bear/wrappe=
r --destination dns:///localhost:30309 --execute /bin/ls -- ls
82666  0  I+       0:00.06 | |               `-- /usr/local/lib/bear/wrap=
per --destination dns:///localhost:30309 --execute /bin/ls -- ls

It=E2=80=99s trivially reproducible at least. Without thi= s patch bea= r -- ls returns immediately and generates a compile_commands.json = file (empty, but that=E2=80=99s fine here). With it it=E2=80=99ll spin en= dlessly.

Best regards,
Kristof

--=_MailMate_478E9E23-66C9-48D3-A14C-E8D94C1F5B89_=--