Re: git: 5c16e71d30c3 - main - Merge llvm-project release/17.x llvmorg-17.0.6-0-g6009708b4367

On 11 Dec 2023, at 19:10, Dima Panov <fluffy@freebsd.org> wrote:
> 
> On 11.12.2023 18:15, Dimitry Andric wrote:
>> On 11 Dec 2023, at 16:03, Kristof Provost <kp@FreeBSD.org> wrote:
>>> On 8 Dec 2023, at 18:39, Dimitry Andric wrote:
>>> 
>>>    The branch main has been updated by dim:
>>> 
>>>    URL: https://cgit.FreeBSD.org/src/commit/?id=5c16e71d30c388dd43b217de10a3ccb4b0219d0d <https://cgit.freebsd.org/src/commit/?id=5c16e71d30c388dd43b217de10a3ccb4b0219d0d>
>>> 
>>>    commit 5c16e71d30c388dd43b217de10a3ccb4b0219d0d
>>>    Merge: b121cb0095c8 703029dbba78
>>>    Author: Dimitry Andric <dim@FreeBSD.org>
>>>    AuthorDate: 2023-11-30 20:06:52 +0000
>>>    Commit: Dimitry Andric <dim@FreeBSD.org>
>>>    CommitDate: 2023-12-08 17:35:59 +0000
>>> 
>>>    Merge llvm-project release/17.x llvmorg-17.0.6-0-g6009708b4367
>>> 
>>>    This updates llvm, clang, compiler-rt, libc++, libunwind, lld, lldb and
>>>    openmp to llvmorg-17.0.6-0-g6009708b4367.
>>> 
>>>    PR: 273753
>>>    MFC after: 1 month
>>> 
>>> 
>>> There appears to be some fallout in some ports.
>> 
> [skip]
>> I fixed dozens of ports for this in https://bugs.freebsd.org/273753 <https://bugs.freebsd.org/273753>, but I haven't gone over all of them, since I have limited resources.
>> That said, there are generally two ways to fix this: either add -Wl,--undefined-version to the linker flags, or actually remove the undefined symbols from the linker version scripts.
> 
> BTW, lang/gcc13 fails to build on 15/aarch64 after this import with lots of
> 
> /usr/include/c++/v1/locale:3434:31: error: attempt to use a poisoned identifier
> 3434 |         __h.reset((char_type*)malloc(__exn * sizeof(char_type)));
>      |                               ^
> 
> 
> Full log: https://people.freebsd.org/~fluffy/-log/150aarch64/gcc13-13.2.0_1.log
> 
> 
> Just curious but gcc12 is fine now

I have seen this error too, but could only reproduce it outside of poudriere, so I didn't take it too seriously. It is easy to fix; I have a patch, shall I commit it? :)

-Dimitry