From nobody Mon Dec 11 15:03:09 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SplNx2rD2z53jH0; Mon, 11 Dec 2023 15:03:13 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SplNx2MMLz3gP5; Mon, 11 Dec 2023 15:03:13 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1702306993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5b96qI2AHSNC62t86ZKipdbqPQcUEM8MPKP46pKcIvE=; b=AZamCc073Mt5fX4jyJyed4cVmkAdAl+VmaVxlTahzyuYU41t3LCnPRm2MbS1V6Dwj0ZUIe kELsq+Pg4vbkuDQFHbngpEDTWceuwgYPEkY9pMVjcZajIc1tpcYIJry5S1fR3bGuyoozvU Mbruol6d9zpumvfWQ5DKc+6gxf8eTZxQCWV4OFF6ddm8cDa9eKk9o8AQbQBxzjsQIRL8U+ mpB2P2Nz6899Hhown6j8fPA2ElPpYNC4gVQvRsgSJ3v4S9DjVz1euIxKPvM/8dTn9VxomW QtM2K0BAxVkyshQP/WlJSSGOu02TnMDTTTfGZn6MiNC++dcmHPyWolKFzMzzZg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1702306993; a=rsa-sha256; cv=none; b=RMSXTzAM7uank0ULVtpI0Kg1ptFw7+MFftRgx1DYTFvqrW5CU26bESdgKOYlUUmzImrzNH 9lvbYr55g5mGwwk8plkvFI+OndnIjCpb+9rZSSK+CiORm/ir2ecQ7J1CY4wxIVy7Gn81Oa wS8MIoWkocM8JbTkpNc/+dyvBnhNn+XrXiAdhU2xdozJ57veMzySI+zFAQmz/rDH2kRpFO 9bWFO8tGJpX8ptVffp37blIudK+eIowqvoEbVblLY0IQUj8YPMBMAsB/QLQ1ZGx5p3bY/j 68O5y8o7u6tHT35i3535ywlnAhdOPt8BEweCswx425NlKozOAnDHpKBmLpyDjg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1702306993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5b96qI2AHSNC62t86ZKipdbqPQcUEM8MPKP46pKcIvE=; b=wR0ShoeKOlOyK4JVEOxBxGVJfL70KFRMYilQJYFNfCEdGDgMsHdEpCrjtvXL+JHSM/rSkQ lmzPmB1PVZNmbeTk8hl0zDBmVr/xtJqgD+95mzl6LcG0dkmSHOuKzXbYg63GfkUEWNPBdB 6f2bdiBAeATnGSVnaxn4RP4NPAQOF0hh10k/ua7o/NmFVhG23+DznzSTfThSSn/8gxWjzk TnpNKf6fONOEB2pp2Mu8X6J1Bpu8VLGqkluGTT/eGfR5wtCPXOkI9Cn5dEO0Yu2EO7ctKT 1Jpo8U/M3Zm1lWUDu+BcerMFpT4UNo2YACyJl8cwHtUBc8cSpkzRuGsbrp/y1w== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SplNx04W1z1YqQ; Mon, 11 Dec 2023 15:03:12 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 8A4721ECAE; Mon, 11 Dec 2023 16:03:10 +0100 (CET) From: Kristof Provost To: Dimitry Andric Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 5c16e71d30c3 - main - Merge llvm-project release/17.x llvmorg-17.0.6-0-g6009708b4367 Date: Mon, 11 Dec 2023 16:03:09 +0100 X-Mailer: MailMate (1.14r5937) Message-ID: In-Reply-To: <202312081739.3B8HdJYC068067@gitrepo.freebsd.org> References: <202312081739.3B8HdJYC068067@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_3A3E899A-1A08-45A1-8DA9-E72DA079425D_=" --=_MailMate_3A3E899A-1A08-45A1-8DA9-E72DA079425D_= Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 8 Dec 2023, at 18:39, Dimitry Andric wrote: > The branch main has been updated by dim: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3D5c16e71d30c388dd43b217de10a3c= cb4b0219d0d > > commit 5c16e71d30c388dd43b217de10a3ccb4b0219d0d > Merge: b121cb0095c8 703029dbba78 > Author: Dimitry Andric > AuthorDate: 2023-11-30 20:06:52 +0000 > Commit: Dimitry Andric > CommitDate: 2023-12-08 17:35:59 +0000 > > Merge llvm-project release/17.x llvmorg-17.0.6-0-g6009708b4367 > > This updates llvm, clang, compiler-rt, libc++, libunwind, lld, = > lldb and > openmp to llvmorg-17.0.6-0-g6009708b4367. > > PR: 273753 > MFC after: 1 month > There appears to be some fallout in some ports. For example, devel/ivykis (but also sysutils/flashrom and = databases/rrdtool) fails like this: /bin/sh ../libtool --tag=3DCC --mode=3Dlink cc -O2 -pipe = -fstack-protector-strong -fno-strict-aliasing -Wall -version-info = 5:6:5 -Wl,--version-script,../libivykis.posix.ver = -fstack-protector-strong -o libivykis.la -rpath /usr/local/lib iv_avl.lo = iv_event.lo iv_fatal.lo iv_task.lo iv_timer.lo iv_tls.lo iv_work.lo = iv_event_raw_posix.lo iv_fd.lo iv_fd_poll.lo iv_fd_pump.lo = iv_main_posix.lo iv_popen.lo iv_signal.lo iv_thread_posix.lo = iv_tid_posix.lo iv_time_posix.lo iv_wait.lo iv_fd_kqueue.lo libtool: link: cc -shared -fPIC -DPIC .libs/iv_avl.o .libs/iv_event.o = =2Elibs/iv_fatal.o .libs/iv_task.o .libs/iv_timer.o .libs/iv_tls.o = =2Elibs/iv_work.o .libs/iv_event_raw_posix.o .libs/iv_fd.o = =2Elibs/iv_fd_poll.o .libs/iv_fd_pump.o .libs/iv_main_posix.o = =2Elibs/iv_popen.o .libs/iv_signal.o .libs/iv_thread_posix.o = =2Elibs/iv_tid_posix.o .libs/iv_time_posix.o .libs/iv_wait.o = =2Elibs/iv_fd_kqueue.o -O2 -fstack-protector-strong = -Wl,--version-script -Wl,../libivykis.posix.ver -fstack-protector-strong = -Wl,-soname -Wl,libivykis.so.0 -o .libs/libivykis.so.0.5.6 ld: error: version script assignment of 'IVYKIS_0.29' to symbol = 'iv_inotify_register' failed: symbol not defined ld: error: version script assignment of 'IVYKIS_0.29' to symbol = 'iv_inotify_unregister' failed: symbol not defined ld: error: version script assignment of 'IVYKIS_0.29' to symbol = 'iv_inotify_watch_register' failed: symbol not defined ld: error: version script assignment of 'IVYKIS_0.29' to symbol = 'iv_inotify_watch_unregister' failed: symbol not defined cc: error: linker command failed with exit code 1 (use -v to see = invocation) I believe the issue is that it doesn=E2=80=99t build inotify code on Free= BSD, = but still mentions the relevant functions in the linker script. The = other affected ports I=E2=80=99ve run into appear to have similar issues.= There=E2=80=99s likely to be a fair amount of fallout from that, e.g. = https://github.com/llvm/llvm-project/issues/75056 I=E2=80=99m not sure what the best path forward is. Should we try to make= ld = warn but not fail on issues like that, or fix each affected port or ? Best regards, Kristof --=_MailMate_3A3E899A-1A08-45A1-8DA9-E72DA079425D_= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 8 Dec 2023, at 18:39, Dimitry Andric wrote:

The branch main has been updated by= dim:

URL: https://cgit.FreeBSD.org/src/co= mmit/?id=3D5c16e71d30c388dd43b217de10a3ccb4b0219d0d

commit 5c16e71d30c388dd43b217de10a3ccb4b0219d0d
Merge: b121cb0095c8 703029dbba78
Author: Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2023-11-30 20:06:52 +0000
Commit: Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2023-12-08 17:35:59 +0000

Merge llvm-project release/17.x llvmorg-17.0.6-0-g600= 9708b4367

This updates llvm, clang, compiler-rt, libc++, libunw= ind, lld, lldb and
openmp to llvmorg-17.0.6-0-g6009708b4367.

PR: 273753
MFC after: 1 month


There appears to be some fallout in some ports.

For example, devel/ivykis (but also sysutils/flashrom and= databases/rrdtool) fails like this:

/b=
in/sh ../libtool  --tag=3DCC    --mode=3Dlink cc  -O2 -pipe  -fstack-prot=
ector-strong -fno-strict-aliasing  -Wall  -version-info 5:6:5 -Wl,--versi=
on-script,../libivykis.posix.ver -fstack-protector-strong -o libivykis.la=
 -rpath /usr/local/lib iv_avl.lo iv_event.lo iv_fatal.lo iv_task.lo  iv_t=
imer.lo iv_tls.lo iv_work.lo iv_event_raw_posix.lo iv_fd.lo  iv_fd_poll.l=
o iv_fd_pump.lo iv_main_posix.lo  iv_popen.lo iv_signal.lo iv_thread_posi=
x.lo  iv_tid_posix.lo iv_time_posix.lo iv_wait.lo    iv_fd_kqueue.lo
libtool: link: cc -shared  -fPIC -DPIC  .libs/iv_avl.o .libs/iv_event.o .=
libs/iv_fatal.o .libs/iv_task.o .libs/iv_timer.o .libs/iv_tls.o .libs/iv_=
work.o .libs/iv_event_raw_posix.o .libs/iv_fd.o .libs/iv_fd_poll.o .libs/=
iv_fd_pump.o .libs/iv_main_posix.o .libs/iv_popen.o .libs/iv_signal.o .li=
bs/iv_thread_posix.o .libs/iv_tid_posix.o .libs/iv_time_posix.o .libs/iv_=
wait.o .libs/iv_fd_kqueue.o    -O2 -fstack-protector-strong -Wl,--version=
-script -Wl,../libivykis.posix.ver -fstack-protector-strong   -Wl,-soname=
 -Wl,libivykis.so.0 -o .libs/libivykis.so.0.5.6
ld: error: version script assignment of 'IVYKIS_0.29' to symbol 'iv_inoti=
fy_register' failed: symbol not defined
ld: error: version script assignment of 'IVYKIS_0.29' to symbol 'iv_inoti=
fy_unregister' failed: symbol not defined
ld: error: version script assignment of 'IVYKIS_0.29' to symbol 'iv_inoti=
fy_watch_register' failed: symbol not defined
ld: error: version script assignment of 'IVYKIS_0.29' to symbol 'iv_inoti=
fy_watch_unregister' failed: symbol not defined
cc: error: linker command failed with exit code 1 (use -v to see invocati=
on)

I believe the issue is that it doesn=E2=80=99t build inot= ify code on FreeBSD, but still mentions the relevant functions in the lin= ker script. The other affected ports I=E2=80=99ve run into appear to have= similar issues.

There=E2=80=99s likely to be a fair amount of fallout fro= m that, e.g. https://github.com/llvm/llvm-project/issues/75056

I=E2=80=99m not sure what the best path forward is. Shoul= d we try to make ld warn but not fail on issues like that, or fix each af= fected port or ?

Best regards,
Kristof

--=_MailMate_3A3E899A-1A08-45A1-8DA9-E72DA079425D_=--