Re: git: 83d0b8c089d8 - main - bsdinstall generate opt_osname.h in include

From: Simon J. Gerraty <sjg_at_juniper.net>
Date: Thu, 07 Dec 2023 23:24:35 UTC 
Warner Losh <imp@bsdimp.com> wrote:
> > > The reason I did it using a file is so that make(1) would detect a
> > > change a rebuild if you change the value and do another build.
> 
> A fair point.  Of course moot if using META_MODE.
> The other benefit of the header is only the files that include it will
> be rebuilt when the value changes whereas (with META_MODE) everything
> will be rebuilt if value is in CFLAGS.
> 
> That can be mitigated by using per object CFLAGS, but all in all the
> header is a simpler solution.
> 
> This name never changes on practice.  We shouldn't optimize for a rare
> case that causes build races. Who would ever change it in the same
> tree? 

Also a fair point.

I'm happy to do it either way - so long as we avoid circular
dependencies.