From nobody Thu Dec 07 15:02:09 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SmHYm66d2z537CF; Thu, 7 Dec 2023 15:02:20 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SmHYm5cdyz4JDf; Thu, 7 Dec 2023 15:02:20 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701961340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jQcDETLvcBLM10VUEi1DS0g0k+CygBnfkt9V01XOEVM=; b=AxpJAs16xSte2iXS8DgQBTn4D+KIJyXMVcUeG9aTKx5t7PovwsLxp/CY9WIM3wKl6VY4c/ snWFex0NufdXQxiPHUmWhQ2U3cgKAblsNl2c3j/VrgOBdHFtZTlnNWKhvoYGntbuVECLzd BA2tYNDDy0zmS5/6qfeKU07K5d9+GxR4haXTJOl3TDAcOy0m3KCNMIGePXq4BAot/GPNu5 ayAzvpCxy178QTXCjER/TaC1pbA3sXlIwLp15bTiBoSbyP569kVyd9uYfLd32G3TUq+awD Yx2kNNLrfM5uCVGqzkswK14hJOnJqZZ2bPtKBBArDSCe8PK2JoJOqZIBfDsKzA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701961340; a=rsa-sha256; cv=none; b=KSpAzJA9EeVF6sGzzG7RTznmhTYWbVfYVD4p54iVfme/AccnVvMJRU/8LQECqL1hxuH45Z XnyhpygJJVXgdYOaYE47yWMPoKcURm2P2jWC/Rtik2dbjv1MEY7f+5CAHd3hPtQY2mUDBj sxwyKjs5fKHeQZWN9ISzHPOjCd8Ocn4EN2jhxIvqsYcquK0ThL85V/sB0AUkk+u88c/sMG THfGW2dwa78HdtcepU8lGrk9Cx/Kq28D4K/TrCG+zVM9bjFTFZnGaedEIFBiRJTBytUCBA h1qeOz4MK2r74rT9Z0LwcBLvgfbMHbHPAuY49PqIUcLZWC4brB2yPwwk8DmXvQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701961340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jQcDETLvcBLM10VUEi1DS0g0k+CygBnfkt9V01XOEVM=; b=XqhjIJhKMRPdcBjznGvb5RCcbfOD9rThG1rhi0v5kRQGVkgG+R4gB1Vf7UL9V7dlAlKIF4 RmuZb2XkTjcMNAPxGECkb9JBmrDUQFxTMvOwLNdz2x43xSWacs7xByu6RDqPnbqSDz4DlK ogXaaj/D4IKCLx4st3XZJvv/haVm/durepzvHRbQuswQiI8OqzCNVYqKcMQ77wQu0+vBBH GUO7Uys31vMzxYsSL0vZcmB5TvsLVF8HAmU43evuffvT5MXG/rgZjX+3mYPe5NBJWgQpBz SRfcj4wcRxtF4mr9zp2Qwe2P9uGH9N/rmS2mt+N7Wnhd/UMCOsELF+il+/f4rg== Received: from smtpclient.apple (unknown [111.29.165.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SmHYk6RM8zB9W; Thu, 7 Dec 2023 15:02:18 +0000 (UTC) (envelope-from zlei@FreeBSD.org) From: Zhenlei Huang Message-Id: <5DC76457-C348-49C6-8EDE-763EB014D9DC@FreeBSD.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_75CB8794-64FC-46C6-A8B3-8588880C3BE4" List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: git: 6b96125afdf2 - main - cap_net.3: remove a copypasta Date: Thu, 7 Dec 2023 23:02:09 +0800 In-Reply-To: Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , li-Wen Hsu To: Alan Somers References: <202312061652.3B6GqOuf068349@gitrepo.freebsd.org> <44E8C9F3-84DD-4E51-B2A4-FB56E2A08F30@FreeBSD.org> X-Mailer: Apple Mail (2.3696.120.41.1.4) --Apple-Mail=_75CB8794-64FC-46C6-A8B3-8588880C3BE4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Dec 7, 2023, at 11:59 AM, Alan Somers wrote: >=20 > On Wed, Dec 6, 2023 at 6:55=E2=80=AFPM Zhenlei Huang > wrote: >>=20 >>=20 >>=20 >>> On Dec 7, 2023, at 12:52 AM, Alan Somers = wrote: >>>=20 >>> The branch main has been updated by asomers: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D6b96125afdf245ae61dd82b59891ad0d= 6aab0066 >>>=20 >>> commit 6b96125afdf245ae61dd82b59891ad0d6aab0066 >>> Author: Alan Somers >>> AuthorDate: 2023-12-05 23:23:29 +0000 >>> Commit: Alan Somers >>> CommitDate: 2023-12-06 16:51:37 +0000 >>>=20 >>> cap_net.3: remove a copypasta >>>=20 >>> This line appears to have been copied from cap_sysctl.3. While = I'm >>> here, reorder and reword the description of cap_net_limit a bit. >>>=20 >>> [skip ci] >>=20 >> I guess we can 'skip ci' implicitly for document or typo changes. >=20 > Can we? The skipping logic is builtin to Jenkins, Github Workflows, > and Cirrus. I don't think it would be easy to program any of those to > detect which changes can be safely skipped. Sorry for the misleading word 'can', I think it is accurate to reword it = to 'want to'. 1. To detect document changes, I think checking the names of changed = files is sufficient. 2. As for the typo change, we can check the commit log. A false detecting (if the change is SKIP CI candidate) does not hurt = much, as it will be queued up to next running of CI. So I think the simple logic above is practical. > -Alan --Apple-Mail=_75CB8794-64FC-46C6-A8B3-8588880C3BE4 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On Dec 7, 2023, at 11:59 AM, Alan Somers <asomers@freebsd.org>= wrote:

On Wed, Dec 6, 2023 at 6:55=E2=80=AFPM Zhenlei Huang = <zlei@freebsd.org> = wrote:



On Dec 7, 2023, at 12:52 AM, Alan Somers <asomers@freebsd.org>= wrote:

The branch main has been updated by = asomers:

URL: https://cgit.FreeBSD.org/src/commit/?id=3D6b96125afdf245ae61dd8= 2b59891ad0d6aab0066

commit = 6b96125afdf245ae61dd82b59891ad0d6aab0066
Author: =     Alan Somers <asomers@FreeBSD.org>
AuthorDate: = 2023-12-05 23:23:29 +0000
Commit: =     Alan Somers <asomers@FreeBSD.org>
CommitDate: = 2023-12-06 16:51:37 +0000

  cap_net.3: remove a copypasta

  This line appears to have been copied from = cap_sysctl.3.  While I'm
  here, reorder = and reword the description of cap_net_limit a bit.

  [skip ci]

I guess we can 'skip ci' implicitly for document or typo = changes.

Can we?   The skipping logic is builtin to Jenkins, = Github Workflows,
and Cirrus.  I don't think it would be easy to program = any of those to
detect which changes can be safely skipped.

Sorry = for the misleading word 'can', I think it is accurate to reword it to 'want to'.

1. To detect document changes, I think checking = the names of changed files is sufficient.
2. As for the typo = change, we can check the commit log.

A= false detecting (if the change is SKIP CI candidate) does not hurt = much, as it will be queued up
to next running of CI. So I = think the simple logic above is = practical.

-Alan



= --Apple-Mail=_75CB8794-64FC-46C6-A8B3-8588880C3BE4--