From nobody Thu Dec 07 04:54:25 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sm2526tNDz53b5k; Thu, 7 Dec 2023 04:55:02 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Sectigo RSA Organization Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sm2524qznz3RVB; Thu, 7 Dec 2023 04:55:02 +0000 (UTC) (envelope-from sjg@juniper.net) Authentication-Results: mx1.freebsd.org; none Received: from pps.filterd (m0108161.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B6NoS4g007253; Wed, 6 Dec 2023 20:55:00 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=to : cc : subject : in-reply-to : references : from : mime-version : content-type : content-transfer-encoding : date : message-id; s=PPS1017; bh=g9z6D6P4WnqqSq6bwwzDrkrspCbZ3r0euZHKuVGT2jc=; b=nlsuCWtvD+Wm9A69d4eWzC8l+eF8ZihgnaYgP/TRE0/ma+9s5qPzHGIrPaG63tj51r7x HuCM33P7njEuJS3GaD62pBFE2WDLUHcgt1wKs2hl1jMi9rNyJ5SaoQTRO5Dtq+K0yudz bTVrWlMZ37x4waCxd3KSerm2gjbP9Sidob2v2So3pDzzLXSYrYkagHaTkm3DqbhPg4wx 3X05jJs2mgXDa9q/Tue+61hyydFiL6J54oWInQdV+Vecz3mv3Jt2+KnkeOSN2/jgoJCI gHKpb7deHnyyZRNW5c2QVpwO+wNYcZIeU5cEXe6U9SeYYss9KVccEvTCbwv3obIQuhUi 0w== Received: from co1pr02cu001.outbound.protection.outlook.com (mail-westus2azlp17011018.outbound.protection.outlook.com [40.93.10.18]) by mx0b-00273201.pphosted.com (PPS) with ESMTPS id 3utps2u7js-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 06 Dec 2023 20:55:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ISSmRd+4t/01YhrY2acZiYE7EtZPAaB88wB82WjXxTuzu5FOT7NZQT4UtLEzr0JjEn7574MM89DlJ53k2iH9ZFFbwlYWRqPwLMc5FTo1id8LkZbjPDvN0gRmUkV9ODfgXgPq9uSkENmpT1ngF3o5IHKGRnuP3WOVE9NkjPPcNR22huVm9KnWLVXLc+YVOFmDapLIw+e3xF5kKJamIXhhl0PumTNB8e2uRJ3o6YCgIKeOimXOR3MHzrR2kRWlmrhGwu/PC5ZB7z6f6t+5z9pUxNzEVcMyjbZZCWN2bTAlKx+GpZ7StQPMCouAllcLP6M8xG6ISLQc6SiDdtPXJqhUng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g9z6D6P4WnqqSq6bwwzDrkrspCbZ3r0euZHKuVGT2jc=; b=WjoTuhkaRuykKim/xQCYzPqIDzTE2dgj9HWPKlOduQ57wGHrMo9qQed8bwbhqUa9IgFMPvn35DLr90ZehgvbQUuxrLR/NLYCHSfmngq9PejEdZWo8PV2rnCFzVGYxMHu7mWj0UxPvAVlQYcH0V26HZ3XAX7vHb7983tjfSpLOPy/7sCZRdCGdrynFDmxqpkwvP5g7DdfX5HxMDhVdi6lyMWJjbrNu4bhm/mFZdyJqxvcuSzgirh7EOMpfjf0wHBv/x57ExLBJyFBtkoZPgX4Og32BRQh6qjvOTMzryAzFVtBNcoAilx4VfGU71hiZ+uhUgBoTk6HCQjQEWUl45mxJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 66.129.242.15) smtp.rcpttodomain=freebsd.org smtp.mailfrom=juniper.net; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=juniper.net; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g9z6D6P4WnqqSq6bwwzDrkrspCbZ3r0euZHKuVGT2jc=; b=P+gyuUUQ9u8ZffbrqEhlpnBW4VSHbG0qeU0RxLZFyGz9V+SQxq/cyXkQ12S2ayZwzFsHwt94CmqQaPwsiYpzRMPnJtSFycpitXJrOOgL2V24zc8aTS4uq3ItEO6941bI5IzgOlnWOHy2U2KW+PRm9LWhmL6iIZVXH8SMuXIidA4= Received: from BN0PR07CA0026.namprd07.prod.outlook.com (2603:10b6:408:141::26) by DM4PR05MB10309.namprd05.prod.outlook.com (2603:10b6:8:b6::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.27; Thu, 7 Dec 2023 04:54:55 +0000 Received: from BN8NAM12FT019.eop-nam12.prod.protection.outlook.com (2603:10b6:408:141:cafe::ed) by BN0PR07CA0026.outlook.office365.com (2603:10b6:408:141::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34 via Frontend Transport; Thu, 7 Dec 2023 04:54:55 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 66.129.242.15) smtp.mailfrom=juniper.net; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.242.15 as permitted sender) Received: from p-exchfe-eqx-02.jnpr.net (66.129.242.15) by BN8NAM12FT019.mail.protection.outlook.com (10.13.183.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.14 via Frontend Transport; Thu, 7 Dec 2023 04:54:55 +0000 Received: from p-exchbe-eqx-01.jnpr.net (10.104.9.14) by p-exchfe-eqx-02.jnpr.net (10.104.9.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Wed, 6 Dec 2023 22:54:54 -0600 Received: from p-exchbe-eqx-01.jnpr.net (10.104.9.14) by p-exchbe-eqx-01.jnpr.net (10.104.9.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Wed, 6 Dec 2023 22:54:54 -0600 Received: from p-mailhub01.juniper.net (10.104.20.6) by p-exchbe-eqx-01.jnpr.net (10.104.9.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39 via Frontend Transport; Wed, 6 Dec 2023 22:54:54 -0600 Received: from kaos.jnpr.net (kaos.jnpr.net [172.23.255.201]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id 3B74ssST031174; Wed, 6 Dec 2023 20:54:54 -0800 (envelope-from sjg@juniper.net) Received: by kaos.jnpr.net (Postfix, from userid 1377) id 463D94D623; Wed, 6 Dec 2023 20:54:25 -0800 (PST) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id 44A164D4E9; Wed, 6 Dec 2023 20:54:25 -0800 (PST) To: Jessica Clarke CC: Warner Losh , src-committers , "" , "" , Subject: Re: git: 83d0b8c089d8 - main - bsdinstall generate opt_osname.h in include In-Reply-To: References: <202312070235.3B72ZoZp043061@gitrepo.freebsd.org> <71239.1701921562@kaos.jnpr.net> Comments: In-reply-to: Jessica Clarke message dated "Thu, 07 Dec 2023 04:03:29 +0000." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6+git; nmh 1.8; GNU Emacs 28.2 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Wed, 6 Dec 2023 20:54:25 -0800 Message-ID: <58331.1701924865@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM12FT019:EE_|DM4PR05MB10309:EE_ X-MS-Office365-Filtering-Correlation-Id: ce148393-c8fe-4847-c47d-08dbf6e0a809 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aPx5I9PY4VtYbKyKgDXPMudI8riyz01APcvMsiV7ZXK+/R2JznZ0M36WdBuljJ69NRJmrfsKwxyYC/wCKbrJb2TdDnIrRr9WlIcZCTnk6tsYHIp8n1mhHJMqXlxQ+7fecoY3rbvUsOPYCyukwSnMz6fILaNqwrfvIAtCLL9RBG480TE2Evp83yB7EV8auKnxiO8vqOVfpXPkD2UNtB0OMe0PuzXtIGJdffL+fLiYKFtg7H5XPzq1gVZJNEFWiuM31eV3r2QRmUP0AH6m93DsIda9C2p015zLr0hnuN/fUzsWVC/snraaj/t2kahx69Qkq3lD7g9Lnuw5dOb4B7Ievf3lMZtesIxbjpE+DjiMptnA4lcAS0T926o+pI0M1WFEzLQS+XDrSg/xZJPGv2AA8HonpcBlwdbkVchYTYkLdzHrmjmEG2BERjyjieotScIz0n6tkuX6J6v8zBXsRUrVNnFXnM2HzNryBbjc0eHgWQcBb2AygX1Tov+fc0XVFVaIVHwAgLausJ5uc7DkfNQ37pYLnA1lWQZoe9rB3OEQ+0YoJdS1WcWUtztB4CbQiZp1yWDaonHdli2Y9HLcaeVqJMdXUR7PlrQUmqYl9//M2Hie8O+vO2iEwGpP7hsQ2xPjmeS4SbziV9eZN0dt5MPZMO3ZVb2jKupKlD6/LEEITA1aitHBlGpoIJBHyNgCUDy7eARFu+7QwduLcY3k7Y978jWFXb2vT+dASZ1c99o/wyUKHbhsb7Flg0c/MDNl3te5cV5BqiXBle1IaKmAG89tbbG7xV8L4+TYg/8jauKKSlHTLt+m9AN8+mLoYl3qL/Dv X-Forefront-Antispam-Report: CIP:66.129.242.15;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:p-exchfe-eqx-02.jnpr.net;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(346002)(39860400002)(136003)(396003)(376002)(230922051799003)(451199024)(82310400011)(64100799003)(1800799012)(186009)(40470700004)(46966006)(36840700001)(86362001)(41300700001)(5660300002)(4744005)(2906002)(40460700003)(6266002)(40480700001)(26005)(83380400001)(82740400003)(55016003)(54906003)(70206006)(6916009)(70586007)(7696005)(478600001)(336012)(7126003)(107886003)(9686003)(316002)(8676002)(4326008)(47076005)(356005)(81166007)(8936002)(36860700001)(36900700001);DIR:OUT;SFP:1102; X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 04:54:55.3970 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce148393-c8fe-4847-c47d-08dbf6e0a809 X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4;Ip=[66.129.242.15];Helo=[p-exchfe-eqx-02.jnpr.net] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM12FT019.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR05MB10309 X-Proofpoint-GUID: w9qv_WxLNv3vSZUFnAG7TYUuvNKSFre7 X-Proofpoint-ORIG-GUID: w9qv_WxLNv3vSZUFnAG7TYUuvNKSFre7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-07_02,2023-12-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 suspectscore=0 clxscore=1015 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=410 priorityscore=1501 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312070037 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:22843, ipnet:67.231.152.0/24, country:US] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4Sm2524qznz3RVB Jessica Clarke wrote: > > Warner Losh wrote: > >> Silly question: why not just add it to CFLAGS with > >> -DOSNAME=3D\"${OSNAME}\" rather than generating this file? > > > > Actually it is an excellent question - I've no idea why opt_osname.h is > > needed. >=20 > To quote the motivation from brd@=E2=80=99s original review: >=20 > > The reason I did it using a file is so that make(1) would detect a > > change a rebuild if you change the value and do another build. A fair point. Of course moot if using META_MODE. The other benefit of the header is only the files that include it will be rebuilt when the value changes whereas (with META_MODE) everything will be rebuilt if value is in CFLAGS. That can be mitigated by using per object CFLAGS, but all in all the header is a simpler solution. --sjg