Re: git: 83d0b8c089d8 - main - bsdinstall generate opt_osname.h in include

On 7 Dec 2023, at 03:59, Simon J. Gerraty <sjg@juniper.net> wrote:
> Warner Losh <imp@bsdimp.com> wrote:
>> Silly question: why not just add it to CFLAGS with
>> -DOSNAME=\"${OSNAME}\" rather than generating this file?
> 
> Actually it is an excellent question - I've no idea why opt_osname.h is
> needed.

To quote the motivation from brd@’s original review:

> The reason I did it using a file is so that make(1) would detect a
> change a rebuild if you change the value and do another build.

-- https://reviews.freebsd.org/D34878#791429

Jess