Re: git: 44f8e1e8530e - main - ossl: Add support for armv7

From: Mark Johnston <markj_at_freebsd.org>
Date: Fri, 01 Dec 2023 15:38:12 UTC 
On Thu, Nov 30, 2023 at 06:00:52PM +0000, Jessica Clarke wrote:
> On 30 Nov 2023, at 17:51, Mark Johnston <markj@FreeBSD.org> wrote:
> > 
> > The branch main has been updated by markj:
> > 
> > URL: https://cgit.FreeBSD.org/src/commit/?id=44f8e1e8530e1d2e95e84bbbe3d22ac9cb2557fe
> > 
> > commit 44f8e1e8530e1d2e95e84bbbe3d22ac9cb2557fe
> > Author:     Mark Johnston <markj@FreeBSD.org>
> > AuthorDate: 2023-11-30 17:46:08 +0000
> > Commit:     Mark Johnston <markj@FreeBSD.org>
> > CommitDate: 2023-11-30 17:49:47 +0000
> > 
> >    ossl: Add support for armv7
> > 
> >    OpenSSL provides implementations of several AES modes which use
> >    bitslicing and can be accelerated on CPUs which support the NEON
> >    extension.  This patch adds arm platform support to ossl(4) and provides
> >    an AES-CBC implementation, though bsaes_cbc_encrypt() only implements
> >    decryption.  The real goal is to provide an accelerated AES-GCM
> >    implementation; this will be added in a subsequent patch.
> > 
> >    Initially derived from https://reviews.freebsd.org/D37420.
> > 
> >    Reviewed by:    jhb
> >    Sponsored by:   Klara, Inc.
> >    Sponsored by:   Stormshield
> >    MFC after:      3 months
> >    Differential Revision:  https://reviews.freebsd.org/D41304
> > ---
> > sys/conf/files.arm                | 10 +++++
> > sys/crypto/openssl/arm/arm_arch.h | 84 ++++++++++++++++++++++++++++++++++
> 
> Upstream has just the one copy of this in an MI directory. Can we avoid
> duplicating it in sys/crypto, whether by moving it into the MI
> directory (since it has an MD name already so collisions aren’t an
> issue) or having a shared MD directory between armv7 and aarch64?

Yes, good point: https://reviews.freebsd.org/D42866