From nobody Wed Apr 26 05:39:00 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q5njd12B3z47GKV; Wed, 26 Apr 2023 05:39:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q5njd0YPrz4MqV; Wed, 26 Apr 2023 05:39:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682487541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=n5ws5iujob0ycKfWtNQm5JQRgVpPPPkpZtCrrpZOIMQ=; b=EC9kmzMATgnJY1RYArKCpcGP/47FHZOTm76dfLOgJATTVlyHqDrlMBjAwF2RiYvSwk2TX5 pdX+0yJ0JrrpTxekxxsfSNZSR4qQoxYOqhd7tjnDOUw8McyztS1TCI3QMpFCxLUb+rA/tn TZi32nQzYvm0rtpeVmQjUMrO1DWHFw6iG6jgBIdkxWPeYE1gWXW1TVYUqWeGVD4moCxQEP rlVvJu/TUIWXWYIS3Y+R8HYCn++0m82iP39E0m1NPXi844YsqZiN+1ZtEehQU3AZrK5OaP 4GDSgCQA4kRBSlfk/bgTMP08W65prruIFAQV3aS/iZFnBgIFk7g98k6jS5Igyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682487541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=n5ws5iujob0ycKfWtNQm5JQRgVpPPPkpZtCrrpZOIMQ=; b=Nox0HlOVNdjKwpzDJEvZGc25GOjMb/5hBcwL+MAf39TSN1Bo+XLVvwGLwS3QExMwYJ4eCt NJcax2EWikjH8qJmd1+aSu40FdAN7T+gpYSQbP/A/0Aa96X5dy/mAUgfxgXOIoxDnxlawf FDu9ruoimtAJbXiuV3xtNW0tHIIDsRcVyYZkRHiFilOsH0Pc/JDfpMWNmk39DUbsY6jdm/ leL7/88zFiE5/gHSwU/+ENaIpuFcOsGQx8aUUbMoVllzNR1KDJ+IrlWzL3wvh0LUc2L/Zn UKO8rE7NRrbLSNgK4FynYu17dbmDP+a6vVrHm288ut08XvflnCPHFyizEPHj1g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682487541; a=rsa-sha256; cv=none; b=RBmv71XHb82P/DqawjdpBA98vK0pZP8Ci0151u4qCJv3g5i4zD13OgQEh0eQqCmCL6nH8N 9/TqArei5pT17aBetsG8w/HpVSQMK9k0aszsfSM7nxFHP+7l9xoLoAYRIs0IDbHXzoPi5g teYtvAtG7mVeMuBQulkkD0flxiKr/5PR7U9TaGMJDMdL9CLLp/yZ1F9fFyrnMpnQknWGpa OyU4SJMQIEVKns43FTAW9qZtLEIgrAP6IxztL23MMWx30VoqI1QeMP86RWj2JmoJZtzDCp N/Z6JlZqKBstqfWMvtFVPoHVSvRIFqHfRU81By/I9+dFWLUU01rexGjjsJMYnw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q5njc6kJMzMsx; Wed, 26 Apr 2023 05:39:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33Q5d0Kb030135; Wed, 26 Apr 2023 05:39:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33Q5d0gr030134; Wed, 26 Apr 2023 05:39:00 GMT (envelope-from git) Date: Wed, 26 Apr 2023 05:39:00 GMT Message-Id: <202304260539.33Q5d0gr030134@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: 61fd6a1ea296 - main - Note that static hints no longer break loader hints List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 61fd6a1ea2961736952ef060b625637f9816343c Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=61fd6a1ea2961736952ef060b625637f9816343c commit 61fd6a1ea2961736952ef060b625637f9816343c Author: Kyle Evans AuthorDate: 2023-04-26 05:38:32 +0000 Commit: Kyle Evans CommitDate: 2023-04-26 05:38:32 +0000 Note that static hints no longer break loader hints This commentary was carried over from the x86 version of the same code, but has actually been inaccurate for a while now. As of FreeBSD 12.x, all environments are used unless they disable each other. See 39d44f7f15c ("kern_environment: use any provided environments [...]") for details. Reviewed by: imp Differentiala Revision: https://reviews.freebsd.org/D35695 --- stand/efi/loader/arch/arm64/exec.c | 8 +++----- sys/arm64/acpica/OsdEnvironment.c | 3 +-- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/stand/efi/loader/arch/arm64/exec.c b/stand/efi/loader/arch/arm64/exec.c index 3cf1c1857f51..a8cd80cd0fc6 100644 --- a/stand/efi/loader/arch/arm64/exec.c +++ b/stand/efi/loader/arch/arm64/exec.c @@ -83,11 +83,9 @@ elf64_exec(struct preloaded_file *fp) /* * Report the RSDP to the kernel. The old code used the 'hints' method - * to communite this to the kernel. However, while convenient, the - * 'hints' method is fragile and does not work when static hints are - * compiled into the kernel. Instead, move to setting different tunables - * that start with acpi. The old 'hints' can be removed before we branch - * for FreeBSD 15. + * to communicate this to the kernel, but this is now considered legacy. + * Instead, move to setting different tunables that start with acpi. + * The old 'hints' can be removed before we branch for FreeBSD 15. */ rsdp = efi_get_table(&acpi20_guid); diff --git a/sys/arm64/acpica/OsdEnvironment.c b/sys/arm64/acpica/OsdEnvironment.c index d1590bee7753..2659d1c7da84 100644 --- a/sys/arm64/acpica/OsdEnvironment.c +++ b/sys/arm64/acpica/OsdEnvironment.c @@ -65,8 +65,7 @@ acpi_get_root_from_loader(void) return (acpi_root); /* - * The hints mechanism is unreliable (it fails if anybody ever - * compiled in hints to the kernel). It has been replaced + * The hints mechanism is considered legacy and has been replaced * by the tunable method, but is used here as a fallback to * retain maximum compatibility between old loaders and new * kernels. It can be removed after 14.0R.