From nobody Mon Apr 17 16:26:55 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q0XWN0PQKz44sZB; Mon, 17 Apr 2023 16:26:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q0XWM5CLNz41jJ; Mon, 17 Apr 2023 16:26:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681748815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pGd2UgaTkcK19fm39dogaaDXgIR6r9RoaZ0eedPuG58=; b=AlN+SxMBrxZDk3h9COnCfQx91kDpR3MlBpDQ8a1hCGOp176L6omj7VCAb1rboObLZk2rPt 1o1fqtfrbuE3mnOsE6G1HzdKRS4drWPjZD5N6xCOk3pZ1hWpUnzPblix04zdLxSbIfqRQI KvbqfaKY9Kt6v6jnJ7uRoSHioUb/QWS6YH9iZNi/nEBp//La2zGeXyo5YCazviRd/JqEkj ttWmwBNoiQchp24Hos+mZIkRoKcISYMH+MXxYlJdmJMJQ6Bf9LfHFoVXjgZxmLz0a8PmPN 6v2Rk+JKkE8h6NcOCxbP18o2EJ2nNzkMb08dCmbrkWhnSrg2rGx/6ZuVG2btSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681748815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pGd2UgaTkcK19fm39dogaaDXgIR6r9RoaZ0eedPuG58=; b=YSRB/34G8+3Z1aLzKFIaCU0dn3fu4lVk08AnHUtN84911L0D6Db0uIT15WkqnkVcUtTujP gPik7R49Ec9zMeh1m2+J7jglXFQbAeejfP2li1IZBGMQUjAn+OLlPuWYwUeg+lYV4XffDe jXiwMmh88DmvLP/U/0zSszRUR+7KaZxJv2vV0uBDOEZMl4sJwqkj63RCpXE5xXoOeY8SR7 sTJdYZloFsYfzkKWA3BWYqQ64tK/ifiCub13WuGgcYgFEHOMvg7yLrKi8rO3gZwHXXFFHD 4815P0F5QmmrgSaFiVRhd5WezbJCvuYXqVLV8W25ggS2H9ZRTuEUENK0OqY8Ew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681748815; a=rsa-sha256; cv=none; b=MnrsMifMzL9qNWOPnyT9O8NCKi9afZABRstrfwFu5tRjiCP7l6SiU6IrojAHTPiJKLWlPy NWaUynWLu06VkG6nfiCbSBn7FS8O48xU0gRy/FWrqJ0UN/CyaDoJ96iR81hsSMzAN7bUMP i/gz6NBLiWr1k/UeOYe4jrKDvAVhItep3FD0NxOAsGjb5Czfi+OWmhc+bV0r4Dq7Vcly/c fbii5A3fE+Y8TWoT+TQCEb3NnjunPPIGdh3c0Q4lnoAT2O7Y1Y8Sa3nCEhf/Xk+P4tf1Py EHlarIeU25KTJH11EoWY34XU4C4xxK7NBmJvw9bgEjZ2Q+ohbb5XPgnEAHZ26w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q0XWM4JT1zcHd; Mon, 17 Apr 2023 16:26:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33HGQtbF036543; Mon, 17 Apr 2023 16:26:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33HGQtqU036541; Mon, 17 Apr 2023 16:26:55 GMT (envelope-from git) Date: Mon, 17 Apr 2023 16:26:55 GMT Message-Id: <202304171626.33HGQtqU036541@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dimitry Andric Subject: git: 2ba84b4bcdd6 - main - Suppress lld 16 errors about undefined symbols in version maps List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2ba84b4bcdd6012e8cfbf8a0d060a4438623a638 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=2ba84b4bcdd6012e8cfbf8a0d060a4438623a638 commit 2ba84b4bcdd6012e8cfbf8a0d060a4438623a638 Author: Dimitry Andric AuthorDate: 2023-04-17 16:00:20 +0000 Commit: Dimitry Andric CommitDate: 2023-04-17 16:25:52 +0000 Suppress lld 16 errors about undefined symbols in version maps lld >= 16 turned on --no-undefined-version by default, which results in errors whenever symbols are mentioned in version maps, but are not actually defined in the binary. Since we have quite a few instances of symbols that are defined or not, depending on various compile-time settings, suppress this lld check for the time being. MFC after: 1 week --- share/mk/bsd.lib.mk | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/share/mk/bsd.lib.mk b/share/mk/bsd.lib.mk index c98dec9045bf..1d4a97134d41 100644 --- a/share/mk/bsd.lib.mk +++ b/share/mk/bsd.lib.mk @@ -262,6 +262,13 @@ SHLIB_NAME_FULL=${SHLIB_NAME} .if !empty(VERSION_MAP) ${SHLIB_NAME_FULL}: ${VERSION_MAP} LDFLAGS+= -Wl,--version-script=${VERSION_MAP} + +# lld >= 16 turned on --no-undefined-version by default, but we have several +# symbols in our version maps that may or may not exist, depending on +# compile-time defines. +.if ${LINKER_TYPE} == "lld" && ${LINKER_VERSION} >= 160000 +LDFLAGS+= -Wl,--undefined-version +.endif .endif .if defined(LIB) && !empty(LIB) || defined(SHLIB_NAME)